refactor: extract Ditto test document insertion into composite action

teodorciuraru · claude · teodorciuraru · commit 338f3b475547 · 2025-09-02T11:57:09.000+03:00
- Create ditto-test-document-insert composite action to eliminate duplication - Refactor all 3 BrowserStack workflows to use the new action - Reduce ~30 lines of duplicated code across BrowserStack workflows - Enable reuse for future Flutter/React Native Ditto integration tests - Maintain identical functionality with project-type parameterization 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
diff --git a/.github/actions/ditto-test-document-insert/action.yml b/.github/actions/ditto-test-document-insert/action.yml
@@ -0,0 +1,53 @@
+name: 'Ditto Test Document Insert'
+description: 'Insert a GitHub test document into Ditto Cloud for integration testing'
+inputs:
+  project-type:
+    description: 'Project type identifier (e.g., "android-java", "android-kotlin", "flutter")'
+    required: true
+  ditto-api-key:
+    description: 'Ditto API key for document insertion'
+    required: true
+  ditto-api-url:
+    description: 'Ditto API URL'
+    required: true
+
+runs:
+  using: 'composite'
+  steps:
+    - name: Insert test document into Ditto Cloud
+      shell: bash
+      run: |
+        # Use GitHub run ID to create deterministic document ID
+        DOC_ID="github_${{ inputs.project-type }}_${GITHUB_RUN_ID}_${GITHUB_RUN_NUMBER}"
+        TIMESTAMP=$(date -u +"%Y-%m-%d %H:%M:%S UTC")
+        
+        # Insert document using curl with correct JSON structure
+        RESPONSE=$(curl -s -w "\n%{http_code}" -X POST \
+          -H 'Content-type: application/json' \
+          -H "Authorization: Bearer ${{ inputs.ditto-api-key }}" \
+          -d "{
+            \"statement\": \"INSERT INTO tasks DOCUMENTS (:newTask) ON ID CONFLICT DO UPDATE\",
+            \"args\": {
+              \"newTask\": {
+                \"_id\": \"${DOC_ID}\",
+                \"title\": \"GitHub Test Task ${{ inputs.project-type }} ${GITHUB_RUN_ID}\",
+                \"done\": false,
+                \"deleted\": false
+              }
+            }
+          }" \
+        "https://${{ inputs.ditto-api-url }}/api/v4/store/execute")
+        
+        # Extract HTTP status code and response body
+        HTTP_CODE=$(echo "$RESPONSE" | tail -n1)
+        BODY=$(echo "$RESPONSE" | head -n-1)
+        
+        # Check if insertion was successful
+        if [ "$HTTP_CODE" -eq 200 ] || [ "$HTTP_CODE" -eq 201 ]; then
+          echo "✓ Successfully inserted test document with ID: ${DOC_ID}"
+          echo "GITHUB_TEST_DOC_ID=${DOC_ID}" >> $GITHUB_ENV
+        else
+          echo "❌ Failed to insert document. HTTP Status: $HTTP_CODE"
+          echo "Response: $BODY"
+          exit 1
+        fi
diff --git a/.github/workflows/android-cpp-browserstack.yml b/.github/workflows/android-cpp-browserstack.yml
@@ -44,41 +44,11 @@ jobs:
           ditto-websocket-url: ${{ secrets.DITTO_WEBSOCKET_URL }}
 
       - name: Insert test document into Ditto Cloud
-        run: |
-          # Use GitHub run ID to create deterministic document ID
-          DOC_ID="github_android_cpp_${GITHUB_RUN_ID}_${GITHUB_RUN_NUMBER}"
-          TIMESTAMP=$(date -u +"%Y-%m-%d %H:%M:%S UTC")
-          
-          # Insert document using curl with correct JSON structure for Android CPP app
-          RESPONSE=$(curl -s -w "\n%{http_code}" -X POST \
-            -H 'Content-type: application/json' \
-            -H "Authorization: Bearer ${{ secrets.DITTO_API_KEY }}" \
-            -d "{
-              \"statement\": \"INSERT INTO tasks DOCUMENTS (:newTask) ON ID CONFLICT DO UPDATE\",
-              \"args\": {
-                \"newTask\": {
-                  \"_id\": \"${DOC_ID}\",
-                  \"title\": \"GitHub Test Task CPP ${GITHUB_RUN_ID}\",
-                  \"done\": false,
-                  \"deleted\": false
-                }
-              }
-            }" \
-          "https://${{ secrets.DITTO_API_URL }}/api/v4/store/execute")
-          
-          # Extract HTTP status code and response body
-          HTTP_CODE=$(echo "$RESPONSE" | tail -n1)
-          BODY=$(echo "$RESPONSE" | head -n-1)
-          
-          # Check if insertion was successful
-          if [ "$HTTP_CODE" -eq 200 ] || [ "$HTTP_CODE" -eq 201 ]; then
-            echo "✓ Successfully inserted test document with ID: ${DOC_ID}"
-            echo "GITHUB_TEST_DOC_ID=${DOC_ID}" >> $GITHUB_ENV
-          else
-            echo "❌ Failed to insert document. HTTP Status: $HTTP_CODE"
-            echo "Response: $BODY"
-            exit 1
-          fi
+        uses: ./.github/actions/ditto-test-document-insert
+        with:
+          project-type: android-cpp
+          ditto-api-key: ${{ secrets.DITTO_API_KEY }}
+          ditto-api-url: ${{ secrets.DITTO_API_URL }}
 
       - name: Cache Gradle
         uses: ./.github/actions/gradle-cache
diff --git a/.github/workflows/android-java-browserstack.yml b/.github/workflows/android-java-browserstack.yml
@@ -40,41 +40,11 @@ jobs:
           ditto-websocket-url: ${{ secrets.DITTO_WEBSOCKET_URL }}
 
       - name: Insert test document into Ditto Cloud
-        run: |
-          # Use GitHub run ID to create deterministic document ID
-          DOC_ID="github_android_java_${GITHUB_RUN_ID}_${GITHUB_RUN_NUMBER}"
-          TIMESTAMP=$(date -u +"%Y-%m-%d %H:%M:%S UTC")
-          
-          # Insert document using curl with correct JSON structure for Android Java app
-          RESPONSE=$(curl -s -w "\n%{http_code}" -X POST \
-            -H 'Content-type: application/json' \
-            -H "Authorization: Bearer ${{ secrets.DITTO_API_KEY }}" \
-            -d "{
-              \"statement\": \"INSERT INTO tasks DOCUMENTS (:newTask) ON ID CONFLICT DO UPDATE\",
-              \"args\": {
-                \"newTask\": {
-                  \"_id\": \"${DOC_ID}\",
-                  \"title\": \"GitHub Test Task Java ${GITHUB_RUN_ID}\",
-                  \"done\": false,
-                  \"deleted\": false
-                }
-              }
-            }" \
-          "https://${{ secrets.DITTO_API_URL }}/api/v4/store/execute")
-          
-          # Extract HTTP status code and response body
-          HTTP_CODE=$(echo "$RESPONSE" | tail -n1)
-          BODY=$(echo "$RESPONSE" | head -n-1)
-          
-          # Check if insertion was successful
-          if [ "$HTTP_CODE" -eq 200 ] || [ "$HTTP_CODE" -eq 201 ]; then
-            echo "✓ Successfully inserted test document with ID: ${DOC_ID}"
-            echo "GITHUB_TEST_DOC_ID=${DOC_ID}" >> $GITHUB_ENV
-          else
-            echo "❌ Failed to insert document. HTTP Status: $HTTP_CODE"
-            echo "Response: $BODY"
-            exit 1
-          fi
+        uses: ./.github/actions/ditto-test-document-insert
+        with:
+          project-type: android-java
+          ditto-api-key: ${{ secrets.DITTO_API_KEY }}
+          ditto-api-url: ${{ secrets.DITTO_API_URL }}
 
       - name: Cache Gradle
         uses: ./.github/actions/gradle-cache
diff --git a/.github/workflows/android-kotlin-browserstack.yml b/.github/workflows/android-kotlin-browserstack.yml
@@ -40,41 +40,11 @@ jobs:
           ditto-websocket-url: ${{ secrets.DITTO_WEBSOCKET_URL }}
 
       - name: Insert test document into Ditto Cloud
-        run: |
-          # Use GitHub run ID to create deterministic document ID
-          DOC_ID="github_android_kotlin_${GITHUB_RUN_ID}_${GITHUB_RUN_NUMBER}"
-          TIMESTAMP=$(date -u +"%Y-%m-%d %H:%M:%S UTC")
-          
-          # Insert document using curl with correct JSON structure for Android Kotlin app
-          RESPONSE=$(curl -s -w "\n%{http_code}" -X POST \
-            -H 'Content-type: application/json' \
-            -H "Authorization: Bearer ${{ secrets.DITTO_API_KEY }}" \
-            -d "{
-              \"statement\": \"INSERT INTO tasks DOCUMENTS (:newTask) ON ID CONFLICT DO UPDATE\",
-              \"args\": {
-                \"newTask\": {
-                  \"_id\": \"${DOC_ID}\",
-                  \"title\": \"GitHub Test Task Kotlin ${GITHUB_RUN_ID}\",
-                  \"done\": false,
-                  \"deleted\": false
-                }
-              }
-            }" \
-          "https://${{ secrets.DITTO_API_URL }}/api/v4/store/execute")
-          
-          # Extract HTTP status code and response body
-          HTTP_CODE=$(echo "$RESPONSE" | tail -n1)
-          BODY=$(echo "$RESPONSE" | head -n-1)
-          
-          # Check if insertion was successful
-          if [ "$HTTP_CODE" -eq 200 ] || [ "$HTTP_CODE" -eq 201 ]; then
-            echo "✓ Successfully inserted test document with ID: ${DOC_ID}"
-            echo "GITHUB_TEST_DOC_ID=${DOC_ID}" >> $GITHUB_ENV
-          else
-            echo "❌ Failed to insert document. HTTP Status: $HTTP_CODE"
-            echo "Response: $BODY"
-            exit 1
-          fi
+        uses: ./.github/actions/ditto-test-document-insert
+        with:
+          project-type: android-kotlin
+          ditto-api-key: ${{ secrets.DITTO_API_KEY }}
+          ditto-api-url: ${{ secrets.DITTO_API_URL }}
 
       - name: Cache Gradle
         uses: ./.github/actions/gradle-cache
