Skip to content

Commit 3597b5f

Browse files
committed
fix(ci): remove spaces in GitHub Actions variable expansion syntax
React Native, React Native Expo, and Flutter workflows had incorrect syntax with spaces in variable references: PR_NUMBER="${ github.event.pull_request.number }" This caused variables to not expand, resulting in empty PR_NUMBER values and fallback to generic "Build #123" format on BrowserStack instead of "PR-185: [title] - [message]" format. Fixed to correct syntax: PR_NUMBER="${{ github.event.pull_request.number }}" Applied to: - react-native-ci.yml (Android + iOS sections) - react-native-expo-ci.yml (Android + iOS sections) - flutter-ci.yml (Android + iOS sections)
1 parent ed78f99 commit 3597b5f

File tree

3 files changed

+18
-18
lines changed

3 files changed

+18
-18
lines changed

.github/workflows/flutter-ci.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -509,9 +509,9 @@ jobs:
509509
DEVICES=$(yq eval -o=json -I=0 '.flutter.android.devices' .github/browserstack-devices.yml)
510510
511511
# Build BrowserStack project/build names with PR context
512-
PR_NUMBER="${ github.event.pull_request.number }"
513-
PR_TITLE="${ github.event.pull_request.title }"
514-
COMMIT_MSG="${ github.event.head_commit.message }"
512+
PR_NUMBER="${{ github.event.pull_request.number }}"
513+
PR_TITLE="${{ github.event.pull_request.title }}"
514+
COMMIT_MSG="${{ github.event.head_commit.message }}"
515515
516516
# Sanitize - keep only BrowserStack-allowed chars: A-Z a-z 0-9 . : - [ ] / @ & ' _
517517
PR_TITLE_CLEAN=$(echo "$PR_TITLE" | sed "s/[^A-Za-z0-9.:[\]\/@&' _-]//g")
@@ -793,9 +793,9 @@ jobs:
793793
DEVICES=$(yq eval -o=json -I=0 '.flutter.ios.devices' .github/browserstack-devices.yml)
794794
795795
# Build BrowserStack project/build names with PR context
796-
PR_NUMBER="${ github.event.pull_request.number }"
797-
PR_TITLE="${ github.event.pull_request.title }"
798-
COMMIT_MSG="${ github.event.head_commit.message }"
796+
PR_NUMBER="${{ github.event.pull_request.number }}"
797+
PR_TITLE="${{ github.event.pull_request.title }}"
798+
COMMIT_MSG="${{ github.event.head_commit.message }}"
799799
800800
# Sanitize - keep only BrowserStack-allowed chars: A-Z a-z 0-9 . : - [ ] / @ & ' _
801801
PR_TITLE_CLEAN=$(echo "$PR_TITLE" | sed "s/[^A-Za-z0-9.:[\]\/@&' _-]//g")

.github/workflows/react-native-ci.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -306,9 +306,9 @@ jobs:
306306
echo "Loaded devices: $DEVICES"
307307
308308
# Build BrowserStack project/build names with PR context
309-
PR_NUMBER="${ github.event.pull_request.number }"
310-
PR_TITLE="${ github.event.pull_request.title }"
311-
COMMIT_MSG="${ github.event.head_commit.message }"
309+
PR_NUMBER="${{ github.event.pull_request.number }}"
310+
PR_TITLE="${{ github.event.pull_request.title }}"
311+
COMMIT_MSG="${{ github.event.head_commit.message }}"
312312
313313
# Sanitize - keep only BrowserStack-allowed chars: A-Z a-z 0-9 . : - [ ] / @ & ' _
314314
PR_TITLE_CLEAN=$(echo "$PR_TITLE" | sed "s/[^A-Za-z0-9.:[\]\/@&' _-]//g")
@@ -510,9 +510,9 @@ jobs:
510510
echo "Loaded devices: $DEVICES"
511511
512512
# Build BrowserStack project/build names with PR context
513-
PR_NUMBER="${ github.event.pull_request.number }"
514-
PR_TITLE="${ github.event.pull_request.title }"
515-
COMMIT_MSG="${ github.event.head_commit.message }"
513+
PR_NUMBER="${{ github.event.pull_request.number }}"
514+
PR_TITLE="${{ github.event.pull_request.title }}"
515+
COMMIT_MSG="${{ github.event.head_commit.message }}"
516516
517517
# Sanitize - keep only BrowserStack-allowed chars: A-Z a-z 0-9 . : - [ ] / @ & ' _
518518
PR_TITLE_CLEAN=$(echo "$PR_TITLE" | sed "s/[^A-Za-z0-9.:[\]\/@&' _-]//g")

.github/workflows/react-native-expo-ci.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -313,9 +313,9 @@ jobs:
313313
echo "Loaded devices: $DEVICES"
314314
315315
# Build BrowserStack project/build names with PR context
316-
PR_NUMBER="${ github.event.pull_request.number }"
317-
PR_TITLE="${ github.event.pull_request.title }"
318-
COMMIT_MSG="${ github.event.head_commit.message }"
316+
PR_NUMBER="${{ github.event.pull_request.number }}"
317+
PR_TITLE="${{ github.event.pull_request.title }}"
318+
COMMIT_MSG="${{ github.event.head_commit.message }}"
319319
320320
# Sanitize - keep only BrowserStack-allowed chars: A-Z a-z 0-9 . : - [ ] / @ & ' _
321321
PR_TITLE_CLEAN=$(echo "$PR_TITLE" | sed "s/[^A-Za-z0-9.:[\]\/@&' _-]//g")
@@ -517,9 +517,9 @@ jobs:
517517
echo "Loaded devices: $DEVICES"
518518
519519
# Build BrowserStack project/build names with PR context
520-
PR_NUMBER="${ github.event.pull_request.number }"
521-
PR_TITLE="${ github.event.pull_request.title }"
522-
COMMIT_MSG="${ github.event.head_commit.message }"
520+
PR_NUMBER="${{ github.event.pull_request.number }}"
521+
PR_TITLE="${{ github.event.pull_request.title }}"
522+
COMMIT_MSG="${{ github.event.head_commit.message }}"
523523
524524
# Sanitize - keep only BrowserStack-allowed chars: A-Z a-z 0-9 . : - [ ] / @ & ' _
525525
PR_TITLE_CLEAN=$(echo "$PR_TITLE" | sed "s/[^A-Za-z0-9.:[\]\/@&' _-]//g")

0 commit comments

Comments
 (0)