Fix for issue with loading step impls from relative dirs (#430)

* Updating check for relative paths

Signed-off-by: Kunal Vishwasrao <[email protected]>

* Added unit test scenario with '..' in between path

Signed-off-by: Kunal Vishwasrao <[email protected]>

* Added proper comment to the relative file path check

Signed-off-by: Kunal Vishwasrao <[email protected]>

* Bump version

Signed-off-by: Chad Wilson <[email protected]>

---------

Signed-off-by: Kunal Vishwasrao <[email protected]>
Signed-off-by: Chad Wilson <[email protected]>
Co-authored-by: Chad Wilson <[email protected]>

Author: kunalvishwasrao

getgauge/impl_loader.py

@@ -98,7 +98,8 @@ def _import_file(base_dir, file_path):
 # Inject instance in each class method (hook/step)
 def update_step_registry_with_class(instance, file_path):
     # Resolve the absolute path from relative path
-    file_path = os.path.abspath(file_path) if str(file_path).startswith("..") else file_path
+    # Note: relative path syntax ".." can appear in between the file_path too like "<Project_Root>/../../Other_Project/src/step_impl/file.py"
+    file_path = os.path.abspath(file_path) if ".." in str(file_path) else file_path
     method_list = registry.get_all_methods_in(file_path)
     for info in method_list:
         class_methods = [x[0] for x in inspect.getmembers(instance, inspect.ismethod)]

python.json

@@ -1,6 +1,6 @@
 {
   "id": "python",
-  "version": "0.4.8",
+  "version": "0.4.9",
   "description": "Python support for gauge",
   "run": {
     "windows": [

tests/test_impl_loader.py

@@ -7,13 +7,21 @@
 
 class ImplLoaderTest(unittest.TestCase):
     def setUp(self):
+        self.curr_dir = os.getcwd()
         self.relative_file_path = os.path.join('..', 'test_relative_import', 'relative_import_class.py')
+        self.relative_file_path_one_level_above = os.path.join('tests', '..', 'test_relative_import', 'relative_import_class.py')
 
     def test_update_step_registry_with_class(self):
-        curr_dir = os.getcwd()
         os.chdir('tests')
         method_list = update_step_registry_with_class(Sample(), self.relative_file_path)
-        os.chdir(curr_dir)
+        os.chdir(self.curr_dir)
+        self.assertEqual(["Greet <name> from inside the class", 
+                          "Greet <name> from outside the class"], 
+                          [method.step_text for method in method_list])
+
+    def test_update_step_registry_with_class_one_level_above(self):
+        os.chdir(self.curr_dir)
+        method_list = update_step_registry_with_class(Sample(), self.relative_file_path_one_level_above)
         self.assertEqual(["Greet <name> from inside the class", 
                           "Greet <name> from outside the class"], 
                           [method.step_text for method in method_list])