Skip to content

Commit 5df5ca8

Browse files
add NULLS LAST option for Query order (#7341)
1 parent 8387fe6 commit 5df5ca8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

redash/utils/query_order.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
from sqlalchemy.orm.properties import ColumnProperty
3434
from sqlalchemy.orm.query import _ColumnEntity
3535
from sqlalchemy.orm.util import AliasedInsp
36-
from sqlalchemy.sql.expression import asc, desc
36+
from sqlalchemy.sql.expression import asc, desc, nullslast
3737

3838

3939
def get_query_descriptor(query, entity, attr):
@@ -225,7 +225,7 @@ def __init__(self, silent=True, separator="-"):
225225
def assign_order_by(self, entity, attr, func):
226226
expr = get_query_descriptor(self.query, entity, attr)
227227
if expr is not None:
228-
return self.query.order_by(func(expr))
228+
return self.query.order_by(nullslast(func(expr)))
229229
if not self.silent:
230230
raise QuerySorterException("Could not sort query with expression '%s'" % attr)
231231
return self.query

0 commit comments

Comments
 (0)