Skip to content

Commit c6f323b

Browse files
committed
Disable uploading by default
1 parent 31c2a3c commit c6f323b

File tree

3 files changed

+22
-21
lines changed

3 files changed

+22
-21
lines changed

plugin-build/build.gradle.kts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
21
import io.sentry.android.gradle.internal.ASMifyTask
32
import io.sentry.android.gradle.internal.BootstrapAndroidSdk
43
import java.io.FileInputStream

plugin-build/src/main/kotlin/io/sentry/android/gradle/AndroidComponentsConfig.kt

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -218,18 +218,16 @@ fun AndroidComponentsExtension<*, *, *>.configure(
218218
)
219219
.toTransform(SingleArtifact.MERGED_MANIFEST)
220220
}
221-
}
222-
if (extension.sizeAnalysis.enabled.get() == true) {
223-
val sentryTelemetryProvider =
224-
variant.configureTelemetry(project, extension, cliExecutable, sentryOrg, buildEvents)
225-
variant.configureUploadAppTasks(
226-
project,
227-
extension,
228-
sentryTelemetryProvider,
229-
cliExecutable,
230-
sentryOrg,
231-
sentryProject,
232-
)
221+
if (extension.sizeAnalysis.enabled.get() == true) {
222+
variant.configureUploadAppTasks(
223+
project,
224+
extension,
225+
sentryTelemetryProvider,
226+
cliExecutable,
227+
sentryOrg,
228+
sentryProject,
229+
)
230+
}
233231
}
234232
}
235233
}
@@ -365,11 +363,11 @@ private fun Variant.configureProguardMappingsTasks(
365363
releaseInfo = releaseInfo,
366364
)
367365

368-
generateUuidTask.hookWithMinifyTasks(
369-
project,
370-
name,
371-
dexguardEnabled && GroovyCompat.isDexguardEnabledForVariant(project, name),
372-
)
366+
generateUuidTask.hookWithMinifyTasks(
367+
project,
368+
name,
369+
dexguardEnabled && GroovyCompat.isDexguardEnabledForVariant(project, name),
370+
)
373371

374372
uploadMappingsTask.hookWithAssembleTasks(project, variant)
375373

@@ -380,7 +378,8 @@ private fun Variant.configureProguardMappingsTasks(
380378
}
381379

382380
/**
383-
* Configure the upload AAB and APK tasks and set them up as finalizers on the respective producer tasks
381+
* Configure the upload AAB and APK tasks and set them up as finalizers on the respective producer
382+
* tasks
384383
*/
385384
fun Variant.configureUploadAppTasks(
386385
project: Project,
@@ -408,7 +407,8 @@ fun Variant.configureUploadAppTasks(
408407
sentryProperties = sentryProps,
409408
taskSuffix = name.capitalized,
410409
)
411-
// TODO we can use the listToArtifacts API in AGP 8.3+ https://github.com/android/gradle-recipes/tree/agp-8.10/listenToArtifacts
410+
// TODO we can use the listToArtifacts API in AGP 8.3+
411+
// https://github.com/android/gradle-recipes/tree/agp-8.10/listenToArtifacts
412412
project.afterEvaluate {
413413
getBundleTask(project, variant.name)!!.configure { it.finalizedBy(uploadBundleTask) }
414414
getAssembleTaskProvider(project, variant)!!.configure { it.finalizedBy(uploadApkTask) }

plugin-build/src/main/kotlin/io/sentry/android/gradle/extensions/SizeAnalysisExtension.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,7 @@ open class SizeAnalysisExtension
1111
constructor(objects: ObjectFactory, providerFactory: ProviderFactory) {
1212

1313
val enabled: Property<Boolean> =
14-
objects.property(Boolean::class.java).convention(providerFactory.isCi())
14+
objects
15+
.property(Boolean::class.java)
16+
.convention(providerFactory.isCi() && false) // set to false for now otherwise upload fails CI
1517
}

0 commit comments

Comments
 (0)