Skip to content

Commit 4aa5d9b

Browse files
committed
Clean up
1 parent 8ef3b00 commit 4aa5d9b

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

CHANGELOG.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,9 @@
3030
### Improvements
3131

3232
- Replace deprecated SCNetworkReachability with NWPathMonitor (#6019)
33+
### Fixes
34+
35+
- Fix interop with managed Mono/CoreCLR runtimes (#6193)
3336

3437
## 8.57.0
3538

@@ -83,8 +86,6 @@
8386
- Fix potential app launch hang caused by the SentrySDK (#6181)
8487
Fixed by removing the call to `_dyld_get_image_header` on the main thread.
8588
- Fix dynamic selector crash in SentryReplayRecording (#6211)
86-
- Fix potential app launch hang caused by the SentrySDK (#6181) Fixed by removing the call to `_dyld_get_image_header` on the main thread.
87-
- Fix interop with managed Mono/CoreCLR runtimes (#6193)
8889

8990
## 8.56.0
9091

Sources/Sentry/include/SentryCrashMonitor.h

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,7 @@ bool sentrycrashcm_notifyFatalExceptionCaptured(bool isAsyncSafeEnvironment);
9393
*/
9494
void sentrycrashcm_handleException(struct SentryCrash_MonitorContext *context);
9595

96-
/** Whether to chain Unix signal handlers for managed Mono/CoreCLR runtimes, and
97-
* whether to register null Mach exception ports for EXC_MASK_BAD_ACCESS and
98-
* EXC_MASK_ARITHMETIC.
96+
/** Whether to chain Unix signal handlers for managed Mono/CoreCLR runtimes.
9997
*/
10098
bool sentrycrashcm_isManagedRuntime(void);
10199
void sentrycrashcm_setManagedRuntime(bool isManagedRuntime);

Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_Signal.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
#include "SentryCrashID.h"
3131
#include "SentryCrashMachineContext.h"
3232
#include "SentryCrashMonitorContext.h"
33-
#include "SentryCrashMonitor_MachException.h"
3433
#include "SentryCrashSignalInfo.h"
3534
#include "SentryCrashStackCursor_MachineContext.h"
3635
#include "SentryInternalCDefines.h"
@@ -69,8 +68,8 @@ static char g_eventID[37];
6968
# pragma mark - Callbacks -
7069
// ============================================================================
7170

72-
/**
73-
*
71+
/** Invoke previously installed signal handlers, adapted from Sentry Native:
72+
* https://github.com/getsentry/sentry-native/blob/9895a5c3ffab4e59e0c8020484cdd5dbc648666d/src/backends/sentry_backend_inproc.c#L59-L76
7473
*/
7574
static void
7675
invokePreviousSignalHandlers(int sigNum, siginfo_t *signalInfo, void *userContext)

0 commit comments

Comments
 (0)