Skip to content

Commit e0e67a4

Browse files
authored
Add missing prefix to source file upload (#306)
1 parent 9a52cb6 commit e0e67a4

File tree

3 files changed

+28
-6
lines changed

3 files changed

+28
-6
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# Changelog
22

3+
## Unreleased
4+
5+
### Fixes
6+
7+
- Add missing prefix to source file upload ([#306](https://github.com/getsentry/sentry-dart-plugin/pull/306))
8+
39
## 2.4.0
410

511
### Enhancements

lib/sentry_dart_plugin.dart

Lines changed: 21 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -214,8 +214,13 @@ class SentryDartPlugin {
214214
List<String> releaseJsFilesParams = [];
215215
releaseJsFilesParams.addAll(params);
216216

217-
_addExtensionToParams(['map', 'js'], releaseJsFilesParams, release,
218-
_configuration.webBuildFilesFolder);
217+
_addExtensionToParams(
218+
['map', 'js'],
219+
releaseJsFilesParams,
220+
release,
221+
_configuration.webBuildFilesFolder,
222+
null,
223+
);
219224

220225
_addWait(releaseJsFilesParams);
221226
_addUrlPrefix(releaseJsFilesParams);
@@ -227,7 +232,13 @@ class SentryDartPlugin {
227232
List<String> releaseDartFilesParams = [];
228233
releaseDartFilesParams.addAll(params);
229234

230-
_addExtensionToParams(['dart'], releaseDartFilesParams, release, 'lib');
235+
_addExtensionToParams(
236+
['dart'],
237+
releaseDartFilesParams,
238+
release,
239+
'lib',
240+
'~/lib/',
241+
);
231242

232243
_addWait(releaseDartFilesParams);
233244

@@ -292,8 +303,8 @@ class SentryDartPlugin {
292303
}
293304
}
294305

295-
void _addExtensionToParams(
296-
List<String> exts, List<String> params, String release, String folder) {
306+
void _addExtensionToParams(List<String> exts, List<String> params,
307+
String release, String folder, String? urlPrefix) {
297308
params.add('files');
298309
params.add(release);
299310
params.add('upload-sourcemaps');
@@ -314,6 +325,11 @@ class SentryDartPlugin {
314325
final values = release.split('+');
315326
params.add(values.last);
316327
}
328+
329+
if (urlPrefix != null) {
330+
params.add("--url-prefix");
331+
params.add(urlPrefix);
332+
}
317333
}
318334

319335
String get _release {

test/plugin_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ void main() {
8585
'$cli $args debug-files upload $orgAndProject --include-sources $buildDir/app/outputs',
8686
'$cli $args releases $orgAndProject new $release',
8787
'$cli $args releases $orgAndProject files $release upload-sourcemaps $buildDir/web --ext map --ext js',
88-
'$cli $args releases $orgAndProject files $release upload-sourcemaps lib --ext dart',
88+
'$cli $args releases $orgAndProject files $release upload-sourcemaps lib --ext dart --url-prefix ~/lib/',
8989
'$cli $args releases $orgAndProject set-commits $release --auto --ignore-missing',
9090
'$cli $args releases $orgAndProject finalize $release'
9191
]);

0 commit comments

Comments
 (0)