-
-
Notifications
You must be signed in to change notification settings - Fork 52
build(deps): bump getsentry/github-workflows/.github/workflows/updater.yml from 2 to 3 #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…r.yml Bumps [getsentry/github-workflows/.github/workflows/updater.yml](https://github.com/getsentry/github-workflows) from 2 to 3. - [Release notes](https://github.com/getsentry/github-workflows/releases) - [Changelog](https://github.com/getsentry/github-workflows/blob/main/CHANGELOG.md) - [Commits](getsentry/github-workflows@v2...v3) --- updated-dependencies: - dependency-name: getsentry/github-workflows/.github/workflows/updater.yml dependency-version: '3' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
|
Changes made are based on this README: https://github.com/getsentry/github-workflows/blob/main/updater/README.md |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: getsentry/github-workflows/updater@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The update-cli job lacks job-level output mappings for its composite action, causing downstream jobs to fail when accessing needs.update-cli.outputs.
Severity: CRITICAL | Confidence: High
🔍 Detailed Analysis
The update-cli job, which utilizes a composite action, is missing required job-level output declarations. The composite action step lacks an id attribute, and the job itself does not define an outputs section to map the step's outputs. As a result, the downstream update-binaries job attempts to access needs.update-cli.outputs.originalTag and needs.update-cli.outputs.latestTag, but needs.update-cli.outputs is empty. This causes the if condition in update-binaries to fail, leading to an unexpected workflow failure and preventing the proper execution of the dependency chain.
💡 Suggested Fix
Add an id to the composite action step within the update-cli job. Then, define an outputs section in the update-cli job, mapping the step's outputs, for example: outputs: { originalTag: ${{ steps.<step-id>.outputs.originalTag }} }.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: .github/workflows/update-deps.yml#L20-L22
Potential issue: The `update-cli` job, which utilizes a composite action, is missing
required job-level output declarations. The composite action step lacks an `id`
attribute, and the job itself does not define an `outputs` section to map the step's
outputs. As a result, the downstream `update-binaries` job attempts to access
`needs.update-cli.outputs.originalTag` and `needs.update-cli.outputs.latestTag`, but
`needs.update-cli.outputs` is empty. This causes the `if` condition in `update-binaries`
to fail, leading to an unexpected workflow failure and preventing the proper execution
of the dependency chain.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 3156568
|
Closing this as won't fix as it seems that this will checkout a massive amount of dependencies every time the workflow runs: https://github.com/getsentry/sentry-fastlane-plugin/actions/runs/19634136249/job/56220657713 |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps getsentry/github-workflows/.github/workflows/updater.yml from 2 to 3.
Release notes
Sourced from getsentry/github-workflows/.github/workflows/updater.yml's releases.
... (truncated)
Changelog
Sourced from getsentry/github-workflows/.github/workflows/updater.yml's changelog.
... (truncated)
Commits
13be9berelease: 3.1.00d0d99afeat(updater): Add SSH key support and comprehensive authentication validatio...6272a50chore(deps): update Danger JS to v13.0.4 (#132)71d223efix(updater): Pass OriginalTag to post-update script on second run (#133)0bd595fchore: Rename workflow to 'Update dependencies'1c10977chore: Use updater action to manage Danger JS version (#131)3182dd4feat(updater): Add post-update-script support (#130)15e4b10fix: Handle boolean inputs correctly and validate supported values (#127)c6471d1Merge branch 'release/3.0.0'342f5e2release: 3.0.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)