Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 10, 2025

Bumps getsentry/github-workflows/.github/workflows/updater.yml from 2 to 3.

Release notes

Sourced from getsentry/github-workflows/.github/workflows/updater.yml's releases.

3.0.0

Breaking Changes

  • Updater: The default value for pr-strategy has been changed from create to update. (#124) This change means the updater will now maintain a single PR that gets updated with new dependency versions (instead of creating separate PRs for each version). If you want to preserve the previous behavior of creating separate PRs, explicitly set pr-strategy: create in your workflow:

    - uses: getsentry/github-workflows/updater@v3
      with:
        # ... other inputs ...
        pr-strategy: create  # Add this to preserve previous behavior

    In case you have existing open PRs created with the create strategy, you will need to remove these old branches manually as the new name would be a prefix of the old PRs, which git doesnt' allow.

  • Updater and Danger reusable workflows are now composite actions (#114)

    To update your existing Updater workflows:

    ### Before
      native:
        uses: getsentry/github-workflows/.github/workflows/updater.yml@v2
        with:
          path: scripts/update-sentry-native-ndk.sh
          name: Native SDK
        secrets:
          # If a custom token is used instead, a CI would be triggered on a created PR.
          api-token: ${{ secrets.CI_DEPLOY_KEY }}
    After
    native:
    runs-on: ubuntu-latest
    steps:
    - uses: getsentry/github-workflows/updater@v3
    with:
    path: scripts/update-sentry-native-ndk.sh
    name: Native SDK
    api-token: ${{ secrets.CI_DEPLOY_KEY }}

    To update your existing Danger workflows:

    ### Before
      danger:
        uses: getsentry/github-workflows/.github/workflows/danger.yml@v2
    After
    danger:

... (truncated)

Changelog

Sourced from getsentry/github-workflows/.github/workflows/updater.yml's changelog.

Changelog

Unreleased

Features

  • Danger - Add support for repository-specific dangerfiles (#129)
    • Add extra-dangerfile input parameter to run custom Danger checks alongside shared workflow checks
    • Add extra-install-packages input to install additional apt packages required by custom dangerfiles
    • Custom dangerfiles receive full Danger API access (fail, warn, message, markdown, danger)
    • Enables repositories to extend Danger checks without overwriting shared workflow comments

3.1.0

Features

  • Updater - Add post-update-script input parameter to run custom scripts after dependency updates (#130, #133)
    • Scripts receive original and new version as arguments
    • Support both bash (.sh) and PowerShell (.ps1) scripts
    • Enables workflows like updating lock files, running code generators, or modifying configuration files
  • Updater - Add SSH key support and comprehensive authentication validation (#134)
    • Add ssh-key input parameter for deploy key authentication
    • Support using both ssh-key (for git) and api-token (for GitHub API) together
    • Add detailed token validation with actionable error messages
    • Detect common token issues: expiration, whitespace, SSH keys in wrong input, missing scopes
    • Validate SSH key format when provided

Fixes

  • Updater - Fix boolean input handling for changelog-entry parameter and add input validation (#127)
  • Updater - Fix cryptic authentication errors with better validation and error messages (#134, closes #128)

Dependencies

3.0.0

Breaking Changes

  • Updater: The default value for pr-strategy has been changed from create to update. (#124) This change means the updater will now maintain a single PR that gets updated with new dependency versions (instead of creating separate PRs for each version). If you want to preserve the previous behavior of creating separate PRs, explicitly set pr-strategy: create in your workflow:

    - uses: getsentry/github-workflows/updater@v3
      with:
        # ... other inputs ...

... (truncated)

Commits
  • 13be9be release: 3.1.0
  • 0d0d99a feat(updater): Add SSH key support and comprehensive authentication validatio...
  • 6272a50 chore(deps): update Danger JS to v13.0.4 (#132)
  • 71d223e fix(updater): Pass OriginalTag to post-update script on second run (#133)
  • 0bd595f chore: Rename workflow to 'Update dependencies'
  • 1c10977 chore: Use updater action to manage Danger JS version (#131)
  • 3182dd4 feat(updater): Add post-update-script support (#130)
  • 15e4b10 fix: Handle boolean inputs correctly and validate supported values (#127)
  • c6471d1 Merge branch 'release/3.0.0'
  • 342f5e2 release: 3.0.0
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

…r.yml

Bumps [getsentry/github-workflows/.github/workflows/updater.yml](https://github.com/getsentry/github-workflows) from 2 to 3.
- [Release notes](https://github.com/getsentry/github-workflows/releases)
- [Changelog](https://github.com/getsentry/github-workflows/blob/main/CHANGELOG.md)
- [Commits](getsentry/github-workflows@v2...v3)

---
updated-dependencies:
- dependency-name: getsentry/github-workflows/.github/workflows/updater.yml
  dependency-version: '3'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Nov 10, 2025
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Nov 10, 2025
@philprime philprime enabled auto-merge (squash) November 24, 2025 12:10
@philprime philprime disabled auto-merge November 24, 2025 12:14
@philprime
Copy link
Member

philprime commented Nov 24, 2025

Changes made are based on this README: https://github.com/getsentry/github-workflows/blob/main/updater/README.md

Comment on lines +20 to +22
runs-on: ubuntu-latest
steps:
- uses: getsentry/github-workflows/updater@v3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The update-cli job lacks job-level output mappings for its composite action, causing downstream jobs to fail when accessing needs.update-cli.outputs.
Severity: CRITICAL | Confidence: High

🔍 Detailed Analysis

The update-cli job, which utilizes a composite action, is missing required job-level output declarations. The composite action step lacks an id attribute, and the job itself does not define an outputs section to map the step's outputs. As a result, the downstream update-binaries job attempts to access needs.update-cli.outputs.originalTag and needs.update-cli.outputs.latestTag, but needs.update-cli.outputs is empty. This causes the if condition in update-binaries to fail, leading to an unexpected workflow failure and preventing the proper execution of the dependency chain.

💡 Suggested Fix

Add an id to the composite action step within the update-cli job. Then, define an outputs section in the update-cli job, mapping the step's outputs, for example: outputs: { originalTag: ${{ steps.<step-id>.outputs.originalTag }} }.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: .github/workflows/update-deps.yml#L20-L22

Potential issue: The `update-cli` job, which utilizes a composite action, is missing
required job-level output declarations. The composite action step lacks an `id`
attribute, and the job itself does not define an `outputs` section to map the step's
outputs. As a result, the downstream `update-binaries` job attempts to access
`needs.update-cli.outputs.originalTag` and `needs.update-cli.outputs.latestTag`, but
`needs.update-cli.outputs` is empty. This causes the `if` condition in `update-binaries`
to fail, leading to an unexpected workflow failure and preventing the proper execution
of the dependency chain.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 3156568

@philprime
Copy link
Member

Closing this as won't fix as it seems that this will checkout a massive amount of dependencies every time the workflow runs:

https://github.com/getsentry/sentry-fastlane-plugin/actions/runs/19634136249/job/56220657713

@philprime philprime closed this Nov 24, 2025
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 24, 2025

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/github_actions/getsentry/github-workflows/dot-github/workflows/updater.yml-3 branch November 24, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants