fix(nextjs): Return correct lastEventId for SSR pages

Author: s1gr1d

packages/nextjs/src/common/pages-router-instrumentation/_error.ts

@@ -1,4 +1,4 @@
-import { captureException, httpRequestToRequestData, withScope } from '@sentry/core';
+import { captureException, getIsolationScope, httpRequestToRequestData, withScope } from '@sentry/core';
 import type { NextPageContext } from 'next';
 import { flushSafelyWithTimeout, waitUntil } from '../utils/responseEnd';
 
@@ -57,6 +57,9 @@ export async function captureUnderscoreErrorException(contextOrProps: ContextOrP
     });
   });
 
+  // Set the lastEventId on the isolation scope so it's accessible via lastEventId()
+  getIsolationScope().setLastEventId(eventId);
+
   waitUntil(flushSafelyWithTimeout());
 
   return eventId;

packages/nextjs/test/common/pages-router-instrumentation/captureUnderscoreErrorException.test.ts

@@ -1,13 +1,23 @@
+import { lastEventId } from '@sentry/core';
 import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
 import { captureUnderscoreErrorException } from '../../../src/common/pages-router-instrumentation/_error';
 
+let storedLastEventId: string | undefined = undefined;
+
 const mockCaptureException = vi.fn(() => 'test-event-id');
 const mockWithScope = vi.fn((callback: (scope: any) => any) => {
   const mockScope = {
     setSDKProcessingMetadata: vi.fn(),
   };
   return callback(mockScope);
 });
+const mockLastEventId = vi.fn(() => storedLastEventId);
+const mockGetIsolationScope = vi.fn(() => ({
+  setLastEventId: (id: string | undefined) => {
+    storedLastEventId = id;
+  },
+  lastEventId: () => storedLastEventId,
+}));
 
 vi.mock('@sentry/core', async () => {
   const actual = await vi.importActual('@sentry/core');
@@ -16,6 +26,8 @@ vi.mock('@sentry/core', async () => {
     captureException: (...args: unknown[]) => mockCaptureException(...args),
     withScope: (callback: (scope: any) => any) => mockWithScope(callback),
     httpRequestToRequestData: vi.fn(() => ({ url: 'http://test.com' })),
+    lastEventId: () => mockLastEventId(),
+    getIsolationScope: () => mockGetIsolationScope(),
   };
 });
 
@@ -27,6 +39,7 @@ vi.mock('../../../src/common/utils/responseEnd', () => ({
 describe('captureUnderscoreErrorException', () => {
   beforeEach(() => {
     vi.clearAllMocks();
+    storedLastEventId = undefined;
   });
 
   afterEach(() => {
@@ -114,4 +127,19 @@ describe('captureUnderscoreErrorException', () => {
     expect(result).toBeUndefined();
     expect(mockCaptureException).not.toHaveBeenCalled();
   });
+
+  it('lastEventId() should return the event ID after captureUnderscoreErrorException', async () => {
+    const error = new Error('Test error');
+    const eventId = await captureUnderscoreErrorException({
+      err: error,
+      pathname: '/test',
+      res: { statusCode: 500 } as any,
+    });
+
+    expect(eventId).toBe('test-event-id');
+    expect(mockCaptureException).toHaveBeenCalled();
+
+    const lastId = lastEventId();
+    expect(lastId).toBe('test-event-id');
+  });
 });