Skip to content

Commit 01bf898

Browse files
authored
fix(ourlogs): Fix groupby in toolbar not updating (#95917)
### Summary Passing 'undefined' to the compact select after it's initialized appears to not update the option properly, leaving stale UI.
1 parent e0c0319 commit 01bf898

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

static/app/views/explore/logs/content.spec.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ describe('LogsPage', function () {
145145
eventStatsMock.mockClear();
146146

147147
await userEvent.click(screen.getByRole('button', {name: 'Expand sidebar'}));
148-
await userEvent.click(screen.getByRole('button', {name: 'None'}));
148+
await userEvent.click(screen.getByRole('button', {name: '\u2014'}));
149149
await userEvent.click(screen.getByRole('option', {name: 'severity'}));
150150
await userEvent.click(screen.getByRole('tab', {name: 'Aggregates'}));
151151

static/app/views/explore/logs/logsToolbar.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ export function LogsToolbar({stringTags, numberTags}: LogsToolbarProps) {
144144
onChange={val =>
145145
setLogsPageParams({groupBy: val.value ? (val.value as string) : null})
146146
}
147-
value={groupBy}
147+
value={groupBy ?? ''}
148148
searchable
149149
triggerProps={{style: {width: '100%'}}}
150150
/>

0 commit comments

Comments
 (0)