Skip to content

Commit 2d5f81a

Browse files
authored
fix(eap): Do not autocomplete timestamp (#95886)
Timestamps aren't realy useful to autocomplete by querying eap. So skip it.
1 parent 4faab42 commit 2d5f81a

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

src/sentry/api/endpoints/organization_trace_item_attributes.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -379,6 +379,7 @@ def __init__(
379379
SEMVER_ALIAS: self.semver_autocomplete_function,
380380
SEMVER_BUILD_ALIAS: self.semver_build_autocomplete_function,
381381
SEMVER_PACKAGE_ALIAS: self.semver_package_autocomplete_function,
382+
"timestamp": self.skip_autocomplete,
382383
}
383384
)
384385

@@ -542,6 +543,9 @@ def semver_package_autocomplete_function(self):
542543
for package in packages
543544
]
544545

546+
def skip_autocomplete(self) -> list[TagValue]:
547+
return []
548+
545549
def boolean_autocomplete_function(self) -> list[TagValue]:
546550
return [
547551
TagValue(

tests/snuba/api/endpoints/test_organization_trace_item_attributes.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1500,3 +1500,12 @@ def test_autocomplete_release_semver_attributes(self):
15001500
}
15011501
for version in ["121", "122"]
15021502
]
1503+
1504+
def test_autocomplete_timestamp(self):
1505+
self.store_spans(
1506+
[self.create_span(start_ts=before_now(days=0, minutes=10))],
1507+
is_eap=True,
1508+
)
1509+
response = self.do_request(key="timestamp", query={"substringMatch": "20"})
1510+
assert response.status_code == 200
1511+
assert response.data == []

0 commit comments

Comments
 (0)