Skip to content

Commit 5e26532

Browse files
Litarnusandrewshie-sentry
authored andcommitted
ref: remove LPQ frontend code (#94952)
Symbolicator LPQ was removed some time ago. This PR removes remaining Frontend elements that were previously used to show users that their symbolication task was moved into the LPQ.
1 parent 6fd541f commit 5e26532

File tree

6 files changed

+0
-297
lines changed

6 files changed

+0
-297
lines changed

static/app/components/globalEventProcessingAlert.tsx

Lines changed: 0 additions & 52 deletions
This file was deleted.

static/app/views/issueList/header.tsx

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,15 @@ import {Button} from 'sentry/components/core/button';
88
import {ButtonBar} from 'sentry/components/core/button/buttonBar';
99
import {TabList, Tabs} from 'sentry/components/core/tabs';
1010
import {Tooltip} from 'sentry/components/core/tooltip';
11-
import GlobalEventProcessingAlert from 'sentry/components/globalEventProcessingAlert';
1211
import * as Layout from 'sentry/components/layouts/thirds';
1312
import {PageHeadingQuestionTooltip} from 'sentry/components/pageHeadingQuestionTooltip';
1413
import QueryCount from 'sentry/components/queryCount';
1514
import {SLOW_TOOLTIP_DELAY} from 'sentry/constants';
1615
import {IconPause, IconPlay} from 'sentry/icons';
1716
import {t} from 'sentry/locale';
18-
import {space} from 'sentry/styles/space';
1917
import type {InjectedRouter} from 'sentry/types/legacyReactRouter';
2018
import type {Organization} from 'sentry/types/organization';
2119
import normalizeUrl from 'sentry/utils/url/normalizeUrl';
22-
import useProjects from 'sentry/utils/useProjects';
2320
import IssueListSetAsDefault from 'sentry/views/issueList/issueListSetAsDefault';
2421

2522
import type {QueryCounts} from './utils';
@@ -86,9 +83,7 @@ function IssueListHeader({
8683
onRealtimeChange,
8784
router,
8885
displayReprocessingTab,
89-
selectedProjectIds,
9086
}: IssueListHeaderProps) {
91-
const {projects} = useProjects();
9287
const tabs = getTabs();
9388
const visibleTabs = displayReprocessingTab
9489
? tabs
@@ -99,9 +94,6 @@ function IssueListHeader({
9994
const sortParam =
10095
queryParms.sort === IssueSortOptions.INBOX ? undefined : queryParms.sort;
10196

102-
const selectedProjects = projects.filter(({id}) =>
103-
selectedProjectIds.includes(Number(id))
104-
);
10597
const realtimeTitle = realtimeActive
10698
? t('Pause real-time updates')
10799
: t('Enable real-time updates');
@@ -134,7 +126,6 @@ function IssueListHeader({
134126
</DisableInDemoMode>
135127
</ButtonBar>
136128
</Layout.HeaderActions>
137-
<StyledGlobalEventProcessingAlert projects={selectedProjects} />
138129
<StyledTabs value={tabValues.has(query) ? query : CUSTOM_TAB_VALUE}>
139130
<TabList hideBorder>
140131
{visibleTabs.map(
@@ -184,17 +175,6 @@ function IssueListHeader({
184175

185176
export default IssueListHeader;
186177

187-
const StyledGlobalEventProcessingAlert = styled(GlobalEventProcessingAlert)`
188-
grid-column: 1/-1;
189-
margin-top: ${space(1)};
190-
margin-bottom: ${space(1)};
191-
192-
@media (min-width: ${p => p.theme.breakpoints.md}) {
193-
margin-top: ${space(2)};
194-
margin-bottom: 0;
195-
}
196-
`;
197-
198178
const StyledTabs = styled(Tabs)`
199179
grid-column: 1/-1;
200180
`;

static/app/views/issueList/issueViewsHeader.tsx

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import styled from '@emotion/styled';
44
import DisableInDemoMode from 'sentry/components/acl/demoModeDisabled';
55
import {Button} from 'sentry/components/core/button';
66
import {DropdownMenu} from 'sentry/components/dropdownMenu';
7-
import GlobalEventProcessingAlert from 'sentry/components/globalEventProcessingAlert';
87
import * as Layout from 'sentry/components/layouts/thirds';
98
import QuestionTooltip from 'sentry/components/questionTooltip';
109
import {IconEllipsis, IconPause, IconPlay, IconStar} from 'sentry/icons';
@@ -16,7 +15,6 @@ import normalizeUrl from 'sentry/utils/url/normalizeUrl';
1615
import {useNavigate} from 'sentry/utils/useNavigate';
1716
import useOrganization from 'sentry/utils/useOrganization';
1817
import {useParams} from 'sentry/utils/useParams';
19-
import useProjects from 'sentry/utils/useProjects';
2018
import {useUser} from 'sentry/utils/useUser';
2119
import {EditableIssueViewHeader} from 'sentry/views/issueList/editableIssueViewHeader';
2220
import {useSelectedGroupSearchView} from 'sentry/views/issueList/issueViews/useSelectedGroupSeachView';
@@ -215,18 +213,13 @@ function IssueViewEditMenu() {
215213
}
216214

217215
function IssueViewsHeader({
218-
selectedProjectIds,
219216
title,
220217
description,
221218
realtimeActive,
222219
onRealtimeChange,
223220
headerActions,
224221
}: IssueViewsHeaderProps) {
225-
const {projects} = useProjects();
226222
const prefersStackedNav = usePrefersStackedNav();
227-
const selectedProjects = projects.filter(({id}) =>
228-
selectedProjectIds.includes(Number(id))
229-
);
230223
const {viewId} = useParams<{viewId?: string}>();
231224

232225
const realtimeLabel = realtimeActive
@@ -257,24 +250,12 @@ function IssueViewsHeader({
257250
</StyledLayoutTitle>
258251
</Layout.HeaderContent>
259252
<Layout.HeaderActions />
260-
<StyledGlobalEventProcessingAlert projects={selectedProjects} />
261253
</Layout.Header>
262254
);
263255
}
264256

265257
export default IssueViewsHeader;
266258

267-
const StyledGlobalEventProcessingAlert = styled(GlobalEventProcessingAlert)`
268-
grid-column: 1/-1;
269-
margin-top: ${space(1)};
270-
margin-bottom: ${space(1)};
271-
272-
@media (min-width: ${p => p.theme.breakpoints.md}) {
273-
margin-top: ${space(2)};
274-
margin-bottom: 0;
275-
}
276-
`;
277-
278259
const StyledLayoutTitle = styled('div')`
279260
display: flex;
280261
justify-content: space-between;

static/app/views/issueList/overview.spec.tsx

Lines changed: 0 additions & 70 deletions
Original file line numberDiff line numberDiff line change
@@ -1394,76 +1394,6 @@ describe('IssueList', function () {
13941394
expect(screen.queryByText(/event processing/i)).not.toBeInTheDocument();
13951395
});
13961396
});
1397-
1398-
describe('renders alert', function () {
1399-
it('for one project', async function () {
1400-
act(() =>
1401-
ProjectsStore.loadInitialData([
1402-
{...project, eventProcessing: {symbolicationDegraded: true}},
1403-
])
1404-
);
1405-
1406-
render(<IssueListOverview {...routerProps} />, {
1407-
organization,
1408-
1409-
initialRouterConfig,
1410-
});
1411-
1412-
await waitFor(() => {
1413-
expect(
1414-
screen.getByText(/Event Processing for this project is currently degraded/i)
1415-
).toBeInTheDocument();
1416-
});
1417-
});
1418-
1419-
it('for multiple projects', async function () {
1420-
const projectBar = ProjectFixture({
1421-
id: '3560',
1422-
name: 'Bar Project',
1423-
slug: 'project-slug-bar',
1424-
});
1425-
1426-
act(() =>
1427-
ProjectsStore.loadInitialData([
1428-
{
1429-
...project,
1430-
slug: 'project-slug',
1431-
eventProcessing: {symbolicationDegraded: true},
1432-
},
1433-
{
1434-
...projectBar,
1435-
slug: 'project-slug-bar',
1436-
eventProcessing: {symbolicationDegraded: true},
1437-
},
1438-
])
1439-
);
1440-
1441-
PageFiltersStore.onInitializeUrlState(
1442-
{
1443-
projects: [Number(project.id), Number(projectBar.id)],
1444-
environments: [],
1445-
datetime: {period: '14d', start: null, end: null, utc: null},
1446-
},
1447-
new Set()
1448-
);
1449-
1450-
render(<IssueListOverview {...routerProps} />, {
1451-
organization,
1452-
1453-
initialRouterConfig,
1454-
});
1455-
1456-
await waitFor(() => {
1457-
expect(
1458-
screen.getByText(
1459-
textWithMarkupMatcher(
1460-
'Event Processing for the project-slug, project-slug-bar projects is currently degraded.'
1461-
)
1462-
)
1463-
).toBeInTheDocument();
1464-
});
1465-
});
1466-
});
14671397
});
14681398

14691399
describe('new view page', function () {

static/app/views/projectDetail/index.spec.tsx

Lines changed: 0 additions & 126 deletions
This file was deleted.

0 commit comments

Comments
 (0)