Skip to content

Commit 6210cba

Browse files
authored
feat(replay): Make deleted replay rows have same spacing as normal rows (#96008)
Before there was a little too much vertical space between the text "Archived Replay" and the ID below. Also the project icon was not aligned with the rows above/below. **Before** <img width="487" height="217" alt="SCR-20250721-jxwn" src="https://github.com/user-attachments/assets/ab78ea49-b110-4873-bf41-74566bc94045" /> **After** <img width="500" height="217" alt="SCR-20250721-jwyt" src="https://github.com/user-attachments/assets/d685b75b-62f1-4bc2-98d6-c38e0bc21c51" />
1 parent 44ba15c commit 6210cba

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

static/app/components/replays/table/replayTableColumns.tsx

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -503,14 +503,12 @@ export const ReplaySessionColumn: ReplayTableColumn = {
503503
if (replay.is_archived) {
504504
return (
505505
<Flex gap={space(1)} align="center" justify="center">
506-
<div style={{paddingInline: space(0.5)}}>
506+
<ArchivedWrapper>
507507
<IconDelete color="gray500" size="md" />
508-
</div>
508+
</ArchivedWrapper>
509509

510-
<Flex direction="column" gap={space(0.5)}>
511-
<Flex gap={space(0.5)} align="center">
512-
{t('Deleted Replay')}
513-
</Flex>
510+
<Flex direction="column" gap={space(0.25)}>
511+
<DisplayName>{t('Deleted Replay')}</DisplayName>
514512
<Flex gap={space(0.5)} align="center">
515513
{project ? <ProjectAvatar size={12} project={project} /> : null}
516514
<SmallFont>{getShortEventId(replay.id)}</SmallFont>
@@ -615,6 +613,12 @@ export const ReplaySlowestTransactionColumn: ReplayTableColumn = {
615613
},
616614
};
617615

616+
const ArchivedWrapper = styled(Flex)`
617+
width: ${p => p.theme.space['2xl']};
618+
align-items: center;
619+
justify-content: center;
620+
`;
621+
618622
const DetailsLink = styled(Link)`
619623
z-index: 1;
620624
margin: -${p => p.theme.space.md};
@@ -672,7 +676,6 @@ const DisplayName = styled('span')`
672676
673677
&:hover {
674678
color: ${p => p.theme.textColor};
675-
text-decoration: underline;
676679
}
677680
`;
678681

0 commit comments

Comments
 (0)