Skip to content

Commit 660df21

Browse files
asottile-sentryandrewshie-sentry
authored andcommitted
ref: fix types for nodestore test_common in mypy 1.17 (#96084)
<!-- Describe your PR here. -->
1 parent f92fb28 commit 660df21

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

tests/sentry/nodestore/test_common.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,13 @@
33
`ns` fixture to have it tested.
44
"""
55

6+
from collections.abc import Callable, Generator
67
from contextlib import nullcontext
8+
from typing import ContextManager
79

810
import pytest
911

12+
from sentry.nodestore.base import NodeStorage
1013
from sentry.nodestore.django.backend import DjangoNodeStorage
1114
from sentry.testutils.helpers import override_options
1215
from tests.sentry.nodestore.bigtable.test_backend import (
@@ -18,9 +21,9 @@
1821
@pytest.fixture(
1922
params=["bigtable-mocked", "bigtable-real", pytest.param("django", marks=pytest.mark.django_db)]
2023
)
21-
def ns(request):
24+
def ns(request) -> Generator[NodeStorage]:
2225
# backends are returned from context managers to support teardown when required
23-
backends = {
26+
backends: dict[str, Callable[[], ContextManager[NodeStorage]]] = {
2427
"bigtable-mocked": lambda: nullcontext(MockedBigtableNodeStorage(project="test")),
2528
"bigtable-real": lambda: get_temporary_bigtable_nodestorage(),
2629
"django": lambda: nullcontext(DjangoNodeStorage()),

0 commit comments

Comments
 (0)