fix(pr): Comments

Author: leedongwei

static/app/views/detectors/list.spec.tsx

@@ -171,6 +171,31 @@ describe('DetectorsList', function () {
       expect(mockDetectorsRequestErrorType).toHaveBeenCalled();
     });
 
+    it('can filter by assignee', async function () {
+      const testUser = UserFixture({id: '2', email: '[email protected]'});
+      const mockDetectorsRequestAssignee = MockApiClient.addMockResponse({
+        url: '/organizations/org-slug/detectors/',
+        body: [MetricDetectorFixture({name: 'Assigned Detector', owner: testUser.id})],
+        match: [MockApiClient.matchQuery({query: 'assignee:[email protected]'})],
+      });
+
+      render(<DetectorsList />, {organization});
+      await screen.findByText('Detector 1');
+
+      // Click through menus to select assignee
+      const searchInput = await screen.findByRole('combobox', {
+        name: 'Add a search term',
+      });
+      await userEvent.type(searchInput, 'assignee:[email protected]');
+
+      // It takes two enters. One to enter the search term, and one to submit the search.
+      await userEvent.keyboard('{enter}');
+      await userEvent.keyboard('{enter}');
+
+      await screen.findByText('Assigned Detector');
+      expect(mockDetectorsRequestAssignee).toHaveBeenCalled();
+    });
+
     it('can sort the table', async function () {
       const mockDetectorsRequest = MockApiClient.addMockResponse({
         url: '/organizations/org-slug/detectors/',

static/app/views/detectors/utils/useDetectorFilterKeys.tsx

@@ -9,29 +9,17 @@ export function useDetectorFilterKeys(): TagCollection {
 
   return useMemo(() => {
     return Object.fromEntries(
-      Object.keys(DETECTOR_FILTER_KEYS).map(key => {
-        const {values} = DETECTOR_FILTER_KEYS[key] ?? {};
-
-        // Special handling for assignee field to provide user/team values
-        if (key === 'assignee') {
-          return [
-            key,
-            {
-              key,
-              name: key,
-              predefined: true,
-              values: assignedValues,
-            },
-          ];
-        }
+      Object.entries(DETECTOR_FILTER_KEYS).map(([key, config]) => {
+        const {values} = config ?? {};
+        const isAssignee = key === 'assignee';
 
         return [
           key,
           {
             key,
             name: key,
-            predefined: values !== undefined,
-            values,
+            predefined: isAssignee || values !== undefined,
+            values: isAssignee ? assignedValues : values,
           },
         ];
       })