feat(aci): Add alert rule id to detector (#95912)

Going from the detector to the alert rule is very helpful in the ui. "Go
to old ui" Ideally removed once we stop mirroring detectors to alert
rules.

Author: scttcper

src/sentry/workflow_engine/endpoints/serializers.py

@@ -22,6 +22,7 @@
 from sentry.utils.cursors import Cursor, CursorResult
 from sentry.workflow_engine.models import (
     Action,
+    AlertRuleDetector,
     DataCondition,
     DataConditionGroup,
     DataSource,
@@ -310,6 +311,17 @@ def get_attrs(
         for detector_id, workflow_id in detector_workflows:
             workflows_map[detector_id].append(str(workflow_id))
 
+        # Fetch alert rule mappings
+        # TODO: Remove alert rule mappings as they're deprecated
+        alert_rule_mappings = list(AlertRuleDetector.objects.filter(detector__in=item_list))
+        alert_rule_map = {
+            mapping.detector_id: {
+                "alert_rule_id": mapping.alert_rule_id,
+                "rule_id": mapping.rule_id,
+            }
+            for mapping in alert_rule_mappings
+        }
+
         filtered_item_list = [item for item in item_list if item.type == ErrorGroupType.slug]
         project_ids = [item.project_id for item in filtered_item_list]
 
@@ -331,6 +343,13 @@ def get_attrs(
                 str(item.workflow_condition_group_id)
             )
             attrs[item]["workflow_ids"] = workflows_map[item.id]
+            attrs[item]["alert_rule_mapping"] = alert_rule_map.get(
+                item.id,
+                {
+                    "alert_rule_id": None,
+                    "rule_id": None,
+                },
+            )
             if item.id in configs:
                 attrs[item]["config"] = configs[item.id]
             else:
@@ -342,6 +361,7 @@ def get_attrs(
         return attrs
 
     def serialize(self, obj: Detector, attrs: Mapping[str, Any], user, **kwargs) -> dict[str, Any]:
+        alert_rule_mapping = attrs.get("alert_rule_mapping", {})
         return {
             "id": str(obj.id),
             "projectId": str(obj.project_id),
@@ -356,6 +376,8 @@ def serialize(self, obj: Detector, attrs: Mapping[str, Any], user, **kwargs) ->
             "conditionGroup": attrs.get("condition_group"),
             "config": convert_dict_key_case(attrs.get("config"), snake_to_camel_case),
             "enabled": obj.enabled,
+            "alertRuleId": alert_rule_mapping.get("alert_rule_id"),
+            "ruleId": alert_rule_mapping.get("rule_id"),
         }
 
 

tests/sentry/workflow_engine/endpoints/test_organization_detector_details.py

@@ -21,6 +21,7 @@
 from sentry.testutils.silo import assume_test_silo_mode, region_silo_test
 from sentry.testutils.skips import requires_kafka, requires_snuba
 from sentry.workflow_engine.models import (
+    AlertRuleDetector,
     DataCondition,
     DataConditionGroup,
     DataSource,
@@ -108,6 +109,34 @@ def test_pending_deletion(self):
         detector.save()
         self.get_error_response(self.organization.slug, detector.id, status_code=404)
 
+    def test_with_alert_rule_mapping(self):
+        # Create a metric alert rule mapping
+        metric_alert_id = 12345
+        AlertRuleDetector.objects.create(alert_rule_id=metric_alert_id, detector=self.detector)
+
+        response = self.get_success_response(self.organization.slug, self.detector.id)
+
+        assert response.data["alertRuleId"] == metric_alert_id
+        assert response.data["ruleId"] is None
+
+    def test_with_issue_rule_mapping(self):
+        # Create an issue alert rule mapping
+        issue_rule_id = 67890
+        AlertRuleDetector.objects.create(rule_id=issue_rule_id, detector=self.detector)
+
+        response = self.get_success_response(self.organization.slug, self.detector.id)
+
+        assert response.data["ruleId"] == issue_rule_id
+        assert response.data["alertRuleId"] is None
+
+    def test_without_alert_rule_mapping(self):
+        """Test that alertRuleId and ruleId are null when no mapping exists"""
+        response = self.get_success_response(self.organization.slug, self.detector.id)
+
+        # Verify the mapping fields are null when no mapping exists
+        assert response.data["alertRuleId"] is None
+        assert response.data["ruleId"] is None
+
 
 @region_silo_test
 class OrganizationDetectorDetailsPutTest(OrganizationDetectorDetailsBaseTest):

tests/sentry/workflow_engine/endpoints/test_serializers.py

@@ -50,6 +50,8 @@ def test_serialize_simple(self):
             },
             "owner": None,
             "enabled": detector.enabled,
+            "alertRuleId": None,
+            "ruleId": None,
         }
 
     def test_serialize_full(self):
@@ -164,6 +166,8 @@ def test_serialize_full(self):
             },
             "owner": self.user.get_actor_identifier(),
             "enabled": detector.enabled,
+            "alertRuleId": None,
+            "ruleId": None,
         }
 
     def test_serialize_bulk(self):