File tree Expand file tree Collapse file tree 2 files changed +19
-3
lines changed Expand file tree Collapse file tree 2 files changed +19
-3
lines changed Original file line number Diff line number Diff line change @@ -282,15 +282,29 @@ function makeCellActions({
282
282
return actions ;
283
283
}
284
284
285
- type Props = React . PropsWithoutRef < CellActionsOpts > ;
285
+ /**
286
+ * Potentially temporary as design and product need more time to determine how logs table should trigger the dropdown.
287
+ * Currently, the agreed default for every table should be bold hover. Logs is the only table to use the ellipsis trigger.
288
+ */
289
+ export enum ActionTriggerType {
290
+ ELLIPSIS = 'ellipsis' ,
291
+ BOLD_HOVER = 'bold_hover' ,
292
+ }
286
293
287
- function CellAction ( props : Props ) {
294
+ type Props = React . PropsWithoutRef < CellActionsOpts > & {
295
+ triggerType ?: ActionTriggerType ;
296
+ } ;
297
+
298
+ function CellAction ( { triggerType = ActionTriggerType . BOLD_HOVER , ...props } : Props ) {
288
299
const organization = useOrganization ( ) ;
289
300
const { children, column} = props ;
290
301
const cellActions = makeCellActions ( props ) ;
291
302
const align = fieldAlignment ( column . key as string , column . type ) ;
292
303
293
- if ( organization . features . includes ( 'discover-cell-actions-v2' ) )
304
+ if (
305
+ organization . features . includes ( 'discover-cell-actions-v2' ) &&
306
+ triggerType === ActionTriggerType . BOLD_HOVER
307
+ )
294
308
return (
295
309
< Container
296
310
data-test-id = { cellActions === null ? undefined : 'cell-action-container' }
Original file line number Diff line number Diff line change @@ -17,6 +17,7 @@ import useOrganization from 'sentry/utils/useOrganization';
17
17
import useProjectFromId from 'sentry/utils/useProjectFromId' ;
18
18
import CellAction , {
19
19
Actions ,
20
+ ActionTriggerType ,
20
21
copyToClipboard ,
21
22
openExternalLink ,
22
23
} from 'sentry/views/discover/table/cellAction' ;
@@ -320,6 +321,7 @@ export const LogRowContent = memo(function LogRowContent({
320
321
? [ ]
321
322
: ALLOWED_CELL_ACTIONS
322
323
}
324
+ triggerType = { ActionTriggerType . ELLIPSIS }
323
325
>
324
326
{ renderedField }
325
327
</ CellAction >
You can’t perform that action at this time.
0 commit comments