feat(aci): add data condition warning about occurrence-based monitors (#95372)

added a `warningMessage` field to the data condition map so that we can
add other/different messages in the future if necessary

<img width="942" height="405" alt="Screenshot 2025-07-11 at 1 34 24 PM"
src="https://github.com/user-attachments/assets/83171270-363d-4b0f-bf0e-613ad9c1ebe0"
/>

Author: ameliahsu

static/app/views/automations/components/dataConditionNodeList.spec.tsx

@@ -2,7 +2,7 @@ import {DataConditionFixture} from 'sentry-fixture/automations';
 import {OrganizationFixture} from 'sentry-fixture/organization';
 import {DataConditionHandlerFixture} from 'sentry-fixture/workflowEngine';
 
-import {render, screen, userEvent} from 'sentry-test/reactTestingLibrary';
+import {render, screen, userEvent, within} from 'sentry-test/reactTestingLibrary';
 
 import type {DataConditionHandler} from 'sentry/types/workflowEngine/dataConditions';
 import {
@@ -24,7 +24,7 @@ const dataConditionHandlers: DataConditionHandler[] = [
     type: DataConditionType.ISSUE_PRIORITY_DEESCALATING,
   }),
   DataConditionHandlerFixture({
-    type: DataConditionType.TAGGED_EVENT,
+    type: DataConditionType.EVENT_FREQUENCY,
     handlerSubgroup: DataConditionHandlerSubgroupType.EVENT_ATTRIBUTES,
   }),
 ];
@@ -86,7 +86,9 @@ describe('DataConditionNodeList', function () {
     expect(
       screen.getByRole('menuitemradio', {name: 'Issue priority'})
     ).toBeInTheDocument();
-    expect(screen.getByRole('menuitemradio', {name: 'Tagged event'})).toBeInTheDocument();
+    expect(
+      screen.getByRole('menuitemradio', {name: 'Number of events'})
+    ).toBeInTheDocument();
   });
 
   it('adds conditions', async function () {
@@ -289,4 +291,33 @@ describe('DataConditionNodeList', function () {
 
     expect(screen.getByText(errorMessage)).toBeInTheDocument();
   });
+
+  it('shows warning message for occurrence-based monitors', async function () {
+    render(
+      <AutomationBuilderErrorContext.Provider
+        value={{errors: {}, setErrors: jest.fn(), removeError: jest.fn()}}
+      >
+        <AutomationBuilderConflictContext.Provider value={defaultConflictContextProps}>
+          <DataConditionNodeList {...defaultProps} />
+        </AutomationBuilderConflictContext.Provider>
+      </AutomationBuilderErrorContext.Provider>,
+      {organization}
+    );
+
+    // Open dropdown
+    await userEvent.click(screen.getByRole('textbox', {name: 'Add condition'}));
+    // Find the "Number of events" option which should have a warning icon
+    const numberOfEventsOption = screen.getByRole('menuitemradio', {
+      name: 'Number of events',
+    });
+    // Hover over the warning icon within the "Number of events" option
+    const warningIcon = within(numberOfEventsOption).getByRole('img');
+    await userEvent.hover(warningIcon);
+
+    expect(
+      await screen.findByText(
+        'These filters will only apply to some of your monitors and triggers.'
+      )
+    ).toBeInTheDocument();
+  });
 });

static/app/views/automations/components/dataConditionNodeList.tsx

@@ -4,6 +4,8 @@ import styled from '@emotion/styled';
 import {Alert} from 'sentry/components/core/alert';
 import {Checkbox} from 'sentry/components/core/checkbox';
 import {Select} from 'sentry/components/core/select';
+import {Tooltip} from 'sentry/components/core/tooltip';
+import {IconWarning} from 'sentry/icons';
 import {t} from 'sentry/locale';
 import type {DataCondition} from 'sentry/types/workflowEngine/dataConditions';
 import {
@@ -17,7 +19,6 @@ import AutomationBuilderRow from 'sentry/views/automations/components/automation
 import {
   DataConditionNodeContext,
   dataConditionNodesMap,
-  frequencyTypeMapping,
   useDataConditionNodeContext,
 } from 'sentry/views/automations/components/dataConditionNodes';
 import {useDataConditionsQuery} from 'sentry/views/automations/hooks';
@@ -80,10 +81,19 @@ export default function DataConditionNodeList({
       }
 
       const conditionType = frequencyTypeMapping[handler.type] || handler.type;
+      const conditionLabel = dataConditionNodesMap.get(conditionType)?.label;
+      const WarningMessage = dataConditionNodesMap.get(conditionType)?.warningMessage;
 
       const newDataCondition: Option = {
         value: conditionType,
-        label: dataConditionNodesMap.get(handler.type)?.label || handler.type,
+        label: conditionLabel || handler.type,
+        ...(WarningMessage && {
+          trailingItems: (
+            <Tooltip title={<WarningMessage />}>
+              <IconWarning />
+            </Tooltip>
+          ),
+        }),
       };
 
       if (handler.handlerSubgroup === DataConditionHandlerSubgroupType.EVENT_ATTRIBUTES) {
@@ -218,6 +228,21 @@ function Node() {
   return Component ? <Component /> : node?.label;
 }
 
+/**
+ * Maps COUNT and PERCENT frequency conditions to their base frequency type.
+ * This is used in the UI to show both conditions as a single branching condition.
+ */
+const frequencyTypeMapping: Partial<Record<DataConditionType, DataConditionType>> = {
+  [DataConditionType.PERCENT_SESSIONS_COUNT]: DataConditionType.PERCENT_SESSIONS,
+  [DataConditionType.PERCENT_SESSIONS_PERCENT]: DataConditionType.PERCENT_SESSIONS,
+  [DataConditionType.EVENT_FREQUENCY_COUNT]: DataConditionType.EVENT_FREQUENCY,
+  [DataConditionType.EVENT_FREQUENCY_PERCENT]: DataConditionType.EVENT_FREQUENCY,
+  [DataConditionType.EVENT_UNIQUE_USER_FREQUENCY_COUNT]:
+    DataConditionType.EVENT_UNIQUE_USER_FREQUENCY,
+  [DataConditionType.EVENT_UNIQUE_USER_FREQUENCY_PERCENT]:
+    DataConditionType.EVENT_UNIQUE_USER_FREQUENCY,
+};
+
 const StyledSelectControl = styled(Select)`
   width: 100%;
 `;

static/app/views/automations/components/dataConditionNodes.tsx

@@ -1,7 +1,10 @@
 import type React from 'react';
 import {createContext, useContext} from 'react';
+import styled from '@emotion/styled';
 
+import {Flex} from 'sentry/components/core/layout';
 import {t} from 'sentry/locale';
+import {space} from 'sentry/styles/space';
 import {
   type DataCondition,
   DataConditionType,
@@ -109,6 +112,7 @@ type DataConditionNode = {
   dataCondition?: React.ComponentType<any>;
   defaultComparison?: any;
   details?: React.ComponentType<any>;
+  warningMessage?: React.ComponentType<any>;
 };
 
 export const dataConditionNodesMap = new Map<DataConditionType, DataConditionNode>([
@@ -212,6 +216,7 @@ export const dataConditionNodesMap = new Map<DataConditionType, DataConditionNod
         environment: '',
       },
       validate: validateLatestAdoptedReleaseCondition,
+      warningMessage: OccurenceBasedMonitorsWarning,
     },
   ],
   [
@@ -221,6 +226,7 @@ export const dataConditionNodesMap = new Map<DataConditionType, DataConditionNod
       dataCondition: LatestReleaseNode,
       details: LatestReleaseNode,
       validate: undefined,
+      warningMessage: OccurenceBasedMonitorsWarning,
     },
   ],
   [
@@ -234,6 +240,7 @@ export const dataConditionNodesMap = new Map<DataConditionType, DataConditionNod
         match: MatchType.CONTAINS,
       },
       validate: validateEventAttributeCondition,
+      warningMessage: OccurenceBasedMonitorsWarning,
     },
   ],
   [
@@ -264,6 +271,7 @@ export const dataConditionNodesMap = new Map<DataConditionType, DataConditionNod
       label: t('Number of events'),
       dataCondition: EventFrequencyNode,
       validate: validateEventFrequencyCondition,
+      warningMessage: OccurenceBasedMonitorsWarning,
     },
   ],
   [
@@ -274,6 +282,7 @@ export const dataConditionNodesMap = new Map<DataConditionType, DataConditionNod
       details: EventFrequencyCountDetails,
       defaultComparison: {value: 100, interval: Interval.ONE_HOUR},
       validate: validateEventFrequencyCondition,
+      warningMessage: OccurenceBasedMonitorsWarning,
     },
   ],
   [
@@ -288,6 +297,7 @@ export const dataConditionNodesMap = new Map<DataConditionType, DataConditionNod
         comparison_interval: Interval.ONE_WEEK,
       },
       validate: validateEventFrequencyCondition,
+      warningMessage: OccurenceBasedMonitorsWarning,
     },
   ],
   [
@@ -296,6 +306,7 @@ export const dataConditionNodesMap = new Map<DataConditionType, DataConditionNod
       label: t('Number of users affected'),
       dataCondition: EventUniqueUserFrequencyNode,
       validate: validateEventUniqueUserFrequencyCondition,
+      warningMessage: OccurenceBasedMonitorsWarning,
     },
   ],
   [
@@ -306,6 +317,7 @@ export const dataConditionNodesMap = new Map<DataConditionType, DataConditionNod
       details: EventUniqueUserFrequencyCountDetails,
       defaultComparison: {value: 100, interval: Interval.ONE_HOUR},
       validate: validateEventUniqueUserFrequencyCondition,
+      warningMessage: OccurenceBasedMonitorsWarning,
     },
   ],
   [
@@ -320,6 +332,7 @@ export const dataConditionNodesMap = new Map<DataConditionType, DataConditionNod
         comparison_interval: Interval.ONE_WEEK,
       },
       validate: validateEventUniqueUserFrequencyCondition,
+      warningMessage: OccurenceBasedMonitorsWarning,
     },
   ],
   [
@@ -328,6 +341,7 @@ export const dataConditionNodesMap = new Map<DataConditionType, DataConditionNod
       label: t('Percentage of sessions affected'),
       dataCondition: PercentSessionsNode,
       validate: validatePercentSessionsCondition,
+      warningMessage: OccurenceBasedMonitorsWarning,
     },
   ],
   [
@@ -338,6 +352,7 @@ export const dataConditionNodesMap = new Map<DataConditionType, DataConditionNod
       details: PercentSessionsCountDetails,
       defaultComparison: {value: 100, interval: Interval.ONE_HOUR},
       validate: validatePercentSessionsCondition,
+      warningMessage: OccurenceBasedMonitorsWarning,
     },
   ],
   [
@@ -352,18 +367,26 @@ export const dataConditionNodesMap = new Map<DataConditionType, DataConditionNod
         comparison_interval: Interval.ONE_WEEK,
       },
       validate: validatePercentSessionsCondition,
+      warningMessage: OccurenceBasedMonitorsWarning,
     },
   ],
 ]);
 
-export const frequencyTypeMapping: Partial<Record<DataConditionType, DataConditionType>> =
-  {
-    [DataConditionType.PERCENT_SESSIONS_COUNT]: DataConditionType.PERCENT_SESSIONS,
-    [DataConditionType.PERCENT_SESSIONS_PERCENT]: DataConditionType.PERCENT_SESSIONS,
-    [DataConditionType.EVENT_FREQUENCY_COUNT]: DataConditionType.EVENT_FREQUENCY,
-    [DataConditionType.EVENT_FREQUENCY_PERCENT]: DataConditionType.EVENT_FREQUENCY,
-    [DataConditionType.EVENT_UNIQUE_USER_FREQUENCY_COUNT]:
-      DataConditionType.EVENT_UNIQUE_USER_FREQUENCY,
-    [DataConditionType.EVENT_UNIQUE_USER_FREQUENCY_PERCENT]:
-      DataConditionType.EVENT_UNIQUE_USER_FREQUENCY,
-  };
+function OccurenceBasedMonitorsWarning() {
+  return (
+    <Flex direction="column" gap={space(1)}>
+      <WarningLine>
+        {t('These filters will only apply to some of your monitors and triggers.')}
+      </WarningLine>
+      <WarningLine>
+        {t(
+          'They are only available for occurrence-based monitors \(errors, N+1, and replay\) and only apply to the triggers "A new event is captured for an issue" and "A new issue is created."'
+        )}
+      </WarningLine>
+    </Flex>
+  );
+}
+
+const WarningLine = styled('p')`
+  margin: 0;
+`;