Fix mypy

Author: roaga

src/sentry/seer/endpoints/seer_rpc.py

@@ -56,10 +56,10 @@
 from sentry.search.events.types import SnubaParams
 from sentry.seer.autofix.autofix_tools import get_error_event_details, get_profile_details
 from sentry.seer.explorer.index_data import (
-    get_issues_for_transaction,
-    get_profiles_for_trace,
-    get_trace_for_transaction,
-    get_transactions_for_project,
+    rpc_get_issues_for_transaction,
+    rpc_get_profiles_for_trace,
+    rpc_get_trace_for_transaction,
+    rpc_get_transactions_for_project,
 )
 from sentry.seer.fetch_issues.fetch_issues import (
     get_issues_related_to_file_patches,
@@ -563,10 +563,10 @@ def get_github_enterprise_integration_config(
     "get_attribute_names": get_attribute_names,
     "get_attribute_values_with_substring": get_attribute_values_with_substring,
     "get_attributes_and_values": get_attributes_and_values,
-    "get_transactions_for_project": get_transactions_for_project,
-    "get_trace_for_transaction": get_trace_for_transaction,
-    "get_profiles_for_trace": get_profiles_for_trace,
-    "get_issues_for_transaction": get_issues_for_transaction,
+    "get_transactions_for_project": rpc_get_transactions_for_project,
+    "get_trace_for_transaction": rpc_get_trace_for_transaction,
+    "get_profiles_for_trace": rpc_get_profiles_for_trace,
+    "get_issues_for_transaction": rpc_get_issues_for_transaction,
     "get_github_enterprise_integration_config": get_github_enterprise_integration_config,
 }
 

src/sentry/seer/explorer/index_data.py

@@ -5,11 +5,12 @@
 import orjson
 
 from sentry import search
-from sentry.api.event_search import parse_search_query
+from sentry.api.event_search import SearchFilter, parse_search_query
+from sentry.api.issue_search import convert_query_values
 from sentry.api.serializers.base import serialize
 from sentry.api.serializers.models.event import EventSerializer
 from sentry.eventstore import backend as eventstore
-from sentry.eventstore.models import GroupEvent
+from sentry.eventstore.models import Event, GroupEvent
 from sentry.models.project import Project
 from sentry.profiles.utils import get_from_profiling_service
 from sentry.search.eap.types import SearchResolverConfig
@@ -397,27 +398,19 @@ def get_issues_for_transaction(transaction_name: str, project_id: int) -> Transa
     start_time = end_time - timedelta(hours=24)
 
     # Step 1: Search for issues using transaction filter
-    try:
-        parsed_terms = parse_search_query(f'transaction:"{transaction_name}"')
-    except Exception:
-        logger.exception(
-            "Failed to parse transaction search query",
-            extra={"transaction_name": transaction_name, "project_id": project_id},
-        )
-        return None
+    parsed_terms = parse_search_query(f'transaction:"{transaction_name}"')
+    converted_terms = convert_query_values(parsed_terms, [project], None, [])
+    search_filters = [term for term in converted_terms if isinstance(term, SearchFilter)]
 
-    # Query for issues using the search backend
-    query_kwargs = {
-        "projects": [project],
-        "date_from": start_time,
-        "date_to": end_time,
-        "search_filters": parsed_terms,
-        "sort_by": "freq",
-        "limit": 3,
-        "environments": [],
-    }
-
-    results_cursor = search.backend.query(**query_kwargs)
+    results_cursor = search.backend.query(
+        projects=[project],
+        date_from=start_time,
+        date_to=end_time,
+        search_filters=search_filters,
+        sort_by="freq",
+        limit=3,
+        environments=[],
+    )
     issues = list(results_cursor)
 
     if not issues:
@@ -441,7 +434,7 @@ def get_issues_for_transaction(transaction_name: str, project_id: int) -> Transa
             )
             continue
 
-        full_event: GroupEvent | None = eventstore.get_event_by_id(
+        full_event: Event | GroupEvent | None = eventstore.get_event_by_id(
             project_id=group.project_id,
             event_id=recommended_event.event_id,
             group_id=group.id,
@@ -479,3 +472,27 @@ def get_issues_for_transaction(transaction_name: str, project_id: int) -> Transa
         project_id=project_id,
         issues=issue_data_list,
     )
+
+
+# RPC wrappers
+
+
+def rpc_get_transactions_for_project(project_id: int) -> dict[str, Any]:
+    transactions = get_transactions_for_project(project_id)
+    transaction_dicts = [transaction.dict() for transaction in transactions]
+    return {"transactions": transaction_dicts}
+
+
+def rpc_get_trace_for_transaction(transaction_name: str, project_id: int) -> dict[str, Any]:
+    trace = get_trace_for_transaction(transaction_name, project_id)
+    return trace.dict() if trace else {}
+
+
+def rpc_get_profiles_for_trace(trace_id: str, project_id: int) -> dict[str, Any]:
+    profiles = get_profiles_for_trace(trace_id, project_id)
+    return profiles.dict() if profiles else {}
+
+
+def rpc_get_issues_for_transaction(transaction_name: str, project_id: int) -> dict[str, Any]:
+    issues = get_issues_for_transaction(transaction_name, project_id)
+    return issues.dict() if issues else {}

tests/sentry/seer/explorer/test_explorer_utils.py

@@ -1,3 +1,5 @@
+from typing import Any
+
 from sentry.seer.explorer.utils import convert_profile_to_execution_tree, normalize_description
 
 
@@ -14,11 +16,6 @@ def test_normalize_description_empty_string(self):
         result = normalize_description("")
         assert result == ""
 
-    def test_normalize_description_none_input(self):
-        """Test with None input."""
-        result = normalize_description(None)
-        assert result == ""
-
     def test_normalize_description_uuid_with_dashes(self):
         """Test UUID normalization with dashes."""
         result = normalize_description(
@@ -116,7 +113,7 @@ def test_convert_profile_no_profile_key(self):
 
     def test_convert_profile_missing_required_fields(self):
         """Test with missing required fields in profile."""
-        profile_data = {"profile": {"frames": []}}
+        profile_data: dict[str, Any] = {"profile": {"frames": []}}
         result = convert_profile_to_execution_tree(profile_data)
         assert result == []
 
@@ -126,7 +123,7 @@ def test_convert_profile_missing_required_fields(self):
 
     def test_convert_profile_empty_profile_data(self):
         """Test with empty but valid profile structure."""
-        profile_data = {
+        profile_data: dict[str, Any] = {
             "profile": {
                 "frames": [],
                 "stacks": [],
@@ -139,7 +136,7 @@ def test_convert_profile_empty_profile_data(self):
 
     def test_convert_profile_single_frame_single_sample(self):
         """Test with minimal valid profile data."""
-        profile_data = {
+        profile_data: dict[str, Any] = {
             "profile": {
                 "frames": [
                     {
@@ -179,7 +176,7 @@ def test_convert_profile_single_frame_single_sample(self):
 
     def test_convert_profile_nested_call_stack(self):
         """Test with nested call stack."""
-        profile_data = {
+        profile_data: dict[str, Any] = {
             "profile": {
                 "frames": [
                     {
@@ -233,7 +230,7 @@ def test_convert_profile_nested_call_stack(self):
 
     def test_convert_profile_multiple_samples_duration_calculation(self):
         """Test duration calculation with multiple samples."""
-        profile_data = {
+        profile_data: dict[str, Any] = {
             "profile": {
                 "frames": [
                     {
@@ -278,7 +275,7 @@ def test_convert_profile_multiple_samples_duration_calculation(self):
 
     def test_convert_profile_filters_non_app_frames(self):
         """Test that non-app frames are filtered out."""
-        profile_data = {
+        profile_data: dict[str, Any] = {
             "profile": {
                 "frames": [
                     {
@@ -326,7 +323,7 @@ def test_convert_profile_filters_non_app_frames(self):
 
     def test_convert_profile_filters_generated_frames(self):
         """Test that generated frames (with <filename>) are filtered out."""
-        profile_data = {
+        profile_data: dict[str, Any] = {
             "profile": {
                 "frames": [
                     {
@@ -366,7 +363,7 @@ def test_convert_profile_filters_generated_frames(self):
 
     def test_convert_profile_single_thread_fallback(self):
         """Test fallback to single thread when no MainThread is found."""
-        profile_data = {
+        profile_data: dict[str, Any] = {
             "profile": {
                 "frames": [
                     {
@@ -395,7 +392,7 @@ def test_convert_profile_single_thread_fallback(self):
 
     def test_convert_profile_ignores_other_threads(self):
         """Test that samples from other threads are ignored."""
-        profile_data = {
+        profile_data: dict[str, Any] = {
             "profile": {
                 "frames": [
                     {
@@ -442,7 +439,7 @@ def test_convert_profile_ignores_other_threads(self):
 
     def test_convert_profile_complex_call_patterns(self):
         """Test complex call patterns with function entries and exits."""
-        profile_data = {
+        profile_data: dict[str, Any] = {
             "profile": {
                 "frames": [
                     {
@@ -508,7 +505,7 @@ def test_convert_profile_complex_call_patterns(self):
 
     def test_convert_profile_duration_calculation_accuracy(self):
         """Test that duration calculations are reasonable."""
-        profile_data = {
+        profile_data: dict[str, Any] = {
             "profile": {
                 "frames": [
                     {

tests/sentry/seer/explorer/test_index_data.py

@@ -126,13 +126,14 @@ def test_get_trace_for_transaction(self):
         assert len(result.spans) == 5
 
         # Verify all spans have correct structure and belong to the chosen trace
-        for span in result.spans:
-            assert hasattr(span, "span_id")
-            assert hasattr(span, "span_description")
-            assert hasattr(span, "parent_span_id")
-            assert hasattr(span, "span_op")
-            assert span.span_description.startswith("span-")
-            assert "trace-medium" in span.span_description  # Should be from the median trace
+        for result_span in result.spans:
+            assert hasattr(result_span, "span_id")
+            assert hasattr(result_span, "span_description")
+            assert hasattr(result_span, "parent_span_id")
+            assert hasattr(result_span, "span_op")
+            assert result_span.span_description is not None
+            assert result_span.span_description.startswith("span-")
+            assert "trace-medium" in result_span.span_description  # Should be from the median trace
 
         # Verify parent-child relationships are preserved
         root_spans = [s for s in result.spans if s.parent_span_id is None]