Skip to content

Commit e14cda1

Browse files
committed
fix(pr): Types and whatnot
1 parent 9c51892 commit e14cda1

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

src/sentry/workflow_engine/endpoints/organization_detector_index.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,6 @@ def get(self, request: Request, organization: Organization) -> Response:
164164
case SearchFilter(key=SearchKey("type"), operator=("=" | "IN" | "!=")):
165165
queryset = apply_filter(queryset, filter, "type")
166166
case SearchFilter(key=SearchKey("assignee"), operator=("=" | "IN" | "!=")):
167-
breakpoint()
168167
# Handle assignee filtering with support for users, teams, "me", and "unassigned"
169168
if isinstance(filter.value.value, list):
170169
# Handle multiple values (IN operator)

static/app/views/detectors/components/detectorSearch.tsx

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import {SearchQueryBuilder} from 'sentry/components/searchQueryBuilder';
22
import {t} from 'sentry/locale';
33
import type {Tag, TagCollection} from 'sentry/types/group';
44
import type {FieldDefinition} from 'sentry/utils/fields';
5-
import {FieldKind} from 'sentry/utils/fields';
5+
import {FieldKey, FieldKind} from 'sentry/utils/fields';
66
import useAssignedSearchValues from 'sentry/utils/membersAndTeams/useAssignedSearchValues';
77
import {useLocation} from 'sentry/utils/useLocation';
88
import {useNavigate} from 'sentry/utils/useNavigate';
@@ -35,7 +35,8 @@ export function DetectorSearch() {
3535
const {values} = DETECTOR_FILTER_KEYS[key] ?? {};
3636

3737
// Special handling for assignee field to provide user/team values
38-
if (key === 'assignee') {
38+
// See getFeedbackFilterKeys in static/app/components/feedback/feedbackSearch.tsx
39+
if (key === FieldKey.ASSIGNED) {
3940
return [
4041
key,
4142
{
@@ -59,7 +60,7 @@ export function DetectorSearch() {
5960
})
6061
);
6162

62-
const getTagValues = (tag: Tag, _query: string): string[] => {
63+
const getTagValues = (tag: Tag, _query: string): Promise<string[]> => {
6364
// For assignee field, return the assigned values filtered by query
6465
if (tag.key === 'assignee') {
6566
const allAssigneeValues: string[] = [];
@@ -75,15 +76,17 @@ export function DetectorSearch() {
7576

7677
// Filter by query if provided
7778
if (_query) {
78-
return allAssigneeValues.filter(value =>
79-
value.toLowerCase().includes(query.toLowerCase())
79+
return Promise.resolve(
80+
allAssigneeValues.filter(value =>
81+
value.toLowerCase().includes(_query.toLowerCase())
82+
)
8083
);
8184
}
82-
return allAssigneeValues;
85+
return Promise.resolve(allAssigneeValues);
8386
}
8487

8588
// For other fields, return empty array (no dynamic values)
86-
return [];
89+
return Promise.resolve([]);
8790
};
8891

8992
return (

0 commit comments

Comments
 (0)