Skip to content

Commit e8562ac

Browse files
authored
ref(profiling-onboarding): Remove verify override (#99465)
Remove the override for the verify step in the profiling onboarding. Ensure that the verify step is defined for all platforms.
1 parent d325053 commit e8562ac

File tree

11 files changed

+43
-19
lines changed

11 files changed

+43
-19
lines changed

static/app/gettingStartedDocs/android/android.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -616,7 +616,7 @@ const profilingOnboarding: OnboardingConfig<PlatformOptions> = {
616616
{
617617
type: StepType.VERIFY,
618618
description: t(
619-
'To confirm that profiling is working correctly, run your application and check the Sentry profiles page for the collected profiles.'
619+
'Verify that profiling is working correctly by simply using your application.'
620620
),
621621
},
622622
],

static/app/gettingStartedDocs/php/laravel.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,6 @@ const profilingOnboarding: OnboardingConfig = {
387387
description: t(
388388
'Verify that profiling is working correctly by simply using your application.'
389389
),
390-
configurations: [],
391390
},
392391
],
393392
nextSteps: () => [],

static/app/gettingStartedDocs/php/php.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,6 @@ const profilingOnboarding: OnboardingConfig = {
312312
description: t(
313313
'Verify that profiling is working correctly by simply using your application.'
314314
),
315-
configurations: [],
316315
},
317316
],
318317
nextSteps: () => [],

static/app/gettingStartedDocs/php/symfony.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,6 @@ SENTRY_DSN="${params.dsn.public}"
281281
description: t(
282282
'Verify that profiling is working correctly by simply using your application.'
283283
),
284-
configurations: [],
285284
},
286285
],
287286
nextSteps: () => [],

static/app/gettingStartedDocs/python/awslambda.tsx

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,14 @@ logger.error('Something went wrong')`,
223223
const profilingOnboarding: OnboardingConfig = {
224224
install: () => [installStep()],
225225
configure: (params: Params) => [configureStep(params)],
226-
verify: () => [],
226+
verify: () => [
227+
{
228+
type: StepType.VERIFY,
229+
description: t(
230+
'Verify that profiling is working correctly by simply using your application.'
231+
),
232+
},
233+
],
227234
};
228235

229236
const logsOnboarding = getPythonLogsOnboarding();

static/app/gettingStartedDocs/python/tryton.tsx

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,9 +174,22 @@ logger.error('Something went wrong')`,
174174

175175
const logsOnboarding = getPythonLogsOnboarding();
176176

177+
const profilingOnboarding: OnboardingConfig = {
178+
install: onboarding.install,
179+
configure: onboarding.configure,
180+
verify: () => [
181+
{
182+
type: StepType.VERIFY,
183+
description: t(
184+
'Verify that profiling is working correctly by simply using your application.'
185+
),
186+
},
187+
],
188+
};
189+
177190
const docs: Docs = {
178191
onboarding,
179-
profilingOnboarding: onboarding,
192+
profilingOnboarding,
180193
crashReportOnboarding: crashReportOnboardingPython,
181194
agentMonitoringOnboarding,
182195
logsOnboarding,

static/app/gettingStartedDocs/react-native/react-native.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ const getReactNativeProfilingOnboarding = (): OnboardingConfig => ({
193193
{
194194
type: StepType.VERIFY,
195195
description: t(
196-
'To confirm that profiling is working correctly, run your application and check the Sentry profiles page for the collected profiles.'
196+
'Verify that profiling is working correctly by simply using your application.'
197197
),
198198
},
199199
],

static/app/gettingStartedDocs/ruby/ruby.tsx

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,14 @@ end
7575
],
7676
},
7777
],
78-
verify: () => [],
78+
verify: () => [
79+
{
80+
type: StepType.VERIFY,
81+
description: t(
82+
'Verify that profiling is working correctly by simply using your application.'
83+
),
84+
},
85+
],
7986
});
8087

8188
const getInstallSnippet = (params: Params) =>

static/app/utils/gettingStartedDocs/dotnet.tsx

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,5 +170,12 @@ export const getDotnetProfilingOnboarding = ({
170170
),
171171
},
172172
],
173-
verify: () => [],
173+
verify: () => [
174+
{
175+
type: StepType.VERIFY,
176+
description: t(
177+
'Verify that profiling is working correctly by simply using your application.'
178+
),
179+
},
180+
],
174181
});

static/app/utils/gettingStartedDocs/javascript.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ export const getJavascriptProfilingOnboarding = <
144144
{
145145
type: StepType.VERIFY,
146146
description: t(
147-
'To confirm that profiling is working correctly, run your application and check the Sentry profiles page for the collected profiles.'
147+
'Verify that profiling is working correctly by simply using your application.'
148148
),
149149
},
150150
],
@@ -532,7 +532,7 @@ Sentry.startSpan({
532532
{
533533
type: StepType.VERIFY,
534534
description: t(
535-
'To confirm that profiling is working correctly, run your application and check the Sentry profiles page for the collected profiles.'
535+
'Verify that profiling is working correctly by simply using your application.'
536536
),
537537
},
538538
],

0 commit comments

Comments
 (0)