fix(dynamic-sampling): display minimum sample rate rules correctly in admin

[shellmayr]

• Display the minimumSampleRate rule in the same way as a sampleRate rule - in percent. Currently it shows * 1 - which is not the correct way to think about it.
  Before:

After:

[cursor]

Bug: Rule Impact Calculation Fails for Minimum Sample Rates

The evaluateRuleImpact function incorrectly calculates impact for minimumSampleRate rules. Despite minimumSampleRate values now being formatted as percentages (like sampleRate values), the evaluateRuleImpact function was not updated to handle this type. This causes minimumSampleRate rules to fall through to a default value - 1 calculation instead of the correct value - baseSampleRate, leading to inaccurate impact indicators.

static/gsAdmin/views/dynamicSamplingPanel.tsx#L326-L330

sentry/static/gsAdmin/views/dynamicSamplingPanel.tsx

Lines 326 to 330 in f4463e6

	const formatSamplingRateValue = (samplingValue: any) => {
	if (
	samplingValue.type === 'sampleRate' ||
	samplingValue.type === 'minimumSampleRate'
	) {

static/gsAdmin/views/dynamicSamplingPanel.tsx#L338-L349

sentry/static/gsAdmin/views/dynamicSamplingPanel.tsx

Lines 338 to 349 in f4463e6

	const evaluateRuleImpact = (rule: RuleV2) => {
	if (getRuleType(rule) === RuleType.BOOST_LOW_VOLUME_PROJECTS) {
	return 0;
	}
	if (rule.samplingValue.type === 'sampleRate') {
	return round(rule.samplingValue.value - baseSampleRate);
	}
	if (rule.samplingValue.type === 'reservoir') {
	return 1;
	}
	return round(rule.samplingValue.value - 1);

Fix in Cursor • Fix in Web

---

Was this report helpful? Give feedback by reacting with 👍 or 👎