fix(deletions): Prevent DB call from deleting issue #95915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deleting an issue, a failure to query the DB would prevent scheduling the group deletion task. From the customer's perspective, it would look that the group has been deleted, however, all relationships would still be left behind. The biggest problem would be that the group hashes are left behind, thus, any new events matching those group hashes would not create a new issue. This is a better fix than the one proposed in #93541. Fixes #93509. Fixes [ID-716](https://linear.app/getsentry/issue/ID-716/)
github-actions
bot
added
the
Scope: Backend
armenzg
commented
Jul 18, 2025
| @@ -73,6 +73,9 @@ def delete_group_list( | |||
| }, | |||
| ) | |||
|
|
|||
| # Tell seer to delete grouping records for these groups | |||
| may_schedule_task_to_delete_hashes_from_seer(error_ids) | |||
There was a problem hiding this comment.
If this call raises an exception (as it used to do), the exception will be caught by the endpoint and return a 500.
I moved this call here because I don't want the status of the group to be changed.
I have upcoming changes to make this function clearer and more robust.
| @@ -1637,23 +1638,25 @@ def test_bulk_delete_performance_issues(self): | |||
| self.assert_groups_are_gone(groups) | |||
|
|
|||
| @patch("sentry.api.helpers.group_index.delete.may_schedule_task_to_delete_hashes_from_seer") | |||
| @patch("sentry.utils.audit.log_service.record_audit_log") | |||
| def test_audit_log_even_if_exception_raised( | |||
There was a problem hiding this comment.
The previous test does not apply anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting an issue, a failure to query the DB would prevent scheduling the group deletion task.
From the customer's perspective, it would look that the group has been deleted, however, all relationships would still be left behind.
The biggest problem would be that the group hashes are left behind, thus, any new events matching those group hashes would not create a new issue.
This is a better fix than the one proposed in #93541.
Fixes #93509.
Fixes ID-716