fix: replace toLocaleString with toString #98569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
shellmayr
approved these changes
Sep 1, 2025
priscilawebdev
deleted the
priscila/fix/dynamic-sampling/issue-with-system-locale
branch
priscilawebdev
added
the
Trigger: Revert
|
PR reverted: 7f198c1 |
getsentry-bot
added a commit
that referenced
this pull request
Sep 18, 2025
This reverts commit b43994b. Co-authored-by: priscilawebdev <[email protected]>
|
unfortunately the problem persists for @Dav1dde , we will have to add a few logs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some users in certain locales (like Austria) had trouble entering target sample rates in Firefox. The problem happens because toLocaleString() formats numbers using local rules (like "1.000,25" instead of "1000.25"), but parsePercent() uses parseFloat(), which can’t handle these local number formats.
Solution
Replaced
.toLocaleString()with.toString()inorganizationSampling.tsxwhen setting up the form. This keeps the number format consistent so it can be parsed correctly and matches how the rest of the project handles sampling numbers.closes https://linear.app/getsentry/issue/TET-1001/localization-issue-with-number-formatting-in-firefox-affecting-ds