NA: Straighten out ResourceContainerTest

Author: bucky-boy

yoti-sdk-api/src/test/java/com/yoti/api/client/docs/session/retrieve/ResourceContainerTest.java

@@ -1,6 +1,7 @@
 package com.yoti.api.client.docs.session.retrieve;
 
 import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.contains;
 import static org.hamcrest.Matchers.hasSize;
 
 import java.util.ArrayList;
@@ -17,62 +18,36 @@
 @RunWith(MockitoJUnitRunner.class)
 public class ResourceContainerTest {
 
-    @Mock ZoomLivenessResourceResponse zoomLivenessResourceResponseMock;
-    @Mock StaticLivenessResourceResponse staticLivenessResourceResponseMock;
-    @Mock LivenessResourceResponse livenessResourceResponse;
+    ResourceContainer testObj = new ResourceContainer();
 
-    ResourceContainer simpleResourceContainer;
+    @Mock ZoomLivenessResourceResponse zoomLivenessResourceMock;
+    @Mock StaticLivenessResourceResponse staticLivenessResourceMock;
+    @Mock LivenessResourceResponse livenessResource;
 
     @Test
     public void shouldFilterZoomLivenessResources() {
-        simpleResourceContainer = new ResourceContainer();
-
-        FieldSetter.setField(
-                simpleResourceContainer,
-                "livenessCapture",
-                Arrays.asList(
-                        zoomLivenessResourceResponseMock,
-                        livenessResourceResponse,
-                        livenessResourceResponse
-                )
-        );
-
-        List<ZoomLivenessResourceResponse> result = simpleResourceContainer.getZoomLivenessResources();
-        assertThat(simpleResourceContainer.getLivenessCapture(), hasSize(3));
-        assertThat(result, hasSize(1));
+        FieldSetter.setField(testObj, "livenessCapture", Arrays.asList(zoomLivenessResourceMock, staticLivenessResourceMock, livenessResource));
+
+        List<ZoomLivenessResourceResponse> result = testObj.getZoomLivenessResources();
+
+        assertThat(result, contains(zoomLivenessResourceMock));
     }
 
     @Test
     public void shouldFilterStaticLivenessResources() {
-        simpleResourceContainer = new ResourceContainer();
-
-        FieldSetter.setField(
-                simpleResourceContainer,
-                "livenessCapture",
-                Arrays.asList(
-                        staticLivenessResourceResponseMock,
-                        livenessResourceResponse,
-                        livenessResourceResponse
-                )
-        );
-
-        List<StaticLivenessResourceResponse> result = simpleResourceContainer.getStaticLivenessResources();
-        assertThat(simpleResourceContainer.getLivenessCapture(), hasSize(3));
-        assertThat(result, hasSize(1));
+        FieldSetter.setField(testObj, "livenessCapture", Arrays.asList(zoomLivenessResourceMock, staticLivenessResourceMock, livenessResource));
+
+        List<StaticLivenessResourceResponse> result = testObj.getStaticLivenessResources();
+
+        assertThat(result, contains(staticLivenessResourceMock));
     }
 
     @Test
     public void shouldReturnEmptyList() {
-        simpleResourceContainer = new ResourceContainer();
+        FieldSetter.setField(testObj, "livenessCapture", new ArrayList<>());
 
-        FieldSetter.setField(
-                simpleResourceContainer,
-                "livenessCapture",
-                new ArrayList<>()
-        );
+        List<ZoomLivenessResourceResponse> result = testObj.getZoomLivenessResources();
 
-        List<ZoomLivenessResourceResponse> result = simpleResourceContainer.getZoomLivenessResources();
-        assertThat(simpleResourceContainer.getLivenessCapture(), hasSize(0));
         assertThat(result, hasSize(0));
     }