SDK-2756: Revert ability to request share codes as part of a regular IDV session

Author: MrBurtyyy

yoti-sdk-api/src/main/java/com/yoti/api/client/docs/session/create/RequiredShareCodePayload.java

@@ -69,9 +69,6 @@ public class SessionSpec {
     @JsonProperty("create_identity_profile_preview")
     private final Boolean createIdentityProfilePreview;
 
-    @JsonProperty("required_share_codes")
-    private final List<RequiredShareCodePayload> requiredShareCodes;
-
     private SessionSpec(Integer clientSessionTokenTtl,
             Integer resourcesTtl,
             ImportTokenPayload importToken,
@@ -88,8 +85,7 @@ private SessionSpec(Integer clientSessionTokenTtl,
             SubjectPayload subject,
             ResourceCreationContainer resources,
             Boolean createIdentityProfilePreview,
-            AdvancedIdentityProfileRequirementsPayload advancedIdentityProfileRequirements,
-            List<RequiredShareCodePayload> requiredShareCodes) {
+            AdvancedIdentityProfileRequirementsPayload advancedIdentityProfileRequirements) {
         this.clientSessionTokenTtl = clientSessionTokenTtl;
         this.resourcesTtl = resourcesTtl;
         this.importToken = importToken;
@@ -107,7 +103,6 @@ private SessionSpec(Integer clientSessionTokenTtl,
         this.resources = resources;
         this.createIdentityProfilePreview = createIdentityProfilePreview;
         this.advancedIdentityProfileRequirements = advancedIdentityProfileRequirements;
-        this.requiredShareCodes = requiredShareCodes;
     }
 
     public static Builder builder() {
@@ -268,15 +263,6 @@ public AdvancedIdentityProfileRequirementsPayload getAdvancedIdentityProfileRequ
         return advancedIdentityProfileRequirements;
     }
 
-    /**
-     * The list of Share Codes being requested.
-     *
-     * @return the requested Share Codes
-     */
-    public List<RequiredShareCodePayload> getRequiredShareCodes() {
-        return requiredShareCodes;
-    }
-
     public static class Builder {
 
         private final List<RequestedCheck<?>> requestedChecks;
@@ -296,13 +282,11 @@ public static class Builder {
         private SubjectPayload subject;
         private ResourceCreationContainer resources;
         private Boolean createIdentityProfilePreview;
-        private final List<RequiredShareCodePayload> requiredShareCodes;
 
         private Builder() {
             requestedChecks = new ArrayList<>();
             requestedTasks = new ArrayList<>();
             requiredDocuments = new ArrayList<>();
-            requiredShareCodes = new ArrayList<>();
         }
 
         /**
@@ -493,17 +477,6 @@ public Builder withAdvancedIdentityProfileRequirements(AdvancedIdentityProfileRe
             return this;
         }
 
-        /**
-         * Adds a required Share Code to the list
-         *
-         * @param requiredShareCode the required share code
-         * @return the builder
-         */
-        public Builder withRequiredShareCode(RequiredShareCodePayload requiredShareCode) {
-            this.requiredShareCodes.add(requiredShareCode);
-            return this;
-        }
-
         /**
          * Builds the {@link SessionSpec} based on the values supplied to the builder
          *
@@ -527,8 +500,7 @@ public SessionSpec build() {
                     subject,
                     resources,
                     createIdentityProfilePreview,
-                    advancedIdentityProfileRequirementsPayload,
-                    requiredShareCodes);
+                    advancedIdentityProfileRequirementsPayload);
         }
     }
 

yoti-sdk-api/src/main/java/com/yoti/api/client/docs/session/create/SessionSpec.java

@@ -40,11 +40,6 @@ public class SessionSpecTest {
     private static final String SOME_SDK_CONFIG_LOCALE = "en";
     private static final String SOME_SDK_CONFIG_PRESET_ISSUING_COUNTRY = "USA";
 
-    private static final String SOME_ISSUER = "UK_GOV";
-    private static final String SOME_SCHEME = "RTW";
-    private static final String SOME_OTHER_ISSUER = "someOtherIssuer";
-    private static final String SOME_OTHER_SCHEME = "someOtherScheme";
-
     private static final String SOME_SDK_CONFIG_SUCCESS_URL = "https://yourdomain.com/some/success/endpoint";
     private static final String SOME_SDK_CONFIG_ERROR_URL = "https://yourdomain.com/some/error/endpoint";
 
@@ -257,37 +252,4 @@ public void shouldBuildWithImportToken() {
         assertThat(sessionSpec.getImportToken(), is(importTokenMock));
     }
 
-    @Test
-    public void shouldBuildWithSingleRequiredShareCode() {
-        RequiredShareCodePayload requiredShareCodePayload = RequiredShareCodePayload.builder()
-                .withIssuer(SOME_ISSUER)
-                .withScheme(SOME_SCHEME)
-                .build();
-
-        SessionSpec sessionSpec = SessionSpec.builder()
-                .withRequiredShareCode(requiredShareCodePayload)
-                .build();
-
-        assertThat(sessionSpec.getRequiredShareCodes(), containsInRelativeOrder(requiredShareCodePayload));
-    }
-
-    @Test
-    public void shouldBuildWithMultipleRequiredShareCodes() {
-        RequiredShareCodePayload requiredShareCodePayload1 = RequiredShareCodePayload.builder()
-                .withIssuer(SOME_ISSUER)
-                .withScheme(SOME_SCHEME)
-                .build();
-        RequiredShareCodePayload requiredShareCodePayload2 = RequiredShareCodePayload.builder()
-                .withIssuer(SOME_OTHER_ISSUER)
-                .withScheme(SOME_OTHER_SCHEME)
-                .build();
-
-        SessionSpec sessionSpec = SessionSpec.builder()
-                .withRequiredShareCode(requiredShareCodePayload1)
-                .withRequiredShareCode(requiredShareCodePayload2)
-                .build();
-
-        assertThat(sessionSpec.getRequiredShareCodes(), containsInRelativeOrder(requiredShareCodePayload1, requiredShareCodePayload2));
-    }
-
 }