Hotfix 2.7.1: Fix date not being formatted to UTC correctly in thirdparty extension content

Author: MrBurtyyy

README.md

@@ -104,13 +104,13 @@ If you are using Maven, you need to add the following dependency:
 <dependency>
     <groupId>com.yoti</groupId>
     <artifactId>yoti-sdk-impl</artifactId>
-    <version>2.7.0</version>
+    <version>2.7.1-SNAPSHOT</version>
 </dependency>
 ```
 
 If you are using Gradle, here is the dependency to add:
 
-`compile group: 'com.yoti', name: 'yoti-sdk-impl', version: '2.7.0'`
+`compile group: 'com.yoti', name: 'yoti-sdk-impl', version: '2.7.1-SNAPSHOT'`
 
 You will find all classes packaged under `com.yoti.api`
 

pom.xml

@@ -5,7 +5,7 @@
   <groupId>com.yoti</groupId>
   <artifactId>yoti-sdk</artifactId>
   <packaging>pom</packaging>
-  <version>2.7.0</version>
+  <version>2.7.1-SNAPSHOT</version>
   <name>Yoti SDK</name>
   <description>Java SDK for simple integration with the Yoti platform</description>
   <url>https://github.com/getyoti/yoti-java-sdk</url>

yoti-sdk-api/pom.xml

@@ -11,7 +11,7 @@
   <parent>
     <groupId>com.yoti</groupId>
     <artifactId>yoti-sdk-parent</artifactId>
-    <version>2.7.0</version>
+    <version>2.7.1-SNAPSHOT</version>
     <relativePath>../yoti-sdk-parent</relativePath>
   </parent>
 

yoti-sdk-api/src/main/java/com/yoti/api/client/shareurl/extension/ThirdPartyAttributeContent.java

@@ -23,6 +23,7 @@ public ThirdPartyAttributeContent(Date expiryDate, List<AttributeDefinition> def
     @JsonProperty("expiry_date")
     public String getExpiryDate() {
         SimpleDateFormat rfcDateFormat = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'");
+        rfcDateFormat.setTimeZone(TimeZone.getTimeZone("UTC"));
         return rfcDateFormat.format(expiryDate.getTime());
     }
 

yoti-sdk-impl/pom.xml

@@ -11,7 +11,7 @@
   <parent>
     <groupId>com.yoti</groupId>
     <artifactId>yoti-sdk-parent</artifactId>
-    <version>2.7.0</version>
+    <version>2.7.1-SNAPSHOT</version>
     <relativePath>../yoti-sdk-parent</relativePath>
   </parent>
 

yoti-sdk-impl/src/main/java/com/yoti/api/client/spi/remote/call/YotiConstants.java

@@ -25,7 +25,7 @@ private YotiConstants() {}
     public static final String CONTENT_TYPE_JPEG = "image/jpeg";
 
     public static final String JAVA = "Java";
-    public static final String SDK_VERSION = JAVA + "-2.7.0";
+    public static final String SDK_VERSION = JAVA + "-2.7.1-SNAPSHOT";
     public static final String SIGNATURE_ALGORITHM = "SHA256withRSA";
     public static final String ASYMMETRIC_CIPHER = "RSA/NONE/PKCS1Padding";
     public static final String SYMMETRIC_CIPHER = "AES/CBC/PKCS7Padding";

yoti-sdk-impl/src/test/java/com/yoti/api/client/shareurl/extension/SimpleThirdPartyAttributeExtensionBuilderTest.java

@@ -80,6 +80,28 @@ public void shouldBuildThirdPartyAttributeExtensionWithGivenValues() {
         assertThat(definitions.get(0).getName(), is(SOME_DEFINITION));
     }
 
+    @Test
+    public void shouldBuildThirdPartyAttributeExtensionWithCorrectDateValue() {
+        TimeZone.setDefault(TimeZone.getTimeZone("America/New_York"));
+        Date date = new Date();
+
+        Extension<ThirdPartyAttributeContent> extension = new SimpleThirdPartyAttributeExtensionBuilder()
+                .withExpiryDate(date)
+                .withDefinition(SOME_DEFINITION)
+                .build();
+
+        SimpleDateFormat sdf = new SimpleDateFormat(YotiConstants.RFC3339_PATTERN_MILLIS);
+        sdf.setTimeZone(TimeZone.getTimeZone("UTC"));
+        String formattedTestDate = sdf.format(date);
+
+        assertEquals(ExtensionConstants.THIRD_PARTY_ATTRIBUTE, extension.getType());
+        assertEquals(formattedTestDate, extension.getContent().getExpiryDate());
+
+        List<AttributeDefinition> definitions = extension.getContent().getDefinitions();
+        assertThat(definitions.size(), is(1));
+        assertThat(definitions.get(0).getName(), is(SOME_DEFINITION));
+    }
+
     @Test
     public void shouldBuildThirdPartyAttributeExtensionWithMultipleDefinitions() {
         List<String> theDefinitions = new ArrayList<>();

yoti-sdk-parent/pom.xml

@@ -5,7 +5,7 @@
   <groupId>com.yoti</groupId>
   <artifactId>yoti-sdk-parent</artifactId>
   <packaging>pom</packaging>
-  <version>2.7.0</version>
+  <version>2.7.1-SNAPSHOT</version>
   <name>Yoti SDK Parent Pom</name>
   <description>Parent pom for the Java SDK projects</description>
   <url>https://github.com/getyoti/yoti-java-sdk</url>

yoti-sdk-sandbox/pom.xml

@@ -11,7 +11,7 @@
   <parent>
     <groupId>com.yoti</groupId>
     <artifactId>yoti-sdk-parent</artifactId>
-    <version>2.7.0</version>
+    <version>2.7.1-SNAPSHOT</version>
     <relativePath>../yoti-sdk-parent</relativePath>
   </parent>
 

yoti-sdk-spring-boot-auto-config/README.md

@@ -18,15 +18,15 @@ If you are using Maven, you need to add the following dependencies:
 <dependency>
   <groupId>com.yoti</groupId>
   <artifactId>yoti-sdk-spring-boot-auto-config</artifactId>
-  <version>2.7.0</version>
+  <version>2.7.1-SNAPSHOT</version>
 </dependency>
 ```
 
 
 If you are using Gradle, here is the dependency to add:
 
 ```
-compile group: 'com.yoti', name: 'yoti-sdk-spring-boot-auto-config', version: '2.7.0'
+compile group: 'com.yoti', name: 'yoti-sdk-spring-boot-auto-config', version: '2.7.1-SNAPSHOT'
 ```