Convert comments on lint attributes to reasons.

Author: kpreid

benches/src/lib.rs

@@ -1,5 +1,8 @@
 #![cfg(not(target_arch = "wasm32"))]
-#![expect(clippy::disallowed_types)] // We're outside of the main wgpu codebase
+#![expect(
+    clippy::disallowed_types,
+    reason = "We're outside of the main wgpu codebase"
+)]
 
 //! Benchmarking framework for `wgpu`.
 //!
@@ -134,7 +137,7 @@ pub fn main(benchmarks: Vec<Benchmark>) {
     // test mode, so we need to accept it.
     let _no_capture = args.contains("--no-capture");
 
-    #[expect(clippy::manual_map)] // So much clearer this way
+    #[expect(clippy::manual_map, reason = "So much clearer this way")]
     let mut override_iterations = if let Some(iters) = args.opt_value_from_str("--iters").unwrap() {
         Some(LoopControl::Iterations(iters))
     } else if let Some(seconds) = args.opt_value_from_str("--time").unwrap() {

examples/features/src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::arc_with_non_send_sync)] // False positive on wasm
+#![allow(clippy::arc_with_non_send_sync, reason = "False positive on wasm")]
 #![warn(clippy::allow_attributes)]
 
 pub mod framework;

naga-test/src/lib.rs

@@ -1,6 +1,9 @@
-// A lot of the code can be unused based on configuration flags,
-// the corresponding warnings aren't helpful.
-#![allow(dead_code, unused_imports)]
+#![allow(
+    dead_code,
+    unused_imports,
+    reason = "A lot of the code can be unused based on configuration flags; \
+        the corresponding warnings aren't helpful."
+)]
 
 use core::fmt::Write;
 

naga/src/proc/overloads/list.rs

@@ -162,9 +162,11 @@ impl crate::proc::overloads::OverloadSet for List {
 }
 
 const fn len_to_full_mask(n: usize) -> u64 {
-    // This is a const function, which _sometimes_ gets called,
-    // so this lint is _sometimes_ triggered, depending on feature set.
-    #[expect(clippy::allow_attributes)]
+    #[expect(
+        clippy::allow_attributes,
+        reason = "This is a const function, which _sometimes_ gets called, \
+            so this lint is _sometimes_ triggered, depending on feature set."
+    )]
     #[allow(clippy::panic)]
     if n >= 64 {
         panic!("List::rules can only hold up to 63 rules");

naga/src/valid/mod.rs

@@ -408,9 +408,10 @@ enum TraceRayVertexReturnState {
     /// Trace ray calls have been found, at least
     /// one uses an acceleration structure that
     /// does not have the flag enabling vertex return.
-    // Don't yet have vertex return builtins to return.
-    // this error for.
-    #[expect(unused)]
+    #[expect(
+        unused,
+        reason = "Don't yet have vertex return builtins to return this error for."
+    )]
     NoVertexReturn(crate::Span),
     /// Trace ray calls have been found, all
     /// acceleration structures have the flag enabling

tests/src/expectations.rs

@@ -319,7 +319,7 @@ impl FailureReason {
     };
 
     /// Match a validation error.
-    #[allow(dead_code)] // Not constructed on wasm
+    #[allow(dead_code, reason = "Not constructed on wasm")]
     pub fn validation_error() -> Self {
         Self {
             kind: Some(FailureResultKind::ValidationError),
@@ -364,7 +364,7 @@ pub enum FailureBehavior {
 
 #[derive(Debug, Clone, Copy, PartialEq)]
 pub(crate) enum FailureResultKind {
-    #[allow(dead_code)] // Not constructed on wasm
+    #[allow(dead_code, reason = "Not constructed on wasm")]
     ValidationError,
     Panic,
 }
@@ -394,7 +394,7 @@ impl FailureResult {
     }
 
     /// Failure result is a validation error.
-    #[allow(dead_code)] // Not constructed on wasm
+    #[allow(dead_code, reason = "Not constructed on wasm")]
     pub(super) fn validation_error() -> Self {
         Self {
             kind: FailureResultKind::ValidationError,

tests/src/lib.rs

@@ -1,6 +1,6 @@
 //! Test utilities for the wgpu repository.
 
-#![allow(clippy::arc_with_non_send_sync)] // False positive on wasm
+#![allow(clippy::arc_with_non_send_sync, reason = "False positive on wasm")]
 
 mod config;
 mod expectations;

tests/tests/wgpu-gpu/create_surface_error.rs

@@ -16,7 +16,10 @@ fn canvas_get_context_returned_null() {
     // Using a context id that is not "webgl2" or "webgpu" will render the canvas unusable by wgpu.
     canvas.get_context("2d").unwrap();
 
-    #[allow(clippy::redundant_clone)] // false positive — can't and shouldn't move out.
+    #[allow(
+        clippy::redundant_clone,
+        reason = "false positive — can't and shouldn't move out."
+    )]
     let error = instance
         .create_surface(wgpu::SurfaceTarget::Canvas(canvas.clone()))
         .unwrap_err();

wgpu-core/src/resource.rs

@@ -2353,9 +2353,7 @@ impl Blas {
                 match map_res {
                     Ok(mapping) => {
                         if !mapping.is_coherent {
-                            // Clippy complains about this because it might not be intended, but
-                            // this is intentional.
-                            #[expect(clippy::single_range_in_vec_init)]
+                            #[expect(clippy::single_range_in_vec_init, reason = "intentional")]
                             self.device.raw().invalidate_mapped_ranges(
                                 compaction_buffer,
                                 &[0..size_of::<wgpu_types::BufferAddress>() as wgt::BufferAddress],

wgpu-hal/src/auxil/dxgi/time.rs

@@ -1,4 +1,4 @@
-#![allow(dead_code)] // IPresentationManager is unused currently
+#![allow(dead_code, reason = "IPresentationManager is unused currently")]
 
 use windows::Win32::System::Performance::{QueryPerformanceCounter, QueryPerformanceFrequency};