Skip to content

Commit 6029af9

Browse files
committed
decouple delete class from config
1 parent 08d3d0c commit 6029af9

File tree

4 files changed

+12
-30
lines changed

4 files changed

+12
-30
lines changed

src/metldata/builtin_transformations/delete_class/assumptions.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,21 +20,15 @@
2020
from metldata.builtin_transformations.common.assumptions.path_assumptions import (
2121
check_class_exists,
2222
)
23-
from metldata.builtin_transformations.delete_class.config import (
24-
DeleteClassConfig,
25-
)
2623
from metldata.transform.exceptions import ModelAssumptionError
2724

2825

29-
def check_model_assumptions(
30-
model: SchemaPack,
31-
transformation_config: DeleteClassConfig,
32-
) -> None:
26+
def check_model_assumptions(model: SchemaPack, class_name: str) -> None:
3327
"""Check model assumptions for the delete class transformation."""
34-
check_class_exists(model=model, class_name=transformation_config.class_name)
28+
check_class_exists(model=model, class_name=class_name)
3529
check_class_is_not_root(
3630
model=model,
37-
class_name=transformation_config.class_name,
31+
class_name=class_name,
3832
)
3933

4034

src/metldata/builtin_transformations/delete_class/data_transform.py

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,27 +18,22 @@
1818
from schemapack.spec.datapack import DataPack
1919

2020
from metldata.builtin_transformations.common.utils import data_to_dict
21-
from metldata.builtin_transformations.delete_class.config import (
22-
DeleteClassConfig,
23-
)
2421
from metldata.transform.exceptions import EvitableTransformationError
2522

2623

27-
def delete_data_class(
28-
*, data: DataPack, transformation_config: DeleteClassConfig
29-
) -> DataPack:
24+
def delete_data_class(*, data: DataPack, class_name: str) -> DataPack:
3025
"""Delete class from the provided data."""
3126
modified_data = data_to_dict(data)
3227

3328
try:
34-
del modified_data["resources"][transformation_config.class_name]
29+
del modified_data["resources"][class_name]
3530
except KeyError as exc:
3631
raise EvitableTransformationError() from exc
3732

3833
_remove_relations_from_data(
3934
modified_data=modified_data,
4035
original_data=data,
41-
target_class=transformation_config.class_name,
36+
target_class=class_name,
4237
)
4338
return DataPack.model_validate(modified_data)
4439

src/metldata/builtin_transformations/delete_class/main.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def transform(self, data: DataPack, annotation: SubmissionAnnotation) -> DataPac
5050
DataTransformationError:
5151
if the transformation fails.
5252
"""
53-
return delete_data_class(data=data, transformation_config=self._config)
53+
return delete_data_class(data=data, class_name=self._config.class_name)
5454

5555

5656
def check_model_assumptions_wrapper(
@@ -62,7 +62,7 @@ def check_model_assumptions_wrapper(
6262
ModelAssumptionError:
6363
if the model does not fulfill the assumptions.
6464
"""
65-
check_model_assumptions(model=model, transformation_config=config)
65+
check_model_assumptions(model=model, class_name=config.class_name)
6666

6767

6868
def transform_model(model: SchemaPack, config: DeleteClassConfig) -> SchemaPack:
@@ -72,7 +72,7 @@ def transform_model(model: SchemaPack, config: DeleteClassConfig) -> SchemaPack:
7272
DataModelTransformationError:
7373
if the transformation fails.
7474
"""
75-
return delete_model_class(model=model, transformation_config=config)
75+
return delete_model_class(model=model, class_name=config.class_name)
7676

7777

7878
DELETE_CLASS_TRANSFORMATION = TransformationDefinition[DeleteClassConfig](

src/metldata/builtin_transformations/delete_class/model_transform.py

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,29 +18,22 @@
1818
from schemapack.spec.schemapack import SchemaPack
1919

2020
from metldata.builtin_transformations.common.utils import model_to_dict
21-
from metldata.builtin_transformations.delete_class.config import (
22-
DeleteClassConfig,
23-
)
2421
from metldata.transform.exceptions import EvitableTransformationError
2522

2623

27-
def delete_model_class(
28-
*,
29-
model: SchemaPack,
30-
transformation_config: DeleteClassConfig,
31-
) -> SchemaPack:
24+
def delete_model_class(*, model: SchemaPack, class_name: str) -> SchemaPack:
3225
"""Delete class from the model."""
3326
mutable_model = model_to_dict(model)
3427

3528
try:
36-
del mutable_model["classes"][transformation_config.class_name]
29+
del mutable_model["classes"][class_name]
3730
except KeyError as exc:
3831
raise EvitableTransformationError() from exc
3932

4033
_remove_relations_from_model(
4134
mutable_model=mutable_model,
4235
original_model=model,
43-
target_class=transformation_config.class_name,
36+
target_class=class_name,
4437
)
4538

4639
return SchemaPack.model_validate(mutable_model)

0 commit comments

Comments
 (0)