Skip to content

Commit ead985f

Browse files
authored
release: 2.0.5 (#368)
2 parents 49ead84 + d6ba1e3 commit ead985f

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

src/main/kotlin/org/gitanimals/rank/app/GetRankByUsernameFacade.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package org.gitanimals.rank.app
33
import org.gitanimals.rank.domain.RankQueryRepository
44
import org.gitanimals.rank.domain.UserContributionRankService
55
import org.gitanimals.rank.domain.response.RankResponse
6-
import org.slf4j.LoggerFactory
76
import org.springframework.stereotype.Component
87

98
@Component
@@ -12,8 +11,6 @@ class GetRankByUsernameFacade(
1211
private val rankQueryRepository: RankQueryRepository,
1312
) {
1413

15-
private val logger = LoggerFactory.getLogger(this::class.simpleName)
16-
1714
fun invoke(username: String): RankResponse {
1815
val userContributionRank = userContributionRankService.findUserRankByUsername(username)
1916

src/main/kotlin/org/gitanimals/rank/controller/RankController.kt

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
package org.gitanimals.rank.controller
22

3+
import org.gitanimals.core.ErrorResponse
34
import org.gitanimals.rank.app.GetRankByUsernameFacade
45
import org.gitanimals.rank.app.RankQueryFacade
56
import org.gitanimals.rank.controller.response.RankHistoryResponse
67
import org.gitanimals.rank.controller.response.RankTotalCountResponse
78
import org.gitanimals.rank.domain.RankQueryRepository
89
import org.gitanimals.rank.domain.history.RankHistoryService
910
import org.gitanimals.rank.domain.response.RankResponse
11+
import org.springframework.http.ResponseEntity
1012
import org.springframework.web.bind.annotation.GetMapping
1113
import org.springframework.web.bind.annotation.PathVariable
1214
import org.springframework.web.bind.annotation.RequestParam
@@ -30,7 +32,17 @@ class RankController(
3032
@GetMapping("/ranks/by-username/{username}")
3133
fun findUserRankByUsername(
3234
@PathVariable("username") username: String,
33-
): RankResponse = getRankByUsernameFacade.invoke(username)
35+
): ResponseEntity<out Any> {
36+
return runCatching {
37+
ResponseEntity.ok(getRankByUsernameFacade.invoke(username))
38+
}.getOrElse {
39+
ResponseEntity
40+
.badRequest()
41+
.body(
42+
ErrorResponse("Cannot find rank by username: \"$username\"")
43+
)
44+
}
45+
}
3446

3547
@GetMapping("/ranks/histories")
3648
fun getRankHistoryByRankType(

0 commit comments

Comments
 (0)