Fix task template using "Current logged in user" option

Author: AdrienClairembault

src/CommonITILTask.php

@@ -673,14 +673,19 @@ public function prepareInputForAdd($input)
                 return false;
             }
             $input['tasktemplates_id']  = $input['_tasktemplates_id'];
+            $user = $template->fields['users_id_tech'];
+            if ($user == -1) {
+                $user = Session::getLoginUserID();
+            }
+
             $input = array_replace(
                 [
                     'content'           => $template->getRenderedContent($parent_item),
                     'taskcategories_id' => $template->fields['taskcategories_id'],
                     'actiontime'        => $template->fields['actiontime'],
                     'state'             => $template->fields['state'],
                     'is_private'        => $template->fields['is_private'],
-                    'users_id_tech'     => $template->fields['users_id_tech'],
+                    'users_id_tech'     => $user,
                     'groups_id_tech'    => $template->fields['groups_id_tech'],
                 ],
                 $input

tests/functional/TaskTemplateTest.php

@@ -37,6 +37,9 @@
 use AbstractITILChildTemplate;
 use Glpi\Tests\AbstractITILChildTemplateTest;
 use TaskTemplate;
+use Ticket;
+use TicketTask;
+use User;
 
 class TaskTemplateTest extends AbstractITILChildTemplateTest
 {
@@ -167,4 +170,32 @@ public function testSearchAbility()
         $condition = TaskTemplate::addWhere('AND', 0, TaskTemplate::class, 7, 'equals', 0);
         $this->assertEquals(' AND (`glpi_tasktemplates`.`use_current_user` = 0 AND `glpi_tasktemplates`.`users_id_tech` = 0)', $condition);
     }
+
+    public function testTemplateWithCurrentUserAsAuthor(): void
+    {
+        // Arrange: create a task template with the "current user" as author
+        $template = $this->createItem(TaskTemplate::class, [
+            'name' => 'my template',
+            'content' => '<p>test</p>',
+            'users_id_tech' => -1,
+        ]);
+
+        // Act: use the template to create a ticket with this task
+        $this->login();
+        $ticket = $this->createItem(Ticket::class, [
+            'name' => 'My ticket',
+            'content' => 'My content',
+            '_tasktemplates_id' => [$template->getID()],
+        ]);
+
+        // Assert: task is created with the current user
+        $task = new TicketTask();
+        $task->getFromDBByCrit([
+            'tickets_id' => $ticket->getID(),
+        ]);
+        $this->assertEquals(
+            getItemByTypeName(User::class, TU_USER, true),
+            $task->fields['users_id_tech']
+        );
+    }
 }