common-utils.c: fix clang warning

Fix:
common-utils.c:1590:10: warning: implicit conversion from 'unsigned long' to 'double' changes value from 18446744073709551615 to 18446744073709551616 [-Wimplicit-const-int-float-conversion]
 1590 |     if ((UINT64_MAX - value) < 0) {
      |          ^~~~~~~~~~ ~
/usr/include/stdint.h:119:23: note: expanded from macro 'UINT64_MAX'
  119 | # define UINT64_MAX             (__UINT64_C(18446744073709551615))
      |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/stdint.h:96:25: note: expanded from macro '__UINT64_C'
   96 | #  define __UINT64_C(c) c ## UL
      |                         ^~~~~~~
<scratch space>:38:1: note: expanded from here
   38 | 18446744073709551615UL
      | ^~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Yaniv Kaul <[email protected]>

Author: mykaul

libglusterfs/src/common-utils.c

@@ -1587,7 +1587,7 @@ gf_string2percent_or_bytesize(const char *str, double *n,
     }
 
     /* Error out if we cannot store the value in uint64 */
-    if ((UINT64_MAX - value) < 0) {
+    if ((UINT64_MAX - (unsigned long)value) < 0) {
         errno = ERANGE;
         return -1;
     }