Merge pull request #1991 from gmx-io/hotfix-earn-page-metrics

Hotfix update earn page metrics

Author: qwinndev

src/App/AppRoutes.tsx

@@ -16,6 +16,7 @@ import { REFERRAL_CODE_QUERY_PARAM, getAppBaseUrl } from "lib/legacy";
 import { useAccountInitedMetric, useOpenAppMetric } from "lib/metrics";
 import { useConfigureMetrics } from "lib/metrics/useConfigureMetrics";
 import { useHashQueryParams } from "lib/useHashQueryParams";
+import { sendEarnPageViewEvent } from "lib/userAnalytics/earnEvents";
 import { useConfigureUserAnalyticsProfile } from "lib/userAnalytics/useConfigureUserAnalyticsProfile";
 import { useWalletConnectedUserAnalyticsEvent } from "lib/userAnalytics/useWalletConnectedEvent";
 import useRouteQuery from "lib/useRouteQuery";
@@ -114,6 +115,13 @@ export function AppRoutes() {
     }
   }, [urlParams, history]);
 
+  const isEarnPage = history.location.pathname.startsWith("/earn");
+  useEffect(() => {
+    if (isEarnPage) {
+      sendEarnPageViewEvent();
+    }
+  }, [isEarnPage]);
+
   useRealChainIdWarning();
   useNonEoaAccountChainWarning();
 

src/lib/userAnalytics/earnEvents.ts

@@ -4,9 +4,7 @@ export type EarnAnalyticsTab = "discover" | "portfolio" | "additionalOpportuniti
 
 export type EarnPageViewEvent = {
   event: "EarnPageView";
-  data: {
-    tab: EarnAnalyticsTab;
-  };
+  data: {};
 };
 
 export type EarnPageActionEvent = {
@@ -20,7 +18,7 @@ export type EarnPageActionEvent = {
 export type EarnRecommendationContext = "AboutTokens" | "YieldLandscape" | "PortfolioRecommendations";
 export type EarnRecommendationToken = "GM" | "GLV" | "GMX";
 export type EarnPageRecommendationClickedEvent = {
-  event: "EarnPage";
+  event: "EarnPageAction";
   data: {
     action: "RecommendationClicked";
     activeTab: EarnAnalyticsTab;
@@ -32,7 +30,7 @@ export type EarnPageRecommendationClickedEvent = {
 export type EarnPagePortfolioItem = "GMX" | "esGMX" | "GLV" | "GM";
 export type EarnPagePortfolioItemType = "stake" | "vest" | "buy" | "sell" | "details";
 export type EarnPagePortfolioItemClickEvent = {
-  event: "EarnPage";
+  event: "EarnPageAction";
   data: {
     action: "PortfolioItemClick";
     item: EarnPagePortfolioItem;
@@ -50,27 +48,25 @@ export type EarnPageOpportunitiesAnalyticsFilter =
   | "YieldTrading";
 
 export type EarnPageOpportunitiesFilterAppliedEvent = {
-  event: "EarnPage";
+  event: "EarnPageAction";
   data: {
     action: "OpportunitiesFilterApplied";
     filter: EarnPageOpportunitiesAnalyticsFilter;
   };
 };
 
 export type EarnPageOpportunityClickedEvent = {
-  event: "EarnPage";
+  event: "EarnPageAction";
   data: {
     action: "OpportunityClicked";
     name: string;
   };
 };
 
-export function sendEarnPageViewEvent(tab: EarnAnalyticsTab) {
+export function sendEarnPageViewEvent() {
   userAnalytics.pushEvent<EarnPageViewEvent>({
     event: "EarnPageView",
-    data: {
-      tab,
-    },
+    data: {},
   });
 }
 
@@ -94,7 +90,7 @@ export function sendEarnRecommendationClickedEvent({
   token: EarnRecommendationToken;
 }) {
   userAnalytics.pushEvent<EarnPageRecommendationClickedEvent>({
-    event: "EarnPage",
+    event: "EarnPageAction",
     data: {
       action: "RecommendationClicked",
       activeTab,
@@ -112,7 +108,7 @@ export function sendEarnPortfolioItemClickEvent({
   type: EarnPagePortfolioItemType;
 }) {
   userAnalytics.pushEvent<EarnPagePortfolioItemClickEvent>({
-    event: "EarnPage",
+    event: "EarnPageAction",
     data: {
       action: "PortfolioItemClick",
       item,
@@ -123,7 +119,7 @@ export function sendEarnPortfolioItemClickEvent({
 
 export function sendEarnOpportunitiesFilterAppliedEvent(filter: EarnPageOpportunitiesAnalyticsFilter) {
   userAnalytics.pushEvent<EarnPageOpportunitiesFilterAppliedEvent>({
-    event: "EarnPage",
+    event: "EarnPageAction",
     data: {
       action: "OpportunitiesFilterApplied",
       filter,
@@ -133,7 +129,7 @@ export function sendEarnOpportunitiesFilterAppliedEvent(filter: EarnPageOpportun
 
 export function sendEarnOpportunityClickedEvent(name: string) {
   userAnalytics.pushEvent<EarnPageOpportunityClickedEvent>({
-    event: "EarnPage",
+    event: "EarnPageAction",
     data: {
       action: "OpportunityClicked",
       name,

src/pages/Earn/EarnPageLayout.tsx

@@ -4,7 +4,7 @@ import { useLocation } from "react-router-dom";
 
 import { LAST_EARN_TAB_KEY } from "config/localStorage";
 import { useLocalStorageSerializeKey } from "lib/localStorage";
-import { sendEarnPageTabViewEvent, sendEarnPageViewEvent, EarnAnalyticsTab } from "lib/userAnalytics/earnEvents";
+import { sendEarnPageTabViewEvent, EarnAnalyticsTab } from "lib/userAnalytics/earnEvents";
 
 import AppPageLayout from "components/AppPageLayout/AppPageLayout";
 import Button from "components/Button/Button";
@@ -73,7 +73,6 @@ export default function EarnPageLayout({ children }: EarnPageLayoutProps) {
       return;
     }
 
-    sendEarnPageViewEvent(analyticsTab);
     sendEarnPageTabViewEvent(analyticsTab);
   }, [analyticsTab]);