Skip to content

fix(ci): run gno test / lint on stdlibs#4756

Merged
gfanton merged 16 commits intognolang:masterfrom
gfanton:fix/ci-stdlibs
Sep 12, 2025
Merged

fix(ci): run gno test / lint on stdlibs#4756
gfanton merged 16 commits intognolang:masterfrom
gfanton:fix/ci-stdlibs

Conversation

@gfanton
Copy link
Member

@gfanton gfanton commented Sep 12, 2025

Correctly run the CI in the stdlibs directory.

This PR also adds a -C flag to gno, similar to the one in go, to change the directory before executing any command.

Waiting on #4751

@github-actions github-actions bot added 📦 🤖 gnovm Issues or PRs gnovm related 🚀 ci labels Sep 12, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Sep 12, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: gfanton/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

❌ Patch coverage is 68.42105% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gnovm/cmd/gno/main.go 68.42% 9 Missing and 3 partials ⚠️

📢 Thoughts on this report? Let us know!

@gfanton gfanton marked this pull request as ready for review September 12, 2025 08:52
@gfanton gfanton changed the title fix(ci): run gno test on stdlibs fix(ci): run gno test / lint on stdlibs Sep 12, 2025
Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This improves the current situation, though as I said elsewhere I think we should remove gno test ./stdlibs/... and test it into TestStdlibs.

Anyway, it solves an ongoing problem, so 👍 for merging.

@gfanton
Copy link
Member Author

gfanton commented Sep 12, 2025

I think we should remove gno test ./stdlibs/... and test it into TestStdlibs.

That makes sense, but honestly, in my opinion we should have both in separate jobs. Even if it seems a bit unnecessary, I feel it make sense to be able to test and run gno test on stdlibs as an integration tests.

@gfanton gfanton merged commit cc9fbe1 into gnolang:master Sep 12, 2025
106 of 107 checks passed
@gfanton gfanton deleted the fix/ci-stdlibs branch September 12, 2025 11:47
@github-project-automation github-project-automation bot moved this from In Progress to Done in 💪 Bounties & Worx Sep 12, 2025
gfanton added a commit to gfanton/gno that referenced this pull request Oct 10, 2025
Correctly run the CI in the `stdlibs` directory. 

This PR also adds a `-C` flag to `gno`, similar to the one in `go`, to
change the directory before executing any command.

Waiting on gnolang#4751

---------

Co-authored-by: Morgan <morgan@morganbaz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚀 ci 📦 🤖 gnovm Issues or PRs gnovm related

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants