Implement alternative security #134
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbinet
requested changes
Nov 6, 2022
Contributor
sbinet
left a comment
sbinet
left a comment
There was a problem hiding this comment.
apologies for the belated reply.
is the "NOTBAD" security protocol described in the official ZMQ document ?
we try to follow that document to retain compatibility with the official ZMQ implementation(s)
Author
|
I was looking at implementing a curve type security mechanism. Not bad is a made up security. I struggled with this because the frame size is calculated before Encrypt is called. I should clean this PR up and possibly implement curve and see if I run into the same issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found that encrypting the body before the headers and size are calculated makes implementing an alternate security much easier.