From 47dfaa4836550991517f43f77ee4148f9909b587 Mon Sep 17 00:00:00 2001 From: Raz Luvaton Date: Wed, 27 Oct 2021 20:05:43 +0300 Subject: [PATCH 1/2] fix(example-application): use throw instead of (missing) reject --- example-application/entry-points/message-queue-starter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/example-application/entry-points/message-queue-starter.js b/example-application/entry-points/message-queue-starter.js index e796cdb0..695eb149 100644 --- a/example-application/entry-points/message-queue-starter.js +++ b/example-application/entry-points/message-queue-starter.js @@ -21,7 +21,7 @@ class MessageQueueStarter { const newMessageAsObject = JSON.parse(message); // ️️️✅ Best Practice: Validate incoming MQ messages using your validator framework (simplistic implementation below) if (!newMessageAsObject.id) { - return reject(new AppError('invalid-message', true)); + return throw new AppError('invalid-message', true); } const orderRepository = new OrderRepository(); From e182b4a0716a9459fb606f10561d03001107507f Mon Sep 17 00:00:00 2001 From: Raz Luvaton Date: Wed, 27 Oct 2021 20:08:37 +0300 Subject: [PATCH 2/2] =?UTF-8?q?fix(example-application):=20remove=20return?= =?UTF-8?q?=20before=20throw=20=F0=9F=A4=A6=E2=80=8D=E2=99=82=EF=B8=8F?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- example-application/entry-points/message-queue-starter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/example-application/entry-points/message-queue-starter.js b/example-application/entry-points/message-queue-starter.js index 695eb149..e8ed4be1 100644 --- a/example-application/entry-points/message-queue-starter.js +++ b/example-application/entry-points/message-queue-starter.js @@ -21,7 +21,7 @@ class MessageQueueStarter { const newMessageAsObject = JSON.parse(message); // ️️️✅ Best Practice: Validate incoming MQ messages using your validator framework (simplistic implementation below) if (!newMessageAsObject.id) { - return throw new AppError('invalid-message', true); + throw new AppError('invalid-message', true); } const orderRepository = new OrderRepository();