-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Added Authentication notebook for JS
#1021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Added Authentication notebook for JS
#1021
Conversation
Summary of ChangesHello @Rahul-Lashkari, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new JavaScript quickstart guide that educates users on how to securely set up and use API keys for authenticating with the Gemini API. It emphasizes the importance of environment variables for key storage and demonstrates how to configure the SDK, thereby expanding the existing JavaScript quickstart documentation. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a JavaScript equivalent of the Authentication notebook and updates the main README for JS quickstarts. The changes are well-structured and follow the established format for JS notebooks in this repository. My feedback focuses on improving the JavaScript code by using modern variable declarations (const) to avoid implicit globals, which enhances code safety and maintainability. I've also included a couple of minor suggestions to align the markdown content with the repository's style guide and improve readability.
| /* Markdown (render) | ||
| ## Learning more | ||
|
|
||
| Now that you know how to manage your API key, you have everything you need to [get started](./Get_Started.js) with Gemini. Check all the [quickstart guides](https://github.com/google-gemini/cookbook/tree/main/quickstarts-js) in the Cookbook, and in particular the [Get Started](./Get_Started.js) guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence links to the "Get Started" guide twice, which is a bit redundant. For better readability and conciseness, you could rephrase it to mention each guide only once. For example:
"Now that you know how to manage your API key, you have everything you need to get started with Gemini. Check out the Get Started guide and the other quickstart guides in the Cookbook."
quickstarts/Authentication.ipynbnotebookquickstarts-js/README.md