Delete unused field CodingConvention#getIndirectlyDeclaredProperties

This seems to have been added for some "global name" related check, that we've since deleted.

PiperOrigin-RevId: 867706277

Author: lauraharker

src/com/google/javascript/jscomp/ChromeCodingConvention.java

@@ -15,8 +15,6 @@
  */
 package com.google.javascript.jscomp;
 
-import com.google.common.collect.ImmutableCollection;
-import com.google.common.collect.ImmutableSet;
 import com.google.errorprone.annotations.Immutable;
 import com.google.javascript.rhino.Node;
 import com.google.javascript.rhino.NominalTypeBuilder;
@@ -26,19 +24,13 @@
 /** Coding convention used by the Chrome team to compile Chrome's JS. */
 @Immutable
 public final class ChromeCodingConvention extends CodingConventions.Proxy {
-  private final ImmutableSet<String> indirectlyDeclaredProperties;
 
   public ChromeCodingConvention() {
     this(CodingConventions.getDefault());
   }
 
   public ChromeCodingConvention(CodingConvention wrapped) {
     super(wrapped);
-    indirectlyDeclaredProperties =
-        new ImmutableSet.Builder<String>()
-            .add("instance_", "getInstance")
-            .addAll(wrapped.getIndirectlyDeclaredProperties())
-            .build();
   }
 
   private static final QualifiedName CR_ADD_SINGLETON_GETTER =
@@ -59,9 +51,4 @@ public void applySingletonGetter(NominalTypeBuilder classType, FunctionType gett
     classType.declareConstructorProperty("getInstance", getterType, defSite);
     classType.declareConstructorProperty("instance_", classType.instance(), defSite);
   }
-
-  @Override
-  public ImmutableCollection<String> getIndirectlyDeclaredProperties() {
-    return indirectlyDeclaredProperties;
-  }
 }

src/com/google/javascript/jscomp/ClosureCodingConvention.java

@@ -42,22 +42,12 @@ public final class ClosureCodingConvention extends CodingConventions.Proxy {
       "JSC_REFLECT_OBJECTLIT_EXPECTED",
       "Object literal expected as second argument");
 
-  private final ImmutableSet<String> indirectlyDeclaredProperties;
-
   public ClosureCodingConvention() {
     this(CodingConventions.getDefault());
   }
 
   public ClosureCodingConvention(CodingConvention wrapped) {
     super(wrapped);
-
-    ImmutableSet.Builder<String> props = ImmutableSet.builder();
-    props.add(
-        "superClass_",
-        "instance_",
-        "getInstance");
-    props.addAll(wrapped.getIndirectlyDeclaredProperties());
-    indirectlyDeclaredProperties = props.build();
   }
 
   /**
@@ -454,11 +444,6 @@ private boolean matchesCacheMethodName(Node target) {
     return false;
   }
 
-  @Override
-  public ImmutableSet<String> getIndirectlyDeclaredProperties() {
-    return indirectlyDeclaredProperties;
-  }
-
   private static @Nullable Node safeNext(Node n) {
     if (n != null) {
       return n.getNext();

src/com/google/javascript/jscomp/CodingConvention.java

@@ -328,13 +328,6 @@ public Cache(Node cacheObj, Node key, Node valueFn, Node keyFn) {
    */
   public ObjectLiteralCast getObjectLiteralCast(Node callNode);
 
-  /**
-   * Gets a collection of all properties that are defined indirectly on global
-   * objects. (For example, Closure defines superClass_ in the goog.inherits
-   * call).
-   */
-  public Collection<String> getIndirectlyDeclaredProperties();
-
   /**
    * Returns the set of AssertionFunction.
    */

src/com/google/javascript/jscomp/CodingConventions.java

@@ -229,11 +229,6 @@ public boolean isPrototypeAlias(Node getProp) {
     public ObjectLiteralCast getObjectLiteralCast(Node callNode) {
       return nextConvention.getObjectLiteralCast(callNode);
     }
-
-    @Override
-    public Collection<String> getIndirectlyDeclaredProperties() {
-      return nextConvention.getIndirectlyDeclaredProperties();
-    }
   }
 
 
@@ -470,11 +465,6 @@ public Cache describeCachingCall(Node node) {
       return null;
     }
 
-    @Override
-    public Collection<String> getIndirectlyDeclaredProperties() {
-      return ImmutableList.of();
-    }
-
     private static @Nullable Node safeNext(Node n) {
       if (n != null) {
         return n.getNext();