From b20cfef5dce41322cac7867597c8b7a94b25ac12 Mon Sep 17 00:00:00 2001 From: Cody Ebberson Date: Tue, 15 Aug 2023 14:59:46 -0700 Subject: [PATCH 1/2] Added BaseRenderingContext2D.prototype.roundRect --- externs/browser/html5.js | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/externs/browser/html5.js b/externs/browser/html5.js index cd7184cd930..220bcd41472 100644 --- a/externs/browser/html5.js +++ b/externs/browser/html5.js @@ -362,6 +362,17 @@ Path2D.prototype.arcTo = function(x1, y1, x2, y2, radius) {}; */ Path2D.prototype.rect = function(x, y, w, h) {}; +/** + * @param {number} x + * @param {number} y + * @param {number} w + * @param {number} h + * @param {(number|DOMPointInit|Array)=} radii + * @return {undefined} + * @override + */ +Path2D.prototype.roundRect = function(x, y, w, h, radii) {}; + /** * @param {number} x * @param {number} y @@ -660,6 +671,16 @@ BaseRenderingContext2D.prototype.arcTo = function(x1, y1, x2, y2, radius) {}; */ BaseRenderingContext2D.prototype.rect = function(x, y, w, h) {}; +/** + * @param {number} x + * @param {number} y + * @param {number} w + * @param {number} h + * @param {number|DOMPointInit|Array} radii + * @return {undefined} + */ +BaseRenderingContext2D.prototype.roundRect = function(x, y, w, h, radii) {}; + /** * @param {number} x * @param {number} y From 2a927ad335bf298ed86fac1a7a20e886df5e105a Mon Sep 17 00:00:00 2001 From: Cody Ebberson Date: Fri, 29 Sep 2023 09:05:14 -0700 Subject: [PATCH 2/2] PR feedback --- externs/browser/html5.js | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/externs/browser/html5.js b/externs/browser/html5.js index 220bcd41472..ef9b9bc63f4 100644 --- a/externs/browser/html5.js +++ b/externs/browser/html5.js @@ -277,6 +277,16 @@ CanvasPathMethods.prototype.arcTo = function(x1, y1, x2, y2, radius) {}; */ CanvasPathMethods.prototype.rect = function(x, y, w, h) {}; +/** + * @param {number} x + * @param {number} y + * @param {number} w + * @param {number} h + * @param {(number|DOMPointInit|Array)=} radii + * @return {undefined} + */ +CanvasPathMethods.prototype.roundRect = function(x, y, w, h, radii) {}; + /** * @param {number} x * @param {number} y @@ -367,7 +377,7 @@ Path2D.prototype.rect = function(x, y, w, h) {}; * @param {number} y * @param {number} w * @param {number} h - * @param {(number|DOMPointInit|Array)=} radii + * @param {(number|DOMPointInit|Array)=} radii * @return {undefined} * @override */ @@ -676,8 +686,9 @@ BaseRenderingContext2D.prototype.rect = function(x, y, w, h) {}; * @param {number} y * @param {number} w * @param {number} h - * @param {number|DOMPointInit|Array} radii + * @param {(number|DOMPointInit|Array)=} radii * @return {undefined} + * @override */ BaseRenderingContext2D.prototype.roundRect = function(x, y, w, h, radii) {};