Enable MSVC builds in CI

This also refactors how cflags are propageted somewhat.

Author: mcy

.github/workflows/ci.yml

@@ -34,16 +34,26 @@ jobs:
     - uses: actions/checkout@v2
 
     - name: bazel build
-      run: CC=clang bazel build //...
+      run: CC=clang bazel build --verbose_failures //...
     - name: bazel test
-      run: CC=clang bazel test //...
+      run: CC=clang bazel test --verbose_failures --test_output=streamed //...
 
   gcc-tests:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v2
 
     - name: bazel build
-      run: CC=gcc bazel build //...
+      run: CC=gcc bazel build --verbose_failures //...
     - name: bazel test
-      run: CC=gcc bazel test //...
+      run: CC=gcc bazel test --verbose_failures --test_output=streamed //...
+
+  msvc-tests:
+    runs-on: windows-2022
+    steps:
+    - uses: actions/checkout@v2
+
+    - name: bazel build
+      run: bazel.exe build --verbose_failures //...
+    - name: bazel test
+      run: bazel.exe test --verbose_failures --test_output=streamed //...

BUILD

@@ -13,13 +13,13 @@
 # limitations under the License.
 
 load(
-    "//:copts.bzl",
-    "CWISS_DEFAULT_COPTS",
-    "CWISS_DEFAULT_LINKOPTS",
-    "CWISS_SAN_COPTS",
-    "CWISS_TEST_COPTS",
-    "CWISS_C_VERSION",
-    "CWISS_CXX_VERSION",
+    "//toolchain:copts.bzl",
+    "DEFAULT_COPTS",
+    "DEFAULT_LINKOPTS",
+    "SAN_COPTS",
+    "TEST_COPTS",
+    "C_VERSION",
+    "CXX_VERSION",
 )
 
 filegroup(
@@ -49,8 +49,8 @@ cc_library(
     name = "cwisstable_split",
     hdrs = [":public_headers"],
     srcs = [":private_headers"],
-    copts = CWISS_DEFAULT_COPTS + CWISS_C_VERSION,
-    linkopts = CWISS_DEFAULT_LINKOPTS,
+    copts = DEFAULT_COPTS + C_VERSION,
+    linkopts = DEFAULT_LINKOPTS,
     visibility = ["//visibility:public"],
 )
 
@@ -74,26 +74,26 @@ genrule(
 cc_library(
     name = "cwisstable",
     hdrs = ["cwisstable.h"],
-    copts = CWISS_DEFAULT_COPTS + CWISS_C_VERSION,
-    linkopts = CWISS_DEFAULT_LINKOPTS,
+    copts = DEFAULT_COPTS + C_VERSION,
+    linkopts = DEFAULT_LINKOPTS,
     visibility = ["//visibility:public"],
 )
 
 cc_library(
     name = "debug",
     hdrs = ["cwisstable/internal/debug.h"],
     srcs = ["cwisstable/internal/debug.cc"],
-    copts = CWISS_DEFAULT_COPTS + CWISS_CXX_VERSION,
-    linkopts = CWISS_DEFAULT_LINKOPTS,
+    copts = DEFAULT_COPTS + CXX_VERSION,
+    linkopts = DEFAULT_LINKOPTS,
     deps = [":cwisstable"],
     visibility = ["//:__subpackages__"],
 )
 
 cc_library(
     name = "test_helpers",
     hdrs = ["cwisstable/internal/test_helpers.h"],
-    copts = CWISS_DEFAULT_COPTS + CWISS_CXX_VERSION,
-    linkopts = CWISS_DEFAULT_LINKOPTS,
+    copts = DEFAULT_COPTS + CXX_VERSION,
+    linkopts = DEFAULT_LINKOPTS,
     deps = ["//:cwisstable"],
     visibility = ["//:__subpackages__"],
 )
@@ -109,8 +109,8 @@ cc_test(
         "@com_google_absl//absl/cleanup",
         "@com_google_googletest//:gtest_main",
     ],
-    copts = CWISS_TEST_COPTS + CWISS_CXX_VERSION + CWISS_SAN_COPTS,
-    linkopts = CWISS_DEFAULT_LINKOPTS + CWISS_SAN_COPTS,
+    copts = TEST_COPTS + CXX_VERSION + SAN_COPTS,
+    linkopts = DEFAULT_LINKOPTS + SAN_COPTS,
 )
 
 cc_test(
@@ -128,8 +128,8 @@ cc_test(
         "CWISS_HAVE_SSE2=0",
         "CWISS_HAVE_SSSE3=0",
     ],
-    copts = CWISS_TEST_COPTS + CWISS_CXX_VERSION + CWISS_SAN_COPTS,
-    linkopts = CWISS_DEFAULT_LINKOPTS + CWISS_SAN_COPTS,
+    copts = TEST_COPTS + CXX_VERSION + SAN_COPTS,
+    linkopts = DEFAULT_LINKOPTS + SAN_COPTS,
 )
 
 
@@ -146,25 +146,7 @@ cc_binary(
         "@com_google_absl//absl/strings:str_format",
         "@com_github_google_benchmark//:benchmark_main",
     ],
-    copts = CWISS_TEST_COPTS + CWISS_CXX_VERSION,
-    linkopts = CWISS_DEFAULT_LINKOPTS,
+    copts = TEST_COPTS + CXX_VERSION,
+    linkopts = DEFAULT_LINKOPTS,
     testonly = 1,
-)
-
-config_setting(
-    name = "clang_compiler",
-    flag_values = {"@bazel_tools//tools/cpp:compiler": "clang"},
-    visibility = [":__subpackages__"],
-)
-
-config_setting(
-    name = "msvc_compiler",
-    flag_values = {"@bazel_tools//tools/cpp:compiler": "mscv-cl"},
-    visibility = [":__subpackages__"],
-)
-
-config_setting(
-    name = "clang-cl_compiler",
-    flag_values = {"@bazel_tools//tools/cpp:compiler": "clang-cl"},
-    visibility = [":__subpackages__"],
 )

examples/BUILD

@@ -13,80 +13,80 @@
 # limitations under the License.
 
 load(
-    "//:copts.bzl",
-    "CWISS_DEFAULT_COPTS",
-    "CWISS_DEFAULT_LINKOPTS",
-    "CWISS_C_VERSION",
+    "//toolchain:copts.bzl",
+    "DEFAULT_COPTS",
+    "DEFAULT_LINKOPTS",
+    "C_VERSION",
 )
 
 cc_binary(
     name = "arraymap",
     srcs = ["arraymap.c"],
     deps = ["//:cwisstable"],
-    copts = CWISS_DEFAULT_COPTS + CWISS_C_VERSION,
-    linkopts = CWISS_DEFAULT_LINKOPTS,
+    copts = DEFAULT_COPTS + C_VERSION,
+    linkopts = DEFAULT_LINKOPTS,
     defines = ["CWISS_EXAMPLE_UNIFIED"],
 )
 
 cc_binary(
     name = "arraymap_split",
     srcs = ["arraymap.c"],
     deps = ["//:cwisstable_split"],
-    copts = CWISS_DEFAULT_COPTS + CWISS_C_VERSION,
-    linkopts = CWISS_DEFAULT_LINKOPTS,
+    copts = DEFAULT_COPTS + C_VERSION,
+    linkopts = DEFAULT_LINKOPTS,
     defines = ["CWISS_EXAMPLE_SPLIT"],
 )
 
 cc_binary(
     name = "hashset",
     srcs = ["hashset.c"],
     deps = ["//:cwisstable"],
-    copts = CWISS_DEFAULT_COPTS + CWISS_C_VERSION,
-    linkopts = CWISS_DEFAULT_LINKOPTS,
+    copts = DEFAULT_COPTS + C_VERSION,
+    linkopts = DEFAULT_LINKOPTS,
     defines = ["CWISS_EXAMPLE_UNIFIED"],
 )
 
 cc_binary(
     name = "hashset_split",
     srcs = ["hashset.c"],
     deps = ["//:cwisstable_split"],
-    copts = CWISS_DEFAULT_COPTS + CWISS_C_VERSION,
-    linkopts = CWISS_DEFAULT_LINKOPTS,
+    copts = DEFAULT_COPTS + C_VERSION,
+    linkopts = DEFAULT_LINKOPTS,
     defines = ["CWISS_EXAMPLE_SPLIT"],
 )
 
 cc_binary(
     name = "hashmap",
     srcs = ["hashmap.c"],
     deps = ["//:cwisstable"],
-    copts = CWISS_DEFAULT_COPTS + CWISS_C_VERSION,
-    linkopts = CWISS_DEFAULT_LINKOPTS,
+    copts = DEFAULT_COPTS + C_VERSION,
+    linkopts = DEFAULT_LINKOPTS,
     defines = ["CWISS_EXAMPLE_UNIFIED"],
 )
 
 cc_binary(
     name = "hashmap_split",
     srcs = ["hashmap.c"],
     deps = ["//:cwisstable_split"],
-    copts = CWISS_DEFAULT_COPTS + CWISS_C_VERSION,
-    linkopts = CWISS_DEFAULT_LINKOPTS,
+    copts = DEFAULT_COPTS + C_VERSION,
+    linkopts = DEFAULT_LINKOPTS,
     defines = ["CWISS_EXAMPLE_SPLIT"],
 )
 
 cc_binary(
     name = "stringmap",
     srcs = ["stringmap.c"],
     deps = ["//:cwisstable"],
-    copts = CWISS_DEFAULT_COPTS + CWISS_C_VERSION,
-    linkopts = CWISS_DEFAULT_LINKOPTS,
+    copts = DEFAULT_COPTS + C_VERSION,
+    linkopts = DEFAULT_LINKOPTS,
     defines = ["CWISS_EXAMPLE_UNIFIED"],
 )
 
 cc_binary(
     name = "stringmap_split",
     srcs = ["stringmap.c"],
     deps = ["//:cwisstable_split"],
-    copts = CWISS_DEFAULT_COPTS + CWISS_C_VERSION,
-    linkopts = CWISS_DEFAULT_LINKOPTS,
+    copts = DEFAULT_COPTS + C_VERSION,
+    linkopts = DEFAULT_LINKOPTS,
     defines = ["CWISS_EXAMPLE_SPLIT"],
 )

toolchain/BUILD

@@ -0,0 +1,30 @@
+# Copyright 2022 Google LLC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+exports_files(["copts.bzl"])
+
+config_setting(
+    name = "is_clang",
+    flag_values = {"@bazel_tools//tools/cpp:compiler": "clang"},
+)
+
+config_setting(
+    name = "is_msvc",
+    flag_values = {"@bazel_tools//tools/cpp:compiler": "msvc-cl"},
+)
+
+config_setting(
+    name = "is_clang_cl",
+    flag_values = {"@bazel_tools//tools/cpp:compiler": "clang-cl"},
+)