metrics/vocabulary: err check before Close() (#425)

alrs · web-flow · commit bf7795ed1fff · 2024-02-29T14:42:09.000-08:00
diff --git a/metrics/vocabulary/vocabulary.go b/metrics/vocabulary/vocabulary.go
@@ -43,10 +43,11 @@ func WriteCSV(v *metrics.Vocabulary, filename string) error {
 		filename = "vocabulary-operation.csv"
 	}
 	f4, ferror := os.Create(filename)
-	defer f4.Close()
 	if ferror != nil {
 		return ferror
 	}
+	defer f4.Close()
+
 	for _, s := range v.Schemas {
 		temp := fmt.Sprintf("%s,\"%s\",%d\n", "schemas", s.Word, int(s.Count))
 		f4.WriteString(temp)

Original file line number	Diff line number	Diff line change
`@@ -43,10 +43,11 @@ func WriteCSV(v *metrics.Vocabulary, filename string) error {`
`43`	`43`	`filename = "vocabulary-operation.csv"`
`44`	`44`	`}`
`45`	`45`	`f4, ferror := os.Create(filename)`
`46`		`- defer f4.Close()`
`47`	`46`	`if ferror != nil {`
`48`	`47`	`return ferror`
`49`	`48`	`}`
	`49`	`+ defer f4.Close()`
	`50`	`+`
`50`	`51`	`for _, s := range v.Schemas {`
`51`	`52`	`temp := fmt.Sprintf("%s,\"%s\",%d\n", "schemas", s.Word, int(s.Count))`
`52`	`53`	`f4.WriteString(temp)`