fix(pubsub): Remove get_topic lookup when publishing via lazy loading (#32273)

Co-authored-by: Yoshi Automation Bot <[email protected]>

Author: aandreassa

google-cloud-pubsub/lib/google/cloud/pubsub/publisher.rb

@@ -213,7 +213,7 @@ def reload!
         #
         def publish data = nil, attributes = nil, ordering_key: nil, compress: nil, compression_bytes_threshold: nil,
                     **extra_attrs, &block
-          ensure_grpc!
+          ensure_service!
           batch = BatchPublisher.new data,
                                      attributes,
                                      ordering_key,
@@ -337,7 +337,7 @@ def publish data = nil, attributes = nil, ordering_key: nil, compress: nil, comp
         #   publisher.async_publisher.stop!
         #
         def publish_async data = nil, attributes = nil, ordering_key: nil, **extra_attrs, &callback
-          ensure_grpc!
+          ensure_service!
           @async_publisher ||= AsyncPublisher.new name, service, **@async_opts
           @async_publisher.publish data, attributes, ordering_key: ordering_key, **extra_attrs, &callback
         end
@@ -415,13 +415,6 @@ def self.from_name name, service, options = {}
         def ensure_service!
           raise "Must have active connection to service" unless service
         end
-
-        ##
-        # Ensures a Google::Cloud::PubSub::V1::Topic object exists.
-        def ensure_grpc!
-          ensure_service!
-          reload! if reference?
-        end
       end
     end
 

google-cloud-pubsub/test/google/cloud/pubsub/publisher_test.rb

@@ -154,18 +154,14 @@
     mock.verify
   end
 
-  it "reloads the resource when publishing if created with skip_lookup: true" do
+  it "does not reload the resource when publishing if created with skip_lookup: true" do
     mock = Minitest::Mock.new
     pubsub.service.mocked_topic_admin = mock
 
     publisher = pubsub.publisher topic_name, skip_lookup: true
 
     _(publisher).must_be :reference?
 
-    mock.expect :get_topic, Google::Cloud::PubSub::V1::Topic.new(topic_hash(topic_name)) do |actual_topic|
-      actual_topic == {topic: topic_path(topic_name)}
-    end
-
     # Expect publish to be called
     message = "new-message-here"
     encoded_msg = message.encode(Encoding::ASCII_8BIT)
@@ -181,7 +177,7 @@
 
     msg = publisher.publish message
 
-    _(publisher).wont_be :reference?
+    _(publisher).must_be :reference?
     _(msg.message_id).must_equal "msg1"
 
     mock.verify