chore: Add gcp resource name span attribute

Author: surbhigarg92

google/cloud/spanner_v1/_opentelemetry_tracing.py

@@ -106,6 +106,7 @@ def trace_call(
         "gcp.client.service": "spanner",
         "gcp.client.version": TRACER_VERSION,
         "gcp.client.repo": "googleapis/python-spanner",
+        "gcp.resource.name": "//spanner.googleapis.com/" + db_name,
     }
 
     if extra_attributes:

tests/system/test_session_api.py

@@ -361,6 +361,7 @@ def _make_attributes(db_instance, **kwargs):
         "gcp.client.service": "spanner",
         "gcp.client.version": ot_helpers.LIB_VERSION,
         "gcp.client.repo": "googleapis/python-spanner",
+        "gcp.resource.name": "//spanner.googleapis.com/" + db_instance,
     }
     ot_helpers.enrich_with_otel_scope(attributes)
 

tests/unit/test__opentelemetry_tracing.py

@@ -52,6 +52,7 @@ def test_trace_call(self, mock_region):
                 "gcp.client.service": "spanner",
                 "gcp.client.version": LIB_VERSION,
                 "gcp.client.repo": "googleapis/python-spanner",
+                "gcp.resource.name": "//spanner.googleapis.com/database_name",
             }
         )
         expected_attributes.update(extra_attributes)
@@ -87,6 +88,7 @@ def test_trace_error(self, mock_region):
                 "gcp.client.service": "spanner",
                 "gcp.client.version": LIB_VERSION,
                 "gcp.client.repo": "googleapis/python-spanner",
+                "gcp.resource.name": "//spanner.googleapis.com/database_name",
             }
         )
         expected_attributes.update(extra_attributes)

tests/unit/test_batch.py

@@ -58,6 +58,7 @@
     "gcp.client.service": "spanner",
     "gcp.client.version": LIB_VERSION,
     "gcp.client.repo": "googleapis/python-spanner",
+    "gcp.resource.name": "//spanner.googleapis.com/testing",
     "cloud.region": "global",
 }
 enrich_with_otel_scope(BASE_ATTRIBUTES)

tests/unit/test_pool.py

@@ -155,6 +155,7 @@ class TestFixedSizePool(OpenTelemetryBase):
         "gcp.client.service": "spanner",
         "gcp.client.version": LIB_VERSION,
         "gcp.client.repo": "googleapis/python-spanner",
+        "gcp.resource.name": "//spanner.googleapis.com/name",
         "cloud.region": "global",
     }
     enrich_with_otel_scope(BASE_ATTRIBUTES)
@@ -549,6 +550,7 @@ class TestBurstyPool(OpenTelemetryBase):
         "gcp.client.service": "spanner",
         "gcp.client.version": LIB_VERSION,
         "gcp.client.repo": "googleapis/python-spanner",
+        "gcp.resource.name": "//spanner.googleapis.com/name",
         "cloud.region": "global",
     }
     enrich_with_otel_scope(BASE_ATTRIBUTES)
@@ -839,6 +841,7 @@ class TestPingingPool(OpenTelemetryBase):
         "gcp.client.service": "spanner",
         "gcp.client.version": LIB_VERSION,
         "gcp.client.repo": "googleapis/python-spanner",
+        "gcp.resource.name": "//spanner.googleapis.com/name",
         "cloud.region": "global",
     }
     enrich_with_otel_scope(BASE_ATTRIBUTES)

tests/unit/test_session.py

@@ -130,6 +130,7 @@ class TestSession(OpenTelemetryBase):
         "gcp.client.service": "spanner",
         "gcp.client.version": LIB_VERSION,
         "gcp.client.repo": "googleapis/python-spanner",
+        "gcp.resource.name": "//spanner.googleapis.com/" + DATABASE_NAME,
         "cloud.region": "global",
     }
     enrich_with_otel_scope(BASE_ATTRIBUTES)

tests/unit/test_snapshot.py

@@ -80,6 +80,7 @@
     "gcp.client.service": "spanner",
     "gcp.client.version": LIB_VERSION,
     "gcp.client.repo": "googleapis/python-spanner",
+    "gcp.resource.name": "//spanner.googleapis.com/testing",
 }
 enrich_with_otel_scope(BASE_ATTRIBUTES)
 
@@ -2232,6 +2233,7 @@ def _build_span_attributes(
         "gcp.client.service": "spanner",
         "gcp.client.version": LIB_VERSION,
         "gcp.client.repo": "googleapis/python-spanner",
+        "gcp.resource.name": "//spanner.googleapis.com/" + database.name,
         "x_goog_spanner_request_id": _build_request_id(database, attempt),
     }
     attributes.update(extra_attributes)

tests/unit/test_transaction.py

@@ -1344,6 +1344,7 @@ def _build_span_attributes(
                 "gcp.client.service": "spanner",
                 "gcp.client.version": LIB_VERSION,
                 "gcp.client.repo": "googleapis/python-spanner",
+                "gcp.resource.name": "//spanner.googleapis.com/" + database.name,
                 "cloud.region": GOOGLE_CLOUD_REGION_GLOBAL,
             }
         )