Skip to content

Commit b5c67f4

Browse files
committed
enums: fix method names
1 parent b0bf70a commit b5c67f4

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

enums/enums.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,22 +26,22 @@ type Registry struct {
2626
descriptors map[string]*Descriptor
2727
}
2828

29-
// RegisterDescriptor registers an enum descriptor.
30-
func (r *Registry) RegisterDescriptor(descriptor *Descriptor) error {
29+
// Register registers an enum descriptor.
30+
func (r *Registry) Register(descriptor *Descriptor) error {
3131
r.descriptorsMu.Lock()
3232
defer r.descriptorsMu.Unlock()
3333
if r.descriptors == nil {
3434
r.descriptors = make(map[string]*Descriptor)
3535
}
3636
if _, dup := r.descriptors[descriptor.Name]; dup {
37-
return errors.New("enums: RegisterDescriptor called twice for descriptor " + descriptor.Name)
37+
return errors.New("enums: Register called twice for descriptor " + descriptor.Name)
3838
}
3939
r.descriptors[descriptor.Name] = descriptor
4040
return nil
4141
}
4242

43-
// LookupDescriptor looks up an enum descriptor by name.
44-
func (r *Registry) LookupDescriptor(name string) *Descriptor {
43+
// Lookup looks up an enum descriptor by name.
44+
func (r *Registry) Lookup(name string) *Descriptor {
4545
r.descriptorsMu.RLock()
4646
defer r.descriptorsMu.RUnlock()
4747
if r.descriptors == nil {

enums/enums_test.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ import (
88

99
func TestRegistry(t *testing.T) {
1010
var r enums.Registry
11-
if r.LookupDescriptor("Color") != nil {
11+
if r.Lookup("Color") != nil {
1212
t.Errorf("LookupDescriptor failed: Color found")
1313
}
14-
if err := r.RegisterDescriptor(&enums.Descriptor{
14+
if err := r.Register(&enums.Descriptor{
1515
Name: "Color",
1616
Description: "Color enum",
1717
Members: []enums.MemberDescriptor{
@@ -22,7 +22,7 @@ func TestRegistry(t *testing.T) {
2222
}); err != nil {
2323
t.Errorf("RegisterDescriptor failed: %v", err)
2424
}
25-
if err := r.RegisterDescriptor(&enums.Descriptor{
25+
if err := r.Register(&enums.Descriptor{
2626
Name: "Shape",
2727
Description: "Shape enum",
2828
Members: []enums.MemberDescriptor{
@@ -33,7 +33,7 @@ func TestRegistry(t *testing.T) {
3333
}); err != nil {
3434
t.Errorf("RegisterDescriptor failed: %v", err)
3535
}
36-
if err := r.RegisterDescriptor(&enums.Descriptor{
36+
if err := r.Register(&enums.Descriptor{
3737
Name: "Color",
3838
Description: "Color enum",
3939
Members: []enums.MemberDescriptor{
@@ -45,7 +45,7 @@ func TestRegistry(t *testing.T) {
4545
t.Errorf("RegisterDescriptor failed: expected error, got nil")
4646
}
4747

48-
if d := r.LookupDescriptor("Color"); d == nil {
48+
if d := r.Lookup("Color"); d == nil {
4949
t.Errorf("LookupDescriptor failed: Color not found")
5050
} else {
5151
if d.Name != "Color" {
@@ -59,7 +59,7 @@ func TestRegistry(t *testing.T) {
5959
}
6060
}
6161

62-
if d := r.LookupDescriptor("Shape"); d == nil {
62+
if d := r.Lookup("Shape"); d == nil {
6363
t.Errorf("LookupDescriptor failed: Shape not found")
6464
} else {
6565
if d.Name != "Shape" {
@@ -73,7 +73,7 @@ func TestRegistry(t *testing.T) {
7373
}
7474
}
7575

76-
if d := r.LookupDescriptor("Size"); d != nil {
76+
if d := r.Lookup("Size"); d != nil {
7777
t.Errorf("LookupDescriptor failed: Size found")
7878
}
7979
}

0 commit comments

Comments
 (0)