From df06afdd892516cafa79b629aadd631ddfe349f1 Mon Sep 17 00:00:00 2001
From: "Timothy M. Shead" <tim@shead-custom-design.com>
Date: Sun, 5 Nov 2023 21:41:56 -0700
Subject: [PATCH 1/4] Add .gitignore.

---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 .gitignore

diff --git a/.gitignore b/.gitignore
new file mode 100644
index 0000000..a4e3482
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1 @@
+houdini_bookmarks/scripts/python/houdini_bookmarks/__pycache__

From fd9af834b4853e981a8722859bb422c1433f4119 Mon Sep 17 00:00:00 2001
From: "Timothy M. Shead" <tim@shead-custom-design.com>
Date: Sun, 5 Nov 2023 21:42:04 -0700
Subject: [PATCH 2/4] Remove excess whitespace.

---
 .../python_panels/houdini_bookmarks.pypanel   |  2 +-
 .../houdini_bookmarks/houdini_bookmarks.py    | 34 ++++++++++---------
 2 files changed, 19 insertions(+), 17 deletions(-)

diff --git a/houdini_bookmarks/python_panels/houdini_bookmarks.pypanel b/houdini_bookmarks/python_panels/houdini_bookmarks.pypanel
index 4f0e75a..31e7809 100644
--- a/houdini_bookmarks/python_panels/houdini_bookmarks.pypanel
+++ b/houdini_bookmarks/python_panels/houdini_bookmarks.pypanel
@@ -8,7 +8,7 @@
   <interface name="Houdini Bookmarks" label="Houdini Bookmarks" icon="MISC_python" showNetworkNavigationBar="false" help_url="">
     <script><![CDATA[from houdini_bookmarks import houdini_bookmarks
 
-def onCreateInterface():        
+def onCreateInterface():
     widget = None
     pane_tab = kwargs["paneTab"]
     if hou.applicationVersion()[0] < 18:
diff --git a/houdini_bookmarks/scripts/python/houdini_bookmarks/houdini_bookmarks.py b/houdini_bookmarks/scripts/python/houdini_bookmarks/houdini_bookmarks.py
index 40a5ddc..c08aa0a 100644
--- a/houdini_bookmarks/scripts/python/houdini_bookmarks/houdini_bookmarks.py
+++ b/houdini_bookmarks/scripts/python/houdini_bookmarks/houdini_bookmarks.py
@@ -2,6 +2,8 @@
 import re
 import os
 import hou
+import platform
+import subprocess
 import webbrowser
 import json
 
@@ -127,7 +129,7 @@ def closeEvent(self, event):
         for tab_index in range(self.tab_widget.count()):
             tree_view = self.tab_widget.widget(tab_index)
             self.remove_node_callbacks(tree_view)
-    
+
     def remove_node_callbacks(self, tree_view):
         if tree_view is not None:
             for key in tree_view.node_callbacks:
@@ -179,9 +181,9 @@ def save_to_file(self):
             for index in range(self.tab_widget.count()):
                 choices.append(self.tab_widget.tabBar().tabText(index))
             selection = hou.ui.selectFromList(choices, column_header="Tabs", message="Choose tabs to save:", width= 300, height=300)
-        
+
         data = prepare_save_data(self.tab_widget, selection)
-        
+
         with open(file_path, "w") as f:
             json.dump(data, f, indent=4)
 
@@ -200,7 +202,7 @@ def save_bookmarks_to_session(self, event_type, *args, **kwargs):
         if hasattr(hou.session, "get_houdini_bookmarks_data"):
             del(hou.session.get_houdini_bookmarks_data)
         hou.setSessionModuleSource(old_data + "\n" + code)
-    
+
     def load_bookmarks_from_session(self):
         if hasattr(hou.session, "get_houdini_bookmarks_data"):
             data = hou.session.get_houdini_bookmarks_data()
@@ -287,7 +289,7 @@ def copy_to_clipboard(self):
                 h_items.append(hou.item(self.item_path_label.text()))
                 if h_items[0] is not None:
                     h_items[0].parent().copyItemsToClipboard(h_items)
-    
+
     def update_description(self):
         try:
             index = self.tab_widget.currentWidget().selectedIndexes()[0]
@@ -297,7 +299,7 @@ def update_description(self):
         except:
             self.item_path_label.setText("")
             self.item_note.setText("")
-    
+
     def update_item_note(self):
         try:
             index = self.tab_widget.currentWidget().selectedIndexes()[0]
@@ -328,7 +330,7 @@ def mouseDoubleClickEvent(self, event):
         def finish_rename():
             self.setTabText(tab, line_edit.text())
             line_edit.deleteLater()
-            
+
         tab = self.tabAt(event.pos())
         rect = self.tabRect(tab)
         top_margin = 3
@@ -365,7 +367,7 @@ def focusOutEvent(self, event):
         if self._changed:
             self.editingFinished.emit()
         super(TextEdit, self).focusOutEvent(event)
-    
+
     def handle_text_changed(self):
         self._changed = True
 
@@ -413,7 +415,7 @@ def add_folder(self):
         if item is None:
             item = self.model()
         add_folder(item)
-    
+
     def add_bookmark(self):
         input = hou.ui.readInput("Enter a Bookmark Path:", buttons=("Node", "File", "URL", "Cancel"), default_choice=-1, close_choice=3)
         if input[0] is 3:
@@ -434,7 +436,7 @@ def add_bookmark(self):
         modifier = QtCore.Qt.KeyboardModifiers()
         event = QtGui.QDropEvent(pos, action, data, buttons, modifier)
         self.dropEvent(event)
-    
+
     def delete_selected(self):
         indicies = self.selectedIndexes()
         remove_from_indicies = list()
@@ -472,7 +474,7 @@ def delete_selected(self):
             parent_item.takeRow(item.row())
 
     def dropEvent(self, event):
-        if(event.source() == self): 
+        if(event.source() == self):
             super(TreeView, self).dropEvent(event)
         else:
             data_texts = list()
@@ -557,7 +559,7 @@ def save_set_callback(node, callback_function, event_type):
         save_set_callback(node, self.update_item_path, hou.nodeEventType.NameChanged)
         save_set_callback(node, self.update_item_data, hou.nodeEventType.AppearanceChanged)
         save_set_callback(node, self.mark_node_as_deleted, hou.nodeEventType.BeingDeleted)
-        
+
         parent = node.parent()
         while parent is not None and parent.path().count("/") > 1:
             save_set_callback(parent, self.update_item_path, hou.nodeEventType.NameChanged)
@@ -661,7 +663,7 @@ def paint(self, painter, option, index):
         for button in buttons:
             QtWidgets.QApplication.style().drawControl(QtWidgets.QStyle.CE_PushButton, button, painter)
         painter.restore()
-        
+
         option.rect = QtCore.QRect(option.rect.left(), option.rect.top(), option.rect.right()-button_width*3-button_spacing*3-option.rect.left(), option.rect.height())
         QtWidgets.QStyledItemDelegate.paint(self, painter, option, index)
 
@@ -714,7 +716,7 @@ def editorEvent(self, event, model, option, index):
                             open_parameter_tab(item, event.globalPos())
                         if item.data()["category"] == "file":
                             open_file(item)
-                        
+
             self.event_pos = QtCore.QPoint()
             self._pressed = None
             return True
@@ -734,7 +736,7 @@ def add_folder(item):
     data = {"note": "", "path": "", "category": "folder", "icon_type": icon_type, "color": (0.8, 0.8, 0.8)}
     new_item.setData(data, QtCore.Qt.UserRole + 1)
     item.appendRow(new_item)
-    
+
 def open_parameter_tab(item, global_mouse_pos):
     node = hou.nodeBySessionId(int(item.data().get("session_id")))
     if node is None:
@@ -812,4 +814,4 @@ def iterate_items(root):
                     child = parent.child(row, column)
                     yield child
                     if child.hasChildren():
-                        stack.append(child)
\ No newline at end of file
+                        stack.append(child)

From a91bf750e321abd92176c85c74a506588de4635e Mon Sep 17 00:00:00 2001
From: "Timothy M. Shead" <tim@shead-custom-design.com>
Date: Sun, 5 Nov 2023 21:50:23 -0700
Subject: [PATCH 3/4] Opening files works on all platforms.

---
 .../python/houdini_bookmarks/houdini_bookmarks.py    | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/houdini_bookmarks/scripts/python/houdini_bookmarks/houdini_bookmarks.py b/houdini_bookmarks/scripts/python/houdini_bookmarks/houdini_bookmarks.py
index c08aa0a..438698d 100644
--- a/houdini_bookmarks/scripts/python/houdini_bookmarks/houdini_bookmarks.py
+++ b/houdini_bookmarks/scripts/python/houdini_bookmarks/houdini_bookmarks.py
@@ -774,11 +774,19 @@ def eval_open_item_function(item, panel):
     elif item.data()["category"] == "webUrl":
         open_url(item)
 
+def platform_open(path):
+    if platform.system() == "Darwin":
+        subprocess.call(("open", path))
+    elif platform.system() == "Windows":
+        os.startfile(path)
+    else:
+        subprocess.call(("xdg-open", path))
+
 def open_file(item):
-    os.startfile(item.data().get("path"))
+    platform_open(item.data().get("path"))
 
 def open_file_dir(item):
-    os.startfile(os.path.dirname(item.data().get("path")))
+    platform_open(os.path.dirname(item.data().get("path")))
 
 def open_url(item):
     webbrowser.open(item.data().get("path"), new=0, autoraise=True)

From d9e5f4307af798f3e2652f4d607f49bcafe6ccb5 Mon Sep 17 00:00:00 2001
From: "Timothy M. Shead" <tim@shead-custom-design.com>
Date: Sun, 5 Nov 2023 21:54:01 -0700
Subject: [PATCH 4/4] Fix syntax warnings.

---
 .../scripts/python/houdini_bookmarks/houdini_bookmarks.py     | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/houdini_bookmarks/scripts/python/houdini_bookmarks/houdini_bookmarks.py b/houdini_bookmarks/scripts/python/houdini_bookmarks/houdini_bookmarks.py
index 438698d..dbbf88b 100644
--- a/houdini_bookmarks/scripts/python/houdini_bookmarks/houdini_bookmarks.py
+++ b/houdini_bookmarks/scripts/python/houdini_bookmarks/houdini_bookmarks.py
@@ -418,11 +418,11 @@ def add_folder(self):
 
     def add_bookmark(self):
         input = hou.ui.readInput("Enter a Bookmark Path:", buttons=("Node", "File", "URL", "Cancel"), default_choice=-1, close_choice=3)
-        if input[0] is 3:
+        if input[0] == 3:
             return
         path = input[1]
         data = QtCore.QMimeData()
-        if input[0] is 1:
+        if input[0] == 1:
             path.encode("unicode_escape")
             path = "file:///"+path
         if input[0] in [1,2]: