Skip to content

Conversation

schmikei
Copy link
Contributor

This introduces more usage of grafana modular lib and logs lib to the couchbase mixin. Functionality should retain the same.

Cluster Overview:
image

Node Overview:
image

Bucket Overview:
image

Logs:
image

@schmikei schmikei requested a review from a team as a code owner June 19, 2025 12:32
@schmikei schmikei marked this pull request as draft June 19, 2025 12:49
@schmikei schmikei marked this pull request as ready for review August 13, 2025 14:04
Copy link
Member

@Dasomeone Dasomeone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I'd forgotten to hit submit review in my hate last time I looked at this, so only updated one comment.
Overall this one looks perfectly good to me, just with the minor details mentioned

Copy link
Member

@Dasomeone Dasomeone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Looks fantastic, thank you so much for all the iteration and hard work on this one Keith!
(and for bearing with us with the delayed reviews 😅)

I think this would be a great standard to compare the other current PRs to, e.g. with the aggregate sum/group bys, the instance label aggregation, etc

@Dasomeone Dasomeone merged commit a0c465d into grafana:master Sep 3, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants