-
Notifications
You must be signed in to change notification settings - Fork 177
feat: grafana modular lib Couchbase #1454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: grafana modular lib Couchbase #1454
Conversation
…uchbase-modernization
…uchbase-modernization
…onnet-libs into feat/couchbase-modernization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like I'd forgotten to hit submit review in my hate last time I looked at this, so only updated one comment.
Overall this one looks perfectly good to me, just with the minor details mentioned
…uchbase-modernization
…abels/instance labels, rename logs dashboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! Looks fantastic, thank you so much for all the iteration and hard work on this one Keith!
(and for bearing with us with the delayed reviews 😅)
I think this would be a great standard to compare the other current PRs to, e.g. with the aggregate sum/group bys, the instance label aggregation, etc
This introduces more usage of grafana modular lib and logs lib to the couchbase mixin. Functionality should retain the same.
Cluster Overview:

Node Overview:

Bucket Overview:

Logs:
