chore: IBM MQ mixin modernization #1557
Conversation
schmikei
force-pushed
the
ibm-mq-modernization
branch
from
b01900a to
321be7d
Compare
Dasomeone
left a comment
Dasomeone
left a comment
There was a problem hiding this comment.
Couple minor comments here, overall looks great
ibm-mq-mixin/alerts.libsonnet
Outdated
| summary: 'There are expired messages, which imply that application resilience is failing.', | ||
| description: | ||
| ( | ||
| 'The number of expired messages in the {{$labels.qmgr}} is {{$labels.value}} which is above the threshold of %(alertsExpiredMessages)s.' |
There was a problem hiding this comment.
Shouldn't the description reference the $value of metric? Probably need to format it as well: {{ printf "%.0f" $value }}, WDYT?
ibm-mq-mixin/alerts.libsonnet
Outdated
| summary: 'Stale messages have been detected.', | ||
| description: | ||
| ( | ||
| 'A stale message with an age of {{$labels.value}} has been sitting in the {{$labels.queue}} which is above the threshold of %(alertsStaleMessagesSeconds)ss.' |
There was a problem hiding this comment.
Same comment about referencing {{ $value }} instead of {{ $labels.value }}.
ibm-mq-mixin/alerts.libsonnet
Outdated
| summary: 'There is limited disk available for a queue manager.', | ||
| description: | ||
| ( | ||
| 'The amount of disk space available for {{$labels.qmgr}} is at {{$labels.value}}%% which is below the threshold of %(alertsLowDiskSpace)s%%.' |
There was a problem hiding this comment.
Same comment about referencing {{ $value }} instead of {{ $labels.value }}.
ibm-mq-mixin/alerts.libsonnet
Outdated
| summary: 'There is a high CPU usage estimate for a queue manager.', | ||
| description: | ||
| ( | ||
| 'The amount of CPU usage for the queue manager {{$labels.qmgr}} is at {{$labels.value}}%% which is above the threshold of %(alertsHighQueueManagerCpuUsage)s%%.' |
There was a problem hiding this comment.
Same comment about referencing {{ $value }} instead of {{ $labels.value }}.
ibm-mq-mixin/signals/queue.libsonnet
Outdated
| name: 'Time on queue', | ||
| type: 'gauge', | ||
| description: 'The average time messages spent on the queue.', | ||
| unit: 'µs', |
There was a problem hiding this comment.
The metric says _seconds but the unit says micro seconds, can you please change it to 's'?
There was a problem hiding this comment.
I do think this one needs updating though, thanks for the catch 👍
| signals.queueManager.queueOperationsMqput.asTarget(), | ||
| ]) | ||
| + g.panel.timeSeries.panelOptions.withDescription('The number of queue operations of the queue manager.') | ||
| + g.panel.timeSeries.standardOptions.withUnit('operations') |
There was a problem hiding this comment.
I don't think 'operations' is a unit that we support in jsonnet-lib/common-lib. Can we use 'short' instead?
| signals.queue.mqputMqput1Count.asTarget(), | ||
| ]) | ||
| + g.panel.timeSeries.panelOptions.withDescription('The number of queue operations of the queue manager.') | ||
| + g.panel.timeSeries.standardOptions.withUnit('operations') |
There was a problem hiding this comment.
I don't think 'operations' is a unit that we support in jsonnet-lib/common-lib. Can we use 'short' instead?
There was a problem hiding this comment.
Several signals have the unit 'operations' and I don't think it is a supported unit in jsonnet-libs/common-lib. Can we use 'short' instead?
There was a problem hiding this comment.
Similar to queue signals.
Several signals have the unit 'operations' and I don't think it is a supported unit in jsonnet-libs/common-lib. Can we use 'short' instead?
There was a problem hiding this comment.
Similar to the two other signals files.
Several signals have the unit 'operations' and I don't think it is a supported unit in jsonnet-libs/common-lib. Can we use 'short' instead?
There was a problem hiding this comment.
operations is preferable here actually. If Grafana doesn't recognise a unit, it's treated as a custom string unit, so it'll be just fine
Dasomeone
left a comment
Dasomeone
left a comment
There was a problem hiding this comment.
Couple more comments, overall I'm happy with it!
There was a problem hiding this comment.
operations is preferable here actually. If Grafana doesn't recognise a unit, it's treated as a custom string unit, so it'll be just fine
3 participants
Updates the IBM MQ mixin to use more modern libraries
IBM MQ cluster overviewIBM MQ queue manager overviewIBM MQ queue overviewIBM MQ topic overviewIBM MQ logsMetrics should be flowing to the shared Grafana instance on Nov 25 12pm-5pm EST :)