-
Notifications
You must be signed in to change notification settings - Fork 122
WIP feat(api): conditional breaking changes based on app deployments #7388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @adambenhassen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the management of application deployments by introducing a powerful new GraphQL query, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
📚 Storybook DeploymentThe latest changes are available as preview in: https://pr-7388.hive-storybook.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new feature for identifying stale application deployments and showing which deployments are affected by breaking schema changes. The changes include new GraphQL queries, extensive integration tests, and updates to the backend logic and documentation.
Overall, this is a significant and valuable feature. My review has identified two main areas for improvement:
- A correctness issue in how affected application deployments are associated with breaking changes. The current implementation incorrectly links all affected deployments to every breaking change, rather than scoping them to the specific change.
- A scalability and correctness concern in the implementation of the
activeAppDeploymentsquery, which could lead to incomplete results and performance issues as the number of deployments grows.
Addressing these points will improve the correctness and robustness of this new functionality.
packages/services/api/src/modules/schema/providers/schema-publisher.ts
Outdated
Show resolved
Hide resolved
packages/services/api/src/modules/app-deployments/providers/app-deployments.ts
Show resolved
Hide resolved
💻 Website PreviewThe latest changes are available as preview in: https://pr-7388.hive-landing-page.pages.dev |
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
Closes CONSOLE-1276