Skip to content

Conversation

@adambenhassen
Copy link
Collaborator

@adambenhassen adambenhassen commented Dec 8, 2025

Closes CONSOLE-1276

@adambenhassen adambenhassen marked this pull request as draft December 8, 2025 13:11
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @adambenhassen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the management of application deployments by introducing a powerful new GraphQL query, activeAppDeployments, designed to help users identify and manage stale or unused deployments. It also integrates app deployment impact analysis directly into schema checks, providing critical information about which active applications would be affected by breaking changes. These features aim to streamline the lifecycle management of app deployments and improve schema evolution safety.

Highlights

  • New GraphQL Query for App Deployments: Introduced activeAppDeployments GraphQL query to efficiently find app deployments based on usage and creation criteria, aiding in identifying stale deployments.
  • Enhanced Filtering Capabilities: Added new filter options for activeAppDeployments: lastUsedBefore (for recently used but now stale deployments), neverUsedAndCreatedBefore (for old, unused deployments), and name (for partial, case-insensitive matching).
  • Schema Check Integration: Breaking schema changes now include a list of affectedAppDeployments, providing immediate insight into which active applications would be impacted by a proposed schema change.
  • App Deployment Metadata: The createdAt field has been added to the AppDeployment type, offering more context for deployment lifecycle management.
  • Documentation Update: Comprehensive documentation has been added to guide users on finding and managing stale app deployments, including GraphQL API examples and workflow suggestions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
hive 8.13.0-alpha-20251208171247-aa828b68d1f61d9da709e43d508667286b4ecf61 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

📚 Storybook Deployment

The latest changes are available as preview in: https://pr-7388.hive-storybook.pages.dev

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new feature for identifying stale application deployments and showing which deployments are affected by breaking schema changes. The changes include new GraphQL queries, extensive integration tests, and updates to the backend logic and documentation.

Overall, this is a significant and valuable feature. My review has identified two main areas for improvement:

  1. A correctness issue in how affected application deployments are associated with breaking changes. The current implementation incorrectly links all affected deployments to every breaking change, rather than scoping them to the specific change.
  2. A scalability and correctness concern in the implementation of the activeAppDeployments query, which could lead to incomplete results and performance issues as the number of deployments grows.

Addressing these points will improve the correctness and robustness of this new functionality.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

💻 Website Preview

The latest changes are available as preview in: https://pr-7388.hive-landing-page.pages.dev

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

🐋 This PR was built and pushed to the following Docker images:

Targets: build

Platforms: linux/amd64

Image Tag: aa828b68d1f61d9da709e43d508667286b4ecf61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant