Support for extensions

[ewhauser]

In graphene-tornado, we've added support for extensions similar to Apollo Server. These extensions provide the capability to do things like add Apollo Tracing or distributed tracing to requests.

This capability would be great to add to graphql-server-core (it's a blocker for graphene-tornado to migrate). Is there interest in having this functionality in this project? Specifically, I'm suggesting we add the extension points defined here.

[KingDarBoja]

Hi @ewhauser,

Does this issue still required or it has been solved on graphene-tornado?

[ewhauser]

@KingDarBoja I have built a version of this in graphene-tornado but would love to see these extension points graphql-server-core. In graphene-tornado, you'll note that we have extension points for Apollo Tracing and OpenCensus that are built on top of this functionality. I'm sure there are a lot of Python GraphQL users who could benefit from those extensions.

I'm willing to submit a PR for this if there is interest. If we could get the extensions into graphql-server-core, then I'll convert graphene-tornado over to using it.

[KingDarBoja]

That's great, I have already migrated graphql-server-core to use graphql-core v3, which is the latest available version, being compatible with Graphql.js v15. Right now, merging flask-graphql into it too and will do the same with sanic-graphql and so on.

Feel free to push a PR 🚀

[syrusakbary]

Hey @KingDarBoja , we need to publish new versions of graphql-server, but I'm no longer an admin.

I would like to continue using this name, can you make an admin of the package? If not, we will need to rename this project back to graphql-server-core. Thanks

[KingDarBoja]

Hey @KingDarBoja , we need to publish new versions of graphql-server, but I'm no longer an admin.

I would like to continue using this name, can you make an admin of the package? If not, we will need to rename this project back to graphql-server-core. Thanks

Hi, I would like to do so but I am not Admin of this repository (The settings tabs doesn't show for me). I believe one of the folks at the https://github.com/orgs/graphql-python/people can give you admin permissions.

[syrusakbary]

Hey @KingDarBoja,

Thanks for the quick response!

Maybe my previous message was a bit confusing. I need owner permissions of the graphql-server package on PyPI (my PyPI user is: syrusakbary). There are many new changes coming, for which I need to automate package versioning and more.

I already have admin rights onto the repo, so no changes are needed on the GitHub side.

[KingDarBoja]

syrusakbary

Done! Been a while since I checked PyPi and rarely used Python these days, so I added you as owner (as it should be) 🚀

[syrusakbary]

Great, thanks ❤️