add more test coverage

Author: dschafer

src/__tests__/starWarsObjectIdentificationTests.js

@@ -76,7 +76,7 @@ describe('Object Identification Tests', () => {
       expect(result).to.deep.equal({ data: expected });
     });
 
-    it('Correctly refetches the rebels', async () => {
+    it('Correctly refetches the empire', async () => {
       var query = `
         query EmpireRefetchQuery {
           node(id: "RmFjdGlvbjoy") {
@@ -96,5 +96,26 @@ describe('Object Identification Tests', () => {
       var result = await graphql(StarWarsSchema, query);
       expect(result).to.deep.equal({ data: expected });
     });
+
+    it('Correctly refetches the X-Wing', async () => {
+      var query = `
+        query XWingRefetchQuery {
+          node(id: "U2hpcDox") {
+            id
+            ... on Ship {
+              name
+            }
+          }
+        }
+      `;
+      var expected = {
+        node: {
+          id: 'U2hpcDox',
+          name: 'X-Wing'
+        }
+      };
+      var result = await graphql(StarWarsSchema, query);
+      expect(result).to.deep.equal({ data: expected });
+    });
   });
 });

src/connection/__tests__/arrayconnection.js

@@ -466,6 +466,22 @@ describe('connectionFromArray', () => {
   });
 
   describe('Handles cursor edge cases', () => {
+    it('Returns no elements if first is 0', () => {
+      var c = connectionFromArray(
+        letters,
+        {first: 0}
+      );
+      return expect(c).to.deep.equal({
+        edges: [],
+        pageInfo: {
+          startCursor: null,
+          endCursor: null,
+          hasPreviousPage: false,
+          hasNextPage: false,
+        }
+      });
+    });
+
     it('Returns all elements if cursors are invalid', () => {
       var c = connectionFromArray(
         letters,

src/node/__tests__/global.js

@@ -53,20 +53,16 @@ var {nodeField, nodeInterface} = nodeDefinitions(
     var {type, id} = fromGlobalId(globalId);
     if (type === 'User') {
       return userData[id];
-    }
-    if (type === 'Photo') {
+    } else {
       return photoData[id];
     }
-    return null;
   },
   (obj) => {
     if (obj.id) {
       return userType;
-    }
-    if (obj.photoId) {
+    } else {
       return photoType;
     }
-    return null;
   }
 );
 

src/node/__tests__/node.js

@@ -52,20 +52,16 @@ var {nodeField, nodeInterface} = nodeDefinitions(
     expect(info.schema).to.equal(schema);
     if (userData[id]) {
       return userData[id];
-    }
-    if (photoData[id]) {
+    } else {
       return photoData[id];
     }
-    return null;
   },
   (obj) => {
     if (userData[obj.id]) {
       return userType;
-    }
-    if (photoData[obj.id]) {
+    } else {
       return photoType;
     }
-    return null;
   }
 );
 

src/node/__tests__/nodeasync.js

@@ -34,17 +34,11 @@ var userData = {
 };
 
 var {nodeField, nodeInterface} = nodeDefinitions(
-  async (id) => {
-    if (userData[id]) {
-      return userData[id];
-    }
-    return null;
+  (id) => {
+    return userData[id];
   },
-  (obj) => {
-    if (userData[obj.id]) {
-      return userType;
-    }
-    return null;
+  () => {
+    return userType;
   }
 );